[vbox-dev] [PATCH] performance improvements for Solaris guest shared folders

[Life is hard, and then you die]

On Thu, Nov 17, 2011 at 02:30:51PM +0100, Ramshankar wrote:
> On 11/17/11 06:27 AM, Life is hard, and then you die wrote:
> >On Tue, Nov 15, 2011 at 05:56:22PM +0100, Ramshankar wrote:
> >>I've applied all the patches with some minor adjustments. Only the
> >>bug fixes have been backported to 4.1.x. The performance fixes will
> >>require more testing before I backport them.
> >
> >Excellent! Thank you.
> >
> >However, one more small issue: it appears two lines got dropped when
> >applying the last patch (Pass file/dir mode directly to create/mkdir
> >call) - the remaining diff I have is:
> >
> >----------------------------------------------------------------------
> >--- a/src/VBox/Additions/solaris/SharedFolders/vboxfs_vnode.c
> >+++ b/src/VBox/Additions/solaris/SharedFolders/vboxfs_vnode.c
> >@@ -587,11 +587,13 @@ sfnode_lookup(
> >          */
> >         if (create == VREG) {
> >                 type = VREG;
> >+               stat =&tmp_stat;
> >                 error = sfprov_create(dir->sf_sffs->sf_handle, fullpath, c_mode,
> >                                         &fp, stat);
> >                 stat_time = sfnode_cur_time_usec();
> >         } else if (create == VDIR) {
> >                 type = VDIR;
> >+               stat =&tmp_stat;
> >                 error = sfprov_mkdir(dir->sf_sffs->sf_handle, fullpath, c_mode,
> >                                         &fp, stat);
> >                 stat_time = sfnode_cur_time_usec();
> >----------------------------------------------------------------------
> >
> >These are needed because the passed in stat may be NULL (and in fact it
> >is always NULL in the current code paths). Also, even if it isn't NULL,
> >it would be questionable to modify the contents of the passed in stat.
> 
> It won't be NULL in the symlink case but yeah we shouldn't be
> modifying the passed-in stat there. Will change it. Thanks

Sorry, I meant that in those two branches stat is currently always
NULL (in the symlink case create == VLNK, so it goes through the 3rd
branch instead).


  Cheers,

  Ronald