[vbox-dev] Fix for OS type autodetection

flint at flint-inc.ru flint at flint-inc.ru
Tue May 31 09:11:11 PDT 2011


  Hi, everybody.

I've discovered that there is a bug in regexp that is used when the New VM 
wizard detects the OS type while user types the machine name. Win2003-x64 system 
is consequently not detected. Here is the fix:

Index: src/VBox/Frontends/VirtualBox/src/wizards/newvm/UINewVMWzd.cpp
===================================================================
--- src/VBox/Frontends/VirtualBox/src/wizards/newvm/UINewVMWzd.cpp      (revision 37206)
+++ src/VBox/Frontends/VirtualBox/src/wizards/newvm/UINewVMWzd.cpp      (working copy)
@@ -49,7 +49,7 @@
     { QRegExp("(Wi.*NT)|(NT4)", Qt::CaseInsensitive), "WindowsNT4" },
     { QRegExp("((Wi.*XP)|(\\bXP\\b)).*64", Qt::CaseInsensitive), "WindowsXP_64" },
     { QRegExp("(Wi.*XP)|(\\bXP\\b)", Qt::CaseInsensitive), "WindowsXP" },
-    { QRegExp("((Wi.*2003)|(W2K3).*64", Qt::CaseInsensitive), "Windows2003_64" },
+    { QRegExp("((Wi.*2003)|(W2K3)).*64", Qt::CaseInsensitive), "Windows2003_64" },
     { QRegExp("(Wi.*2003)|(W2K3)", Qt::CaseInsensitive), "Windows2003" },
     { QRegExp("((Wi.*V)|(Vista)).*64", Qt::CaseInsensitive), "WindowsVista_64" },
     { QRegExp("(Wi.*V)|(Vista)", Qt::CaseInsensitive), "WindowsVista" },

I don't think it's so necessary to explicitly license such a fix, but just in 
case, I license it under MIT. :-)

-- 
Bye.                                    With best regards,
                                        Konstantin Vlasov.





More information about the vbox-dev mailing list