[vbox-dev] [PATCH] UDPTunnel : new network interface backend to allow using this to link to GNS3 and QEMU instances over the network

[Mario Lobo]

On Tuesday 10 May 2011 18:53:05 Alexey Eromenko wrote:
> I would like to thank Chris for his hard work on this feature.
> It will really advance VirtualBox networking to the next level.
> 
> In addition, I wrote a patch for VBox Documentation.
> Both patched are licensed under MIT.
> 
> Tested on Debian Linux 6.0 (Squeeze) 32-bit and 64-bit.
> Other applications that support UDP mode are: patched Qemu, Dynamips,
> GNS3 (management layer), and VPCS.
> 
> Oracle:
> Please review both patched for inclusion in v4.1.

First of all, thanks for this wonderful idea and for stirring up this patch!

I wanted very much to try it (and gns3!) but this patch does not apply 
correctly on 4.0.6 src tree (FreeBSD port).

-----------------------------------------------------------
patch -p0 -i patch-udptunnel-v5a-r37019.patch

Patching file 
src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsNetwork.h 
using Plan A...
Hunk #1 failed at 42.
Hunk #2 failed at 62.
Hunk #3 succeeded at 47 (offset -37 lines).
Hunk #4 failed at 120.

Patching file 
src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsNetwork.cpp 
using Plan A...
Hunk #1 succeeded at 144 with fuzz 2 (offset 21 lines).
Hunk #2 succeeded at 129 with fuzz 2 (offset -52 lines).
Hunk #3 succeeded at 323 with fuzz 2 (offset 18 lines).
Hunk #4 succeeded at 339 with fuzz 2 (offset -40 lines).
Hunk #5 succeeded at 516 with fuzz 1 (offset 18 lines).
Hunk #6 failed at 609.
Hunk #7 failed at 848.
Hunk #8 failed at 997.

Patching file src/VBox/Frontends/VBoxManage/Makefile.kmk using Plan A...
Hunk #1 failed at 70.
-----------------------------------------------------------

Given tha FreeBSD has its own set of patches to apply before compiling,
I must say that this is a very little error list compared to what applies 
correctly but there are terms and declarations in your patch that do not exist 
anywhere else in 4.0.6 src tree. You can see them at the failed hunks.

One example is in 
src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsNetwork.h

On the following hunk
@@ -148,6 +157,9 @@
     QString m_strBrgName;
     QString m_strIntName;
     QString m_strHoiName;
+#ifdef VBOX_WITH_UDPTUNNEL
+    QString mUDPTunnelEndpoint;
+#endif /* VBOX_WITH_UDPTUNNEL */
 #ifdef VBOX_WITH_VDE
     QString mVDEName;
 #endif /* VBOX_WITH_VDE */


A grep -R on the variable "m_strBrgName" in 
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.0.6_OSE returns nothing.

So, must I assume that I'll have to wait for 4.1.0 for this to work?

Thanks,

-- 
Mario Lobo
http://www.mallavoodoo.com.br
FreeBSD since 2.2.8 [not Pro-Audio.... YET!!] (99% winblows FREE)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20110511/2159859c/attachment.html>