[vbox-dev] [PATCH] Fix integer truncation when writing XML files

Frank Mehnert frank.mehnert at oracle.com
Thu Jan 27 11:25:20 GMT 2011


Benjamin,

On Thursday 27 January 2011 04:53:10 Benjamin Gilbert wrote:
> When VirtualBox >= 4.0.0 writes out the machine XML file, it truncates
> <CpuIdLeaf> attribute values to nine decimal digits.  This can corrupt
> some CPUID register values and always corrupts leaf IDs >= 0x80000000,
> causing all leaves in the extended CPUID region to be ignored the next
> time the machine is loaded (and dropped from the XML the next time it
> is saved).  The cause is commit r33469, which reduced the size of
> buffers in the XML formatting code below the maximum needed to
> represent integer data types.  The patch below, which is released under
> the MIT license, corrects this.

thanks for this fix! Applied.

Kind regards,

Frank
-- 
ORACLE Deutschland B.V. & Co. KG   Dr.-Ing. Frank Mehnert
Werkstrasse 24                     Staff Engineer, VirtualBox
71384 Weinstadt, Germany           mailto:frank.mehnert at oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20110127/34154889/attachment.sig>


More information about the vbox-dev mailing list