[vbox-dev] [PATCH] Cannot change to non-standard baud rates [Ref TICKET: #3334]

Klaus Espenlaub Klaus.Espenlaub at Sun.COM
Tue Mar 16 05:53:23 PDT 2010


Hello Mariusz,

manio wrote:
> Klaus Espenlaub wrote:
>> Manio wrote:
>>> Hello again.
>>> I just want to ask - if there is a chance to commit my patch - was it 
>>> reviewed and is it ok?
>>
>> It breaks OSX. OSX and Linux are using the same code, and OSX doesn't 
>> have linux headers. So it needs to be cleaned up a bit.
>>
>> The basic code seems ok from a first look.
>>
>> Klaus
>>
> 
> Hello
> Sorry for very long delay. I am attaching fixed patch (made on trunk) - 
> i hope it is ok now (patch license: MIT).

Applied a slightly modified version of your change (saw no reason for 
dynamic memory allocation, and added a minimal amount of ioctl error 
checking). r27394 in the VirtualBox OSE repository. Let me know if I 
broke your code.

Thanks again for the contribution,

Klaus

> 
> regards,
> Mariusz Bialonczyk
> 




More information about the vbox-dev mailing list