[vbox-dev] another crash when shutting down (a very weird one)

[Huihong Luo]

to do with mini tool bar release, the only fix I can think of is to add deletes in destructors, see below:
 
UIMachineWindowFullscreen::~UIMachineWindowFullscreen()
{
/* Save window settings: */
saveWindowSettings();
/* Cleanup machine view: */
cleanupMachineView();
/* Cleanup menu: */
cleanupMenu();
if (m_pMiniToolBar)
{
delete m_pMiniToolBar;
m_pMiniToolBar = 0;
}
}
 
UIMachineWindowSeamless::~UIMachineWindowSeamless()
{
CMachine machine = session().GetConsole().GetMachine();
machine.SetExtraData (VBoxDefs::GUI_SeamlessVmWindowWinID, NULL); 
/* Save window settings: */
saveWindowSettings();
/* Cleanup machine view: */
cleanupMachineView();
/* Cleanup menu: */
cleanupMenu();
if (m_pMiniToolBar)
{
delete m_pMiniToolBar;
m_pMiniToolBar = 0;
}
}
 
you may want to attach a debugger during shutdown, it may throw all kinds of errors.
 
 
 
/////////////////////////////
 
QtCore4.dll!67002c03()  
  [Frames below may be incorrect and/or missing, no symbols loaded for QtCore4.dll] 
  QtCore4.dll!670e2635()  
  QtCore4.dll!670e65c3()  
  QtGui4.dll!65054e68()  
  msvcr80.dll!free(void * pBlock=0x04307ba8)  Line 115 + 0x5 bytes C
  QtGui4.dll!6504769d()  
  QtCore4.dll!670e2f77()  
  QtGui4.dll!65054de8()  
  QtCore4.dll!670f2c29()  
  QtCore4.dll!670d7344()  
  QtGui4.dll!6532a0be()  
  VirtualBox.exe!VBoxMiniToolBar::~VBoxMiniToolBar()  + 0xd4 bytes C++
  VirtualBox.exe!VBoxMiniToolBar::`scalar deleting destructor'()  + 0x8 bytes C++
  QtCore4.dll!670e2f77()  
  QtGui4.dll!65054de8()  
  VirtualBox.exe!QWidget::`scalar deleting destructor'()  + 0x9 bytes C++
  QtCore4.dll!670e2f77()  
  QtGui4.dll!65054de8()  
  VirtualBox.exe!UIMachineWindowSeamless::~UIMachineWindowSeamless()  Line 126 + 0x4b bytes C++
  VirtualBox.exe!UIMachineWindowSeamless::`scalar deleting destructor'()  + 0x8 bytes C++
  VirtualBox.exe!UIMachineWindow::destroy(UIMachineWindow * pWhichWindow=0x050bbb44)  Line 76 C++
  VirtualBox.exe!UIMachineLogicSeamless::cleanupMachineWindows()  Line 212 + 0x6 bytes C++
  VirtualBox.exe!UIMachineLogicSeamless::~UIMachineLogicSeamless()  Line 57 C++
  VirtualBox.exe!UIMachineLogicSeamless::`scalar deleting destructor'()  + 0x8 bytes C++
  QtCore4.dll!670e2f77()  
  QtCore4.dll!670e6881()  
  VirtualBox.exe!UIVisualStateSeamless::~UIVisualStateSeamless()  Line 251 + 0x10 bytes C++
  VirtualBox.exe!UIVisualStateSeamless::`scalar deleting destructor'()  + 0x8 bytes C++
  VirtualBox.exe!UIMachine::~UIMachine()  Line 320 C++
  VirtualBox.exe!UIMachine::`scalar deleting destructor'()  + 0x8 bytes C++
  VirtualBox.exe!UIMachine::closeVirtualMachine()  Line 403 C++
  VirtualBox.exe!UISession::sltCloseVirtualSession()  Line 953 C++
  VirtualBox.exe!UISession::qt_metacall(QMetaObject::Call _c=InvokeMetaMethod, int _id=17, void * * _a=0x0012d820)  Line 111 C++
  QtCore4.dll!670e4f55()  
  QtCore4.dll!670e8c36()  
  QtCore4.dll!670e272e()  
  QtCore4.dll!670d383d()  
  QtCore4.dll!67129f93()  
  QtGui4.dll!65015e18()  
  QtGui4.dll!65019f8e()  
  QtGui4.dll!65051861()  
  QtGui4.dll!65052fd5()  
  VirtualBox.exe!VBoxQGLOverlay::repaintMain()  Line 4353 C++
  VirtualBox.exe!VBoxQGLOverlay::onVHWACommandEvent(QEvent * pEvent=0x043b20b0)  Line 4282 + 0x12 bytes C++
  VirtualBox.exe!UIMachineView::event(QEvent * pEvent=0x670071d0)  Line 709 C++
  msvcr80.dll!free(void * pBlock=0x011e1760)  Line 115 + 0x5 bytes C
  QtCore4.dll!670d31fe()  
  QtCore4.dll!670d5079()  
  QtCore4.dll!670f4a43()  
  QtGui4.dll!6523200e()  
  QtGui4.dll!65242f80()  
  QtGui4.dll!65244f64()  
  QtGui4.dll!6523200e()  
  QtGui4.dll!65242f80()  
  QtGui4.dll!65244f64()  
  user32.dll!_RealSystemParametersInfoW at 16()  + 0x6a bytes 
  uxtheme.dll!_InternalSystemParametersInfo()  + 0x2b bytes 
  uxtheme.dll!_ThemeSystemParametersInfoW at 16()  + 0x50 bytes 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.virtualbox.org/pipermail/vbox-dev/attachments/20100726/26130ea6/attachment-0001.html