[vbox-dev] bug - TRANSIENT guest property can't get deleted?

[Huihong Luo]

Thanks for the fix. I confirmed that it fixed the issue of transient property becoming permanent after delete.
 
But still have some problems deleting guest properties, the xml file still shows some temp guest property after value is set to NULL. The good thing is that they won't get saved to the xml after vm is shutdown.

--- On Fri, 7/30/10, Michael Thayer <michael.thayer at oracle.com> wrote:


From: Michael Thayer <michael.thayer at oracle.com>
Subject: Re: [vbox-dev] bug - TRANSIENT guest property can't get deleted?
To: "Huihong Luo" <huisinro at yahoo.com>
Cc: vbox-dev at virtualbox.org
Date: Friday, July 30, 2010, 2:09 AM


Hello Huihong,

Le vendredi 23 juillet 2010 à 11:32 +0200, Michael Thayer a écrit :
> Le jeudi 22 juillet 2010 à 18:50 -0700, Huihong Luo a écrit :
> > when a TRANSIENT guest property is deleted, it becomes permanent after
> > vm is shutdown. kind of weird.
> Confirmed, will investigate.
This is fixed in the 3.2 branch as follows:

Index: src/VBox/Main/MachineImpl.cpp
===================================================================
--- src/VBox/Main/MachineImpl.cpp
+++ src/VBox/Main/MachineImpl.cpp
@@ -10374,5 +10374,5 @@
                 break;
             }
-        if (aValue != NULL)
+        if (aValue != NULL && aValue[0] != '\0')
         {
             HWData::GuestProperty property = { aName, aValue, aTimestamp, fFlags };

It is not yet fixed in trunk, as we want to do a more invasive fix
involving a proper delete API.

Regards,

Michael
-- 
ORACLE Deutschland B.V. & Co. KG   Michael Thayer
Werkstrasse 24                     VirtualBox engineer
71384 Weinstadt, Germany           mailto:michael.thayer at sun.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20100730/744b02a6/attachment.html>