[vbox-dev] vhd format not stable?

[Frank Mehnert]

Huihong,

On Friday 19 June 2009, Huihong Luo wrote:
> I tested it again, but it still crashed.
>  
> I think I now found the cause, it's quite delicate, but you should be able
> to fix it right away. 
> a8bd6ffd ff ff ff ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??
>  
> The above is the bitmap when crashed. You can see the beginnig there are
> only 3 bytes are valid, the 4th byte will cause crash. 
> But when you call
> ASMBitTest(const volatile void *pvBitmap, int32_t iBit)
>  
> it will the 1st 4-byte int, thus caused the crash.

Good catch!

> The easiest fix is to allocate 8 byte length more for the bitmap, and zero
> fill them, that will definitely solve the issue. You can also change
> ASMBitTest method impl. 

I think a better fix would be to ensure that ASMBitTest isn't called
with non-word-aligned memory addresses.

Kind regards,

Frank
-- 
Dr.-Ing. Frank Mehnert    Sun Microsystems, Inc.    www.sun.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://www.virtualbox.org/pipermail/vbox-dev/attachments/20090622/47c6c0ed/attachment-0001.bin