[vbox-dev] Latest svn vbox runs only as root?

[hondza]

Hello,

On 2008-09-01, Frank Mehnert <Frank.Mehnert at Sun.COM> wrote:
> The hardening feature ensures that only trusted modules can be loaded by
> the VM.

Latest svn (11908) behaves in a way that even *without* hardening only root can
access /dev/vboxdrv.

out/linux.x86/release/bin/src/linux/SUPDrv-linux.c, near line 685.

I think it's just a typo and it should be "#ifdef" instead of "#ifndef".


#v+
--- SUPDrv-linux.c.orig 2008-09-02 21:12:11.000000000 +0200
+++ SUPDrv-linux.c      2008-09-02 21:01:40.000000000 +0200
@@ -682,7 +682,7 @@
     PSUPDRVSESSION      pSession;
     Log(("VBoxDrvLinuxCreate: pFilp=%p pid=%d/%d %s\n", pFilp, RTProcSelf(), current->pid, current->comm));
 
-#ifndef VBOX_WITH_HARDENING
+#ifdef VBOX_WITH_HARDENING
     /*
      * Only root is allowed to access the device, enforce it!
      */
#v-


With this applied, it works well again. But perhaps I misunderstood ... 

Regards,

-- 
hondza | GPG key: http://www.hondza.adslink.cz/key.asc
Fingerprint: 31E7 EF56 7280 5C89 75E9 FF9D 010E 175F 7823 CF38
GPG/PGP encrypted/signed emails are welcome.