[vbox-dev] Small bug in your configure.vbs

[David]

Hi,

I had just installed VS2005 Professional on my system, so I tried to compile virtualbox and it was saying "The compiler we found wasn't 7.1 or 8.0." Of course it was, so I decided to open configure.vbs to check where your system were failing. Please note that this VS is French, so it may be why it didn't work.

I saw that the script was searching in the output this string: "Version 14." But, in the french version, the string is "version 14.". The complete output is:
Compilateur d'optimisation Microsoft (R) 32 bits C/C++ version 14.00.50727.762 pour 80x86
Copyright (C) Microsoft Corporation. Tous droits réservés.

utilisation : cl [ option... ] nom de fichier... [ /link linkoption... ]

But, in the log file, the output mode is ugly (no accentuated chars), and it looks like this:
Compilateur d'optimisation Microsoft (R) 32ÿbits C/C++ versionÿ14.00.50727.762 pour 80x86
Copyright (C) Microsoft Corporation. Tous droits r,serv,s.

utilisationÿ: cl [ option... ] nom de fichier... [ /link linkoption... ]


So I tried to change the two parts here:
if InStr(1, g_strShellOutput, "Version 14.") > 0 then (line 948)

if   (InStr(1, g_strShellOutput, "Version 13.10") <= 0) _
    And (InStr(1, g_strShellOutput, "Version 14.") <= 0) then (line 939)

to this:
   if InStr(1, g_strShellOutput, "Version 14.") > 0 _
   or InStr(1, g_strShellOutput, "versionÿ14") > 0 then

   if   (InStr(1, g_strShellOutput, "Version 13.10") <= 0) _
    And (InStr(1, g_strShellOutput, "Version 14.") <= 0) _
    And (InStr(1, g_strShellOutput, "versionÿ14") <= 0) then

Then it worked and detected VS2005. Just to let you know in case you have people with the french compiler how to make it work.
Have a nice day !
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.virtualbox.org/pipermail/vbox-dev/attachments/20080307/d17fcee4/attachment-0001.html