[vbox-dev] Linus just broke something

Larry Finger Larry.Finger at lwfinger.net
Thu Jul 17 14:00:43 GMT 2008

walt wrote:
> There has been a recent change to one of the linux kernel header files,
> include/linux/smp.h:
> commit 15c8b6c1aaaf1c4edd67e2f02e4d8e1bd1a51c0d
> Author: Jens Axboe <jens.axboe at oracle.com>
> Date:   Fri May 9 09:39:44 2008 +0200
>      on_each_cpu(): kill unused 'retry' parameter
>      It's not even passed on to smp_call_function() anymore, since that
>      was removed. So kill it.
> That change breaks src/VBox/Runtime/r0drv/linux/mp-r0drv-linux.c.
> This fixes the compilation problem, but I don't know if it's the right
> way to do it.  Also, the changes need to be #ifdef'd for the kernel
> version >=(2, 6, 26), which I'll try to do after work today:

The mainline kernel is now in the merge process between 2.6.26 and 2.6.27-rc1. 
AFAIK, your fixes are correct, but only for kernel version > 2.6.26. A real 
2.6.26 does not need them. If you really want to use these kernels, bump the 
SUBLEVEL value in the Makefile to 27.


More information about the vbox-dev mailing list