Changeset 9599 in vbox

Timestamp:

Jun 11, 2008 11:26:09 AM (16 years ago)

Author:

vboxsync

Message:

Change the meaninf of VD_OPEN_FLAGS_INFO. The previous definition caused trouble by overoptimizing. Zero UUIDs for VMDK files created by VMware is not acceptable, as it breaks Main.

Location:

trunk

Files:

• include/VBox/VBoxHDD-new.h (modified) (1 diff)
• src/VBox/Devices/Storage/VBoxHDD-new.cpp (modified) (1 diff)

trunk/include/VBox/VBoxHDD-new.h

@@ -173 +173 @@
  * formats. It is silently ignored otherwise. */
 #define VD_OPEN_FLAGS_HONOR_SAME    RT_BIT(2)
-/** Do not perform the base/diff image check on open. This internally implies
- * opening the image as readonly. Images opened with this flag should only be
+/** Do not perform the base/diff image check on open. This does NOT imply
+ * opening the image as readonly (would break e.g. adding UUIDs to VMDK files
+ * created by other products). Images opened with this flag should only be
  * used for querying information, and nothing else. */
 #define VD_OPEN_FLAGS_INFO          RT_BIT(3)

trunk/src/VBox/Devices/Storage/VBoxHDD-new.cpp

@@ -1044 +1044 @@
                            ("uOpenFlags=%#x\n", uOpenFlags),
                            rc = VERR_INVALID_PARAMETER);
-
-        /* Force readonly for images without base/diff consistency checking. */
-        if (uOpenFlags & VD_OPEN_FLAGS_INFO)
-            uOpenFlags |= VD_OPEN_FLAGS_READONLY;
 
         /* Set up image descriptor. */