VirtualBox

Changeset 94246 in vbox for trunk


Ignore:
Timestamp:
Mar 15, 2022 2:43:00 PM (3 years ago)
Author:
vboxsync
Message:

Main/Console: Attach and detach storage stuff on EMT(0) to avoid upsetting PDM queue destruction code. bugref:10200 bugref:10093

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

    r94184 r94246  
    24152415    {
    24162416        /*
    2417          * Call worker in EMT, that's faster and safer than doing everything
     2417         * Call worker on EMT #0, that's faster and safer than doing everything
    24182418         * using VMR3ReqCall.
    24192419         */
     
    25172517
    25182518    /*
    2519      * Call worker in EMT, that's faster and safer than doing everything
     2519     * Call worker on EMT #0, that's faster and safer than doing everything
    25202520     * using VMR3ReqCall. Note that we separate VMR3ReqCall from VMR3ReqWait
    25212521     * here to make requests from under the lock in order to serialize them.
     
    35423542
    35433543    /*
    3544      * Call worker in EMT, that's faster and safer than doing everything
     3544     * Call worker on EMT #0, that's faster and safer than doing everything
    35453545     * using VMR3ReqCall. Note that we separate VMR3ReqCall from VMR3ReqWait
    35463546     * here to make requests from under the lock in order to serialize them.
    35473547     */
    35483548    PVMREQ pReq;
    3549     int vrc = pVMM->pfnVMR3ReqCallU(pUVM, VMCPUID_ANY, &pReq, 0 /* no wait! */, VMREQFLAGS_VBOX_STATUS,
     3549    int vrc = pVMM->pfnVMR3ReqCallU(pUVM, 0, &pReq, 0 /* no wait! */, VMREQFLAGS_VBOX_STATUS,
    35503550                                    (PFNRT)i_changeRemovableMedium, 9,
    35513551                                    this, pUVM, pVMM, pszDevice, uInstance, enmBus, fUseHostIOCache, aMediumAttachment, fForce);
     
    37183718
    37193719    /*
    3720      * Call worker in EMT, that's faster and safer than doing everything
     3720     * Call worker on EMT #0, that's faster and safer than doing everything
    37213721     * using VMR3ReqCall. Note that we separate VMR3ReqCall from VMR3ReqWait
    37223722     * here to make requests from under the lock in order to serialize them.
    37233723     */
    37243724    PVMREQ pReq;
    3725     int vrc = pVMM->pfnVMR3ReqCallU(pUVM, VMCPUID_ANY, &pReq, 0 /* no wait! */, VMREQFLAGS_VBOX_STATUS,
     3725    int vrc = pVMM->pfnVMR3ReqCallU(pUVM, 0, &pReq, 0 /* no wait! */, VMREQFLAGS_VBOX_STATUS,
    37263726                                    (PFNRT)i_attachStorageDevice, 9,
    37273727                                    this, pUVM, pVMM, pszDevice, uInstance, enmBus, fUseHostIOCache, aMediumAttachment, fSilent);
     
    38913891
    38923892    /*
    3893      * Call worker in EMT, that's faster and safer than doing everything
     3893     * Call worker on EMT #0, that's faster and safer than doing everything
    38943894     * using VMR3ReqCall. Note that we separate VMR3ReqCall from VMR3ReqWait
    38953895     * here to make requests from under the lock in order to serialize them.
    38963896     */
    38973897    PVMREQ pReq;
    3898     int vrc = pVMM->pfnVMR3ReqCallU(pUVM, VMCPUID_ANY, &pReq, 0 /* no wait! */, VMREQFLAGS_VBOX_STATUS,
     3898    int vrc = pVMM->pfnVMR3ReqCallU(pUVM, 0, &pReq, 0 /* no wait! */, VMREQFLAGS_VBOX_STATUS,
    38993899                                    (PFNRT)i_detachStorageDevice, 8,
    39003900                                    this, pUVM, pVMM, pszDevice, uInstance, enmBus, aMediumAttachment, fSilent);
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette