Changeset 93209 in vbox

Timestamp:

Jan 12, 2022 10:05:25 PM (3 years ago)

Author:

vboxsync

Message:

Main/Host: Don't double buffer the description string in Host::getProcessorDescription, just retrieve it straight into the return string.

File:

• trunk/src/VBox/Main/src-server/HostImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/HostImpl.cpp

@@ -1160 +1160 @@
     // no locking required
 
-    char szCPUModel[80];
-    szCPUModel[0] = 0;
-    int vrc = RTMpGetDescription(aCpuId, szCPUModel, sizeof(szCPUModel));
-    if (RT_FAILURE(vrc))
-        return E_FAIL; /** @todo error reporting? */
-
-    aDescription = Utf8Str(szCPUModel);
-
-    return S_OK;
+    int vrc = aDescription.reserveNoThrow(80);
+    if (RT_SUCCESS(vrc))
+    {
+        vrc = RTMpGetDescription(aCpuId, aDescription.mutableRaw(), aDescription.capacity());
+        if (RT_SUCCESS(vrc))
+        {
+            aDescription.jolt();
+            return S_OK;
+        }
+    }
+    return setErrorVrc(vrc);
 }