Changeset 9309 in vbox

Timestamp:

Jun 2, 2008 3:11:59 PM (16 years ago)

Author:

vboxsync

Message:

Added RTMpNotificationRegister/Deregister that provides notification events when a cpu goes offline or comes online. (not tested)

Location:

trunk

Files:

• include/iprt/cpuset.h (modified) (7 diffs)
• include/iprt/mp.h (modified) (1 diff)
• src/VBox/Runtime/Makefile.kmk (modified) (8 diffs)
• src/VBox/Runtime/r0drv/linux/the-linux-kernel.h (modified) (1 diff)
• src/VBox/Runtime/r0drv/mp-r0drv.h (modified) (2 diffs)

trunk/include/iprt/cpuset.h

@@ -33 +33 @@
 #include <iprt/types.h>
 #include <iprt/mp.h> /* RTMpCpuIdToSetIndex */
+#include <iprt/asm.h>
 
 
@@ -81 +82 @@
  * @param   pSet    Pointer to the set.
  * @param   idCpu   The identifier of the CPU to add.
+ * @remarks The modification is atomic.
  */
 DECLINLINE(int) RTCpuSetAdd(PRTCPUSET pSet, RTCPUID idCpu)
@@ -87 +89 @@
     if (RT_UNLIKELY(iCpu < 0))
         return -1;
-    *pSet |= RT_BIT_64(iCpu);
+    ASMAtomicBitSet(pSet, iCpu);
     return 0;
 }
@@ -98 +100 @@
  * @param   pSet    Pointer to the set.
  * @param   idCpu   The identifier of the CPU to delete.
+ * @remarks The modification is atomic.
  */
 DECLINLINE(int) RTCpuSetDel(PRTCPUSET pSet, RTCPUID idCpu)
@@ -104 +107 @@
     if (RT_UNLIKELY(iCpu < 0))
         return -1;
-    *pSet &= ~RT_BIT_64(iCpu);
+    ASMAtomicBitClear(pSet, iCpu);
     return 0;
 }
@@ -115 +118 @@
  * @param   pSet    Pointer to the set.
  * @param   idCpu   The identifier of the CPU to look for.
+ * @remarks The test is atomic.
  */
 DECLINLINE(bool) RTCpuSetIsMember(PCRTCPUSET pSet, RTCPUID idCpu)
@@ -121 +125 @@
     if (RT_UNLIKELY(iCpu < 0))
         return false;
-    return !!(*pSet & RT_BIT_64(iCpu));
+    return ASMBitTest((volatile void *)pSet, iCpu);
 }
 

trunk/include/iprt/mp.h

@@ -196 +196 @@
 RTDECL(int) RTMpOnSpecific(RTCPUID idCpu, PFNRTMPWORKER pfnWorker, void *pvUser1, void *pvUser2);
 
+
+/**
+ * MP event, see FNRTMPNOTIFICATION.
+ */
+typedef enum RTMPEVENT
+{
+    /** The CPU goes online. */
+    RTMPEVENT_ONLINE = 1,
+    /** The CPU goes offline. */
+    RTMPEVENT_OFFLINE
+} RTMPEVENT;
+
+/**
+ * Notification callback.
+ *
+ * The context this is called in differs a bit from platform to
+ * platform, so be careful while in here.
+ *
+ * @param   idCpu       The CPU this applies to.
+ * @param   enmEvent    The event.
+ * @param   pvUser      The user argument.
+ */
+typedef DECLCALLBACK(void) FNRTMPNOTIFICATION(RTMPEVENT enmEvent, RTCPUID idCpu, void *pvUser);
+/** Pointer to a FNRTMPNOTIFICATION(). */
+typedef FNRTMPNOTIFICATION *PFNRTMPNOTIFICATION;
+
+/**
+ * Registers a notification callback for cpu events.
+ *
+ * On platforms which doesn't do cpu offline/online events this API
+ * will just be a no-op that pretends to work.
+ *
+ * @returns IPRT status code.
+ * @retval  VINF_SUCCESS on success.
+ * @retval  VERR_NO_MEMORY if a registration record cannot be allocated.
+ * @retval  VERR_ALREADY_EXISTS if the pfnCallback and pvUser already exist
+ *          in the callback list.
+ *
+ * @param   pfnCallback     The callback.
+ * @param   pvUser          The user argument to the callback function.
+ */
+RTDECL(int) RTMpNotificationRegister(PFNRTMPNOTIFICATION pfnCallback, void *pvUser);
+
+/**
+ * This deregisters a notification callback registered via RTMpNotificationRegister().
+ *
+ * The pfnCallback and pvUser arguments must be identical to the registration call
+ * of we won't find the right entry.
+ *
+ * @returns IPRT status code.
+ * @retval  VINF_SUCCESS on success.
+ * @retval  VERR_NOT_FOUND if no matching entry was found.
+ *
+ * @param   pfnCallback     The callback.
+ * @param   pvUser          The user argument to the callback function.
+ */
+RTDECL(int) RTMpNotificationDeregister(PFNRTMPNOTIFICATION pfnCallback, void *pvUser);
+
+/**
+ * Initializes the multiprocessor event notifcations.
+ *
+ * This must be called before calling RTMpNotificationRegister(). This is an
+ * inconvenice caused Visual C++ not implmenting weak externals.
+ *
+ * @returns IPRT status code.
+ * @param   pvOS            Reserved, pass NULL.
+ */
+RTR0DECL(int) RTR0MpNotificationInit(void *pvOS);
+
+
+/**
+ * Terminates the multiprocessor event notifcations.
+ *
+ * The number of RTR0MpNotificationInit calls must match the calls to this
+ * function exactly.
+ *
+ * @returns IPRT status code.
+ * @param   pvOS            Reserved, pass NULL.
+ */
+RTR0DECL(void) RTR0MpNotificationTerm(void *pvOS);
+
 #endif /* IN_RING0 */
 

trunk/src/VBox/Runtime/Makefile.kmk

@@ -923 +923 @@
         r0drv/linux/memobj-r0drv-linux.c \
         r0drv/linux/mp-r0drv-linux.c \
+        r0drv/linux/mpnotification-r0drv-linux.c \
         r0drv/linux/process-r0drv-linux.c \
         r0drv/linux/RTLogWriteDebugger-r0drv-linux.c \
@@ -931 +932 @@
         r0drv/linux/thread-r0drv-linux.c \
         r0drv/linux/time-r0drv-linux.c \
-        r0drv/memobj-r0drv.cpp
+        r0drv/memobj-r0drv.cpp \
+        r0drv/mpnotification-r0drv.c
 ## @todo thread2-r0drv-linux.c, timer-r0drv-linux.c and assert-r0drv-linux.c
+#       r0drv/linux/timer-r0drv-linux.c \
 
 RuntimeR0Drv_SOURCES.win = \
@@ -940 +943 @@
         common/string/strpbrk.cpp \
         generic/RTAssertDoBreakpoint-generic.cpp \
-        r0drv/nt/mp-r0drv-nt.cpp \
         nt/RTErrConvertFromNtStatus.cpp \
         r0drv/memobj-r0drv.cpp \
+        r0drv/mpnotification-r0drv.c \
         r0drv/nt/alloc-r0drv-nt.cpp \
         r0drv/nt/initterm-r0drv-nt.cpp \
         r0drv/nt/memobj-r0drv-nt.cpp \
+        r0drv/nt/mp-r0drv-nt.cpp \
+        r0drv/nt/mpnotification-r0drv-nt.cpp \
         r0drv/nt/process-r0drv-nt.cpp \
         r0drv/nt/RTLogWriteDebugger-r0drv-nt.cpp \
@@ -983 +988 @@
         generic/timer-generic.cpp \
         r0drv/generic/RTMpOn-r0drv-generic.cpp \
+        r0drv/generic/mpnotification-r0drv-generic.cpp \
         r0drv/darwin/alloc-r0drv-darwin.cpp \
         r0drv/darwin/assert-r0drv-darwin.cpp \
@@ -1028 +1034 @@
         r0drv/memobj-r0drv.cpp \
         r0drv/generic/RTMpOn-r0drv-generic.cpp \
+        r0drv/generic/mpnotification-r0drv-generic.cpp \
         r0drv/os2/alloc-r0drv-os2.cpp \
         r0drv/os2/assert-r0drv-os2.cpp \
@@ -1071 +1078 @@
         generic/RTTimerCreate-generic.cpp \
         r0drv/generic/RTMpOn-r0drv-generic.cpp \
+        r0drv/generic/mpnotification-r0drv-generic.cpp \
         r0drv/freebsd/alloc-r0drv-freebsd.c \
         r0drv/freebsd/assert-r0drv-freebsd.c \
@@ -1092 +1100 @@
         generic/RTAssertDoBreakpoint-generic.cpp \
         generic/RTTimerCreate-generic.cpp \
-        r0drv/memobj-r0drv.cpp
+        r0drv/memobj-r0drv.cpp \
+        r0drv/mpnotification-r0drv.cpp \
+        r0drv/solaris/mpnotification-r0drv-solaris.cpp
 
 ifdef VBOX_WITH_SOLARIS_VBI
@@ -1193 +1203 @@
         generic/RTMpIsCpuOnline-generic.cpp \
         r0drv/generic/RTMpOn-r0drv-generic.cpp \
+        r0drv/generic/mpnotification-r0drv-generic.cpp \
         r0drv/solaris/alloc-r0drv-solaris.c \
         r0drv/solaris/assert-r0drv-solaris.c \

trunk/src/VBox/Runtime/r0drv/linux/the-linux-kernel.h

@@ -86 +86 @@
 #endif
 #include <linux/wait.h>
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 5, 71)
+# include <linux/cpu.h>
+#endif
 /* For the basic additions module */
 #include <linux/pci.h>

trunk/src/VBox/Runtime/r0drv/mp-r0drv.h

@@ -46 +46 @@
 
 /**
- * RTMpOn* argument packet used by the host specific callback 
+ * RTMpOn* argument packet used by the host specific callback
  * wrapper functions.
  */
@@ -60 +60 @@
 typedef RTMPARGS *PRTMPARGS;
 
+int rtR0MpNotificationNativeInit(void *pvOS);
+void rtR0MpNotificationNativeTerm(void *pvOS);
+void rtMpNotificationDoCallbacks(RTMPEVENT enmEvent, RTCPUID idCpu);
+
 #endif