Changeset 92477 in vbox

Timestamp:

Nov 17, 2021 12:55:46 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10148: UIMediumEnumerator: Do NOT show error notifications on medium enumeration issues.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• medium/UIMediumEnumerator.cpp (modified) (5 diffs)
• notificationcenter/UINotificationObjects.cpp (modified) (2 diffs)
• notificationcenter/UINotificationObjects.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumEnumerator.cpp

@@ -335 +335 @@
             /* Open existing medium, this API can be used to open known medium as well, using ID as location for that: */
             CMedium comMedium = comVBox.OpenMedium(uMediumId.toString(), enmMediumType, KAccessMode_ReadWrite, false);
-
-            /* Show error message if necessary: */
             if (!comVBox.isOk())
-                UINotificationMessage::cannotOpenKnownMedium(comVBox, uMediumId);
+                LogRel(("GUI: UIMediumEnumerator:  Unable to open registered medium!\n"));
             else
             {
@@ -527 +525 @@
         CMedium comMedium = comAttachment.GetMedium();
         if (!comAttachment.isOk())
-        {
-            LogRel2(("GUI: UIMediumEnumerator:  Unable to acquire attachment medium!\n"));
-            UINotificationMessage::cannotAcquireAttachmentParameter(comAttachment);
-        }
+            LogRel(("GUI: UIMediumEnumerator:  Unable to acquire attachment medium!\n"));
         else
         {
@@ -544 +539 @@
             CMachine comMachine = comAttachment.GetMachine();
             if (!comAttachment.isOk())
-            {
-                LogRel2(("GUI: UIMediumEnumerator:  Unable to acquire attachment parent machine!\n"));
-                UINotificationMessage::cannotAcquireAttachmentParameter(comAttachment);
-            }
+                LogRel(("GUI: UIMediumEnumerator:  Unable to acquire attachment parent machine!\n"));
             else
             {
@@ -553 +545 @@
                 const QUuid uMachineId = comMachine.GetId();
                 if (!comMachine.isOk())
-                {
-                    LogRel2(("GUI: UIMediumEnumerator:  Unable to acquire machine ID!\n"));
-                    UINotificationMessage::cannotAcquireMachineParameter(comMachine);
-                }
+                    LogRel(("GUI: UIMediumEnumerator:  Unable to acquire machine ID!\n"));
                 else
                 {
@@ -581 +570 @@
         const QUuid uMediumId = comMedium.GetId();
         if (!comMedium.isOk())
-        {
-            LogRel2(("GUI: UIMediumEnumerator:  Unable to acquire medium ID!\n"));
-            UINotificationMessage::cannotAcquireMediumParameter(comMedium);
-        }
+            LogRel(("GUI: UIMediumEnumerator:  Unable to acquire medium ID!\n"));
         else
         {

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.cpp

@@ -660 +660 @@
 
 /* static */
-void UINotificationMessage::cannotAcquireAttachmentParameter(const CMediumAttachment &comAttachment)
-{
-    createMessage(
-        QApplication::translate("UIMessageCenter", "Medium attachment failure ..."),
-        QApplication::translate("UIMessageCenter", "Failed to acquire attachment parameter.") +
-        UIErrorString::formatErrorInfo(comAttachment));
-}
-
-/* static */
 void UINotificationMessage::cannotAcquireDHCPServerParameter(const CDHCPServer &comServer)
 {
@@ -987 +978 @@
         UIErrorString::formatErrorInfo(comVBox),
         QString(), QString(), pParent);
-}
-
-/* static */
-void UINotificationMessage::cannotOpenKnownMedium(const CVirtualBox &comVBox, const QUuid &uMediumId)
-{
-    createMessage(
-        QApplication::translate("UIMessageCenter", "Can't open medium ..."),
-        QApplication::translate("UIMessageCenter", "Failed to open the medium with following ID: <nobr><b>%1</b></nobr>.")
-                                                   .arg(uMediumId.toString()) +
-        UIErrorString::formatErrorInfo(comVBox));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.h

@@ -282 +282 @@
           * @param  comSnapshot  Brings the object parameter get acquired from. */
         static void cannotAcquireSnapshotParameter(const CSnapshot &comSnapshot);
-        /** Notifies about inability to acquire IMediumAttachment parameter.
-          * @param  comAttachment  Brings the object parameter get acquired from. */
-        static void cannotAcquireAttachmentParameter(const CMediumAttachment &comAttachment);
         /** Notifies about inability to acquire IDHCPServer parameter.
           * @param  comServer  Brings the object parameter get acquired from. */
@@ -398 +395 @@
                                               const QString &strPath,
                                               UINotificationCenter *pParent = 0);
-        /** Notifies about inability to open known medium.
-          * @param  comVBox    Brings common VBox object trying to open medium.
-          * @param  uMediumId  Brings the medium ID. */
-        static void cannotOpenKnownMedium(const CVirtualBox &comVBox, const QUuid &uMediumId);
         /** Notifies about inability to get ext pack manager.
           * @param  comVBox      Brings common VBox object trying to open machine. */