Changeset 91917 in vbox

Timestamp:

Oct 21, 2021 12:34:53 AM (3 years ago)

Author:

vboxsync

Message:

NAT/Net: NATNetwork::setNetwork - be prepared for RTNetStrToIPv4Cidr
to return zero prefix. bugref:9330.

File:

• trunk/src/VBox/Main/src-server/NATNetworkImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-server/NATNetworkImpl.cpp

@@ -293 +293 @@
      * /32 is a single address, not a network, /31 is the degenerate
      * point-to-point case, so reject these.  Larger values and
-     * non-positive values are already treated as errors by the
+     * negative values are already treated as errors by the
      * conversion.
      */
@@ -299 +299 @@
         return setError(E_FAIL, tr("%s network is too small"), aIPv4NetworkCidr.c_str());
 
+    if (iPrefix == 0)
+        return setError(E_FAIL, tr("%s specifies zero prefix"), aIPv4NetworkCidr.c_str());
+
     rc = RTNetPrefixToMaskIPv4(iPrefix, &Mask);
     AssertRCReturn(rc, setError(E_FAIL,
@@ -308 +311 @@
             tr("%s: the specified address is longer than the specified prefix"),
             aIPv4NetworkCidr.c_str());
+
+    /** @todo r=uwe Check the address is unicast, not a loopback, etc. */
 
     /* normalized CIDR notation */