Changeset 91071 in vbox

Timestamp:

Sep 1, 2021 5:12:41 PM (3 years ago)

Author:

vboxsync

Message:

Audio/Validation Kit: Added some simple cumulative accounting for silent audio data blocks and audio data which does not belong to any registered audio tests. Silence now also will be treated as to-be-recorded audio data. ​bugref:10008

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioValidationKit.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioValidationKit.cpp

@@ -125 +125 @@
     /** Total number of bytes recorded since driver construction. */
     uint64_t            cbRecordedTotal;
+    /** Total number of bytes silence was played in a consequtive block so far.
+     *  Will be reset once audible data is being played (again). */
+    uint64_t            cbPlayedSilence;
+    /** Total number of bytes audio (audible or not) was played while no active
+     *  audio test was registered / available. */
+    uint64_t            cbPlayedNoTest;
     /** Temporary path to use. */
     char                szPathTemp[RTPATH_MAX];
@@ -842 +848 @@
     if (pTst == NULL) /* Empty list? */
     {
-#ifdef DEBUG_andy
-        if (!fIsSilence)
-#endif
-            LogRel(("ValKit: Warning: Guest is playing back audio (%s, %RU32 bytes, %RU64ms) when no playback test is active\n",
-                    fIsSilence ? "silence" : "audible", cbBuf, PDMAudioPropsBytesToMilli(&pStream->pStream->Cfg.Props, cbBuf)));
+        pThis->cbPlayedNoTest += cbBuf;
 
         *pcbWritten = cbBuf;
@@ -852 +854 @@
     }
 
-#ifndef DEBUG_andy
+    if (pThis->cbPlayedNoTest)
+    {
+        LogRel(("ValKit: Warning: Guest was playing back audio (%s, %RU32 bytes, %RU64ms) when no playback test is active\n",
+                pThis->cbPlayedNoTest, PDMAudioPropsBytesToMilli(&pStream->pStream->Cfg.Props, pThis->cbPlayedNoTest)));
+        pThis->cbPlayedNoTest = 0;
+    }
+
     if (fIsSilence)
-        LogRel2(("ValKit: Guest is playing back %RU32 bytes (%RU64ms) silence\n",
-                 cbBuf, PDMAudioPropsBytesToMilli(&pStream->pStream->Cfg.Props, cbBuf)));
-#endif
-
-    const bool fHandleSilence = false; /** @todo Skip blocks of entire silence for now. */
+    {
+        pThis->cbPlayedSilence += cbBuf;
+    }
+    else /* Audible data */
+    {
+        if (pThis->cbPlayedSilence)
+            LogRel(("ValKit: Guest was playing back %RU32 bytes (%RU64ms) of silence\n",
+                    pThis->cbPlayedSilence, PDMAudioPropsBytesToMilli(&pStream->pStream->Cfg.Props, pThis->cbPlayedSilence)));
+        pThis->cbPlayedSilence = 0;
+    }
+
+    const bool fHandleSilence = true;
 
     if (pTst->pEntry == NULL) /* Test not started yet? */
@@ -1120 +1135 @@
     pThis->cbPlayedTotal   = 0;
     pThis->cbRecordedTotal = 0;
+    pThis->cbPlayedSilence = 0;
+    pThis->cbPlayedNoTest  = 0;
 
     pThis->fTestSetEnd = false;