Changeset 91000 in vbox

Timestamp:

Aug 30, 2021 2:15:57 PM (3 years ago)

Author:

vboxsync

Message:

VMM,PDM,PGM: Restrict the VMSetError and VMSetRuntimeError APIs to ring-3, these never worked properly in ring-0 or raw-mode. A PAEmode runtime error was the only place any of these were used, but given that the VMSetRuntimeError codepath starts with an assertion, it can't have been used/tested. The PAEmode runtime error shouldn't necessarily be triggered by PGM anyway, but IEM. Removed VMMCALLRING3_VM_SET_ERROR and VMMCALLRING3_VM_SET_RUNTIME_ERROR. [doxygen fix] bugref:10093

Location:

trunk/include/VBox/vmm

Files:

• pdmdev.h (modified) (2 diffs)
• pdmdrv.h (modified) (2 diffs)

trunk/include/VBox/vmm/pdmdev.h

@@ -6750 +6750 @@
 
 /**
- * @copydoc PDMDEVHLPR3::pfnVMSetError
+ * Set the VM error message
+ *
+ * @returns rc.
+ * @param   pDevIns             The device instance.
+ * @param   rc                  VBox status code.
+ * @param   SRC_POS             Use RT_SRC_POS.
+ * @param   pszFormat           Error message format string.
+ * @param   ...                 Error message arguments.
+ * @sa      VMSetError
  */
 DECLINLINE(int) RT_IPRT_FORMAT_ATTR(6, 7) PDMDevHlpVMSetError(PPDMDEVINS pDevIns, const int rc, RT_SRC_POS_DECL,
@@ -6763 +6771 @@
 
 /**
- * @copydoc PDMDEVHLPR3::pfnVMSetRuntimeError
+ * Set the VM runtime error message
+ *
+ * @returns VBox status code.
+ * @param   pDevIns             The device instance.
+ * @param   fFlags              The action flags. See VMSETRTERR_FLAGS_*.
+ * @param   pszErrorId          Error ID string.
+ * @param   pszFormat           Error message format string.
+ * @param   ...                 Error message arguments.
+ * @sa      VMSetRuntimeError
  */
 DECLINLINE(int) RT_IPRT_FORMAT_ATTR(4, 5) PDMDevHlpVMSetRuntimeError(PPDMDEVINS pDevIns, uint32_t fFlags, const char *pszErrorId,

trunk/include/VBox/vmm/pdmdrv.h

@@ -1305 +1305 @@
 
 /**
- * @copydoc PDMDRVHLPR3::pfnVMSetError
+ * Set the VM error message
+ *
+ * @returns rc.
+ * @param   pDrvIns         Driver instance.
+ * @param   rc              VBox status code.
+ * @param   SRC_POS         Use RT_SRC_POS.
+ * @param   pszFormat       Error message format string.
+ * @param   ...             Error message arguments.
+ * @sa      PDMDRV_SET_ERROR, PDMDrvHlpVMSetErrorV, VMSetError
  */
 DECLINLINE(int)  RT_IPRT_FORMAT_ATTR(6, 7) PDMDrvHlpVMSetError(PPDMDRVINS pDrvIns, const int rc, RT_SRC_POS_DECL,
@@ -1334 +1342 @@
 
 /**
- * @copydoc PDMDRVHLPR3::pfnVMSetRuntimeError
+ * Set the VM runtime error message
+ *
+ * @returns VBox status code.
+ * @param   pDrvIns         Driver instance.
+ * @param   fFlags          The action flags. See VMSETRTERR_FLAGS_*.
+ * @param   pszErrorId      Error ID string.
+ * @param   pszFormat       Error message format string.
+ * @param   ...             Error message arguments.
+ * @sa      PDMDRV_SET_RUNTIME_ERROR, PDMDrvHlpVMSetRuntimeErrorV,
+ *          VMSetRuntimeError
  */
 DECLINLINE(int)  RT_IPRT_FORMAT_ATTR(4, 5) PDMDrvHlpVMSetRuntimeError(PPDMDRVINS pDrvIns, uint32_t fFlags, const char *pszErrorId,