Changeset 90958 in vbox

Timestamp:

Aug 27, 2021 1:55:41 PM (3 years ago)

Author:

vboxsync

Message:

VMM: Log flushing stats. bugref:10086

Location:

trunk/src/VBox/VMM

Files:

• VMMR0/VMMR0.cpp (modified) (4 diffs)
• VMMR3/VMM.cpp (modified) (2 diffs)
• include/VMMInternal.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -3164 +3164 @@
                                                                                             VMMLOGGER_BUFFER_COUNT);
 
+                                            STAM_REL_COUNTER_INC(&pShared->StatFlushes);
+                                            STAM_REL_COUNTER_INC(&pGVM->vmm.s.StatLogFlusherFlushes);
+
                                             if (pGVM->vmmr0.s.LogFlusher.fThreadWaiting)
                                             {
@@ -3170 +3173 @@
                                             }
                                             else
+                                            {
+                                                STAM_REL_COUNTER_INC(&pGVM->vmm.s.StatLogFlusherNoWakeUp);
                                                 RTSpinlockRelease(pGVM->vmmr0.s.LogFlusher.hSpinlock);
+                                            }
 
                                             /*
                                              * Wait for it to complete.
                                              */
+                                            STAM_REL_PROFILE_START(&pShared->StatWait, a);
                                             VMMR0EmtWaitEventInner(pGVCpu, VMMR0EMTWAIT_F_TRY_SUPPRESS_INTERRUPTED,
                                                                    pR0Log->hEventFlushWait, RT_INDEFINITE_WAIT);
+                                            STAM_REL_PROFILE_STOP(&pShared->StatWait, a);
                                         }
                                         else
@@ -3193 +3201 @@
                                 }
                                 else
+                                {
+                                    STAM_REL_COUNTER_INC(&pShared->StatCannotBlock);
                                     SUP_DPRINTF(("vmmR0LoggerFlush: VMMR0EmtPrepareToBlock failed! rc=%d\n", rc));
+                                }
                                 pR0Log->fFlushing = false;
                             }
@@ -3201 +3212 @@
                         else
                         {
+                            STAM_REL_COUNTER_INC(&pShared->StatCannotBlock);
 #if defined(RT_OS_LINUX)
                             SUP_DPRINTF(("vmmR0LoggerFlush: EMT blocking disabled! (%u bytes)\n", pBufDesc->offBuf));

trunk/src/VBox/VMM/VMMR3/VMM.cpp

@@ -438 +438 @@
     STAM_REG(pVM, &pVM->vmm.s.StatRZCallVMSetRuntimeError,  STAMTYPE_COUNTER, "/VMM/RZCallR3/VMRuntimeError",   STAMUNIT_OCCURENCES, "Number of VMMCALLRING3_VM_SET_RUNTIME_ERROR calls.");
 
+    STAMR3Register(pVM, &pVM->vmm.s.StatLogFlusherFlushes,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, "/VMM/LogFlush/00-Flushes",  STAMUNIT_OCCURENCES, "Total number of buffer flushes");
+    STAMR3Register(pVM, &pVM->vmm.s.StatLogFlusherNoWakeUp, STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, "/VMM/LogFlush/00-NoWakups", STAMUNIT_OCCURENCES, "Times the flusher thread didn't need waking up.");
+
 #ifdef VBOX_WITH_STATISTICS
     for (VMCPUID i = 0; i < pVM->cCpus; i++)
@@ -469 +472 @@
 
         STAMR3RegisterF(pVM, &pVCpu->cEmtHashCollisions,             STAMTYPE_U8,      STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,  "", "/VMM/EmtHashCollisions/Emt%02u", i);
+
+        PVMMR3CPULOGGER pShared = &pVCpu->vmm.s.u.s.Logger;
+        STAMR3RegisterF(pVM, &pShared->StatFlushes,     STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,     "", "/VMM/LogFlush/CPU%u/Reg", i);
+        STAMR3RegisterF(pVM, &pShared->StatCannotBlock, STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,     "", "/VMM/LogFlush/CPU%u/Reg/CannotBlock", i);
+        STAMR3RegisterF(pVM, &pShared->StatWait,        STAMTYPE_PROFILE, STAMVISIBILITY_USED, STAMUNIT_TICKS_PER_CALL, "", "/VMM/LogFlush/CPU%u/Reg/Wait", i);
+        STAMR3RegisterF(pVM, &pShared->cbDropped,       STAMTYPE_U32,     STAMVISIBILITY_USED, STAMUNIT_BYTES,          "", "/VMM/LogFlush/CPU%u/Reg/cbDropped", i);
+        STAMR3RegisterF(pVM, &pShared->cbBuf,           STAMTYPE_U32,     STAMVISIBILITY_USED, STAMUNIT_BYTES,          "", "/VMM/LogFlush/CPU%u/Reg/cbBuf", i);
+        STAMR3RegisterF(pVM, &pShared->idxBuf,          STAMTYPE_U32,     STAMVISIBILITY_USED, STAMUNIT_BYTES,          "", "/VMM/LogFlush/CPU%u/Reg/idxBuf", i);
+
+        pShared = &pVCpu->vmm.s.u.s.RelLogger;
+        STAMR3RegisterF(pVM, &pShared->StatFlushes,     STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,     "", "/VMM/LogFlush/CPU%u/Rel", i);
+        STAMR3RegisterF(pVM, &pShared->StatCannotBlock, STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,     "", "/VMM/LogFlush/CPU%u/Rel/CannotBlock", i);
+        STAMR3RegisterF(pVM, &pShared->StatWait,        STAMTYPE_PROFILE, STAMVISIBILITY_USED, STAMUNIT_TICKS_PER_CALL, "", "/VMM/LogFlush/CPU%u/Rel/Wait", i);
+        STAMR3RegisterF(pVM, &pShared->cbDropped,       STAMTYPE_U32,     STAMVISIBILITY_USED, STAMUNIT_BYTES,          "", "/VMM/LogFlush/CPU%u/Rel/cbDropped", i);
+        STAMR3RegisterF(pVM, &pShared->cbBuf,           STAMTYPE_U32,     STAMVISIBILITY_USED, STAMUNIT_BYTES,          "", "/VMM/LogFlush/CPU%u/Rel/cbBuf", i);
+        STAMR3RegisterF(pVM, &pShared->idxBuf,          STAMTYPE_U32,     STAMVISIBILITY_USED, STAMUNIT_BYTES,          "", "/VMM/LogFlush/CPU%u/Rel/idxBuf", i);
     }
 }

trunk/src/VBox/VMM/include/VMMInternal.h

@@ -121 +121 @@
     /** Number of bytes dropped because the flush context didn't allow waiting.  */
     uint32_t                cbDropped;
+    STAMCOUNTER             StatFlushes;
+    STAMCOUNTER             StatCannotBlock;
+    STAMPROFILE             StatWait;
 } VMMR3CPULOGGER;
 /** Pointer to r0 logger data shared with ring-3. */
@@ -347 +350 @@
     /** Copy of the current work log flusher work item. */
     VMMLOGFLUSHERENTRY volatile LogFlusherItem;
+    STAMCOUNTER                 StatLogFlusherFlushes;
+    STAMCOUNTER                 StatLogFlusherNoWakeUp;
     /** @} */
 
@@ -633 +638 @@
         bool volatile           fThreadRunning;
         bool                    afPadding2[5];
+        STAMCOUNTER             StatFlushes;
+        STAMCOUNTER             StatNoWakeUp;
         /** Logger ring buffer.
          * This is for communicating with the log flusher thread.  */