Changeset 90953 in vbox

Timestamp:

Aug 27, 2021 12:45:24 PM (3 years ago)

Author:

vboxsync

Message:

VMM: Don't need the per-logger flushing-disabled flag (VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED). bugref:10086

Location:

trunk/src/VBox/VMM

Files:

• VMMR0/VMMR0.cpp (modified) (1 diff)
• VMMRZ/VMMRZ.cpp (modified) (2 diffs)
• include/VMMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -3111 +3111 @@
                      * Can we wait on the log flusher to do the work?
                      */
-                    if (   VMMRZCallRing3IsEnabled(pGVCpu)
-                        && !(pLogger->u32UserValue1 & VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED))
+                    if (VMMRZCallRing3IsEnabled(pGVCpu))
                     {
                         /*

trunk/src/VBox/VMM/VMMRZ/VMMRZ.cpp

@@ -139 +139 @@
     if (ASMAtomicUoIncU32(&pVCpu->vmm.s.cCallRing3Disabled) == 1)
     {
-        /** @todo it might make more sense to just disable logging here, then we
-         * won't flush away important bits... but that goes both ways really. */
 #ifdef IN_RC
         pVCpu->pVMRC->vmm.s.fRCLoggerFlushingDisabled = true;
 #else
         pVCpu->vmmr0.s.fLogFlushingDisabled = true;
-        if (pVCpu->vmmr0.s.u.s.Logger.pLogger)
-            pVCpu->vmmr0.s.u.s.Logger.pLogger->u32UserValue1 |= VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED;
-        if (pVCpu->vmmr0.s.u.s.RelLogger.pLogger)
-            pVCpu->vmmr0.s.u.s.RelLogger.pLogger->u32UserValue1 |= VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED;
 #endif
     }
@@ -178 +172 @@
 #else
         pVCpu->vmmr0.s.fLogFlushingDisabled = false;
-        if (pVCpu->vmmr0.s.u.s.Logger.pLogger)
-            pVCpu->vmmr0.s.u.s.Logger.pLogger->u32UserValue1 &= ~VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED;
-        if (pVCpu->vmmr0.s.u.s.RelLogger.pLogger)
-            pVCpu->vmmr0.s.u.s.RelLogger.pLogger->u32UserValue1 &= ~VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED;
 #endif
     }

trunk/src/VBox/VMM/include/VMMInternal.h

@@ -574 +574 @@
 /** Part of the flags value used for the magic. */
 #define VMMR0_LOGGER_FLAGS_MAGIC_MASK           UINT32_C(0xffffff0f)
-/** Set if flushing is disabled (copy of fLogFlushingDisabled). */
-#define VMMR0_LOGGER_FLAGS_FLUSHING_DISABLED    UINT32_C(0x00000010)
 /** @} */