Changeset 87240 in vbox

Timestamp:

Jan 13, 2021 2:41:41 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9515. Get rid of the boring scroll bar

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm

Files:

• UIWizardNewVMPageBasic1.cpp (modified) (6 diffs)
• UIWizardNewVMPageBasic1.h (modified) (3 diffs)
• UIWizardNewVMPageExpert.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageBasic1.cpp

@@ -278 +278 @@
 }
 
-void UIWizardNewVMPage1::addLine(QBoxLayout *pLayout)
+QFrame *UIWizardNewVMPage1::horizontalLine()
 {
     QFrame *line = new QFrame;
     line->setFrameShape(QFrame::HLine);
     line->setFrameShadow(QFrame::Sunken);
-    pLayout->addWidget(line);
-}
-
-void UIWizardNewVMPage1::createNameOSTypeWidgets(QVBoxLayout *pLayout, bool fCreateLabels /* = true */)
-{
-    AssertReturnVoid(pLayout);
-
+    return line;
+}
+
+int UIWizardNewVMPage1::createNameOSTypeWidgets(QGridLayout *pLayout, bool fCreateLabels /* = true */)
+{
+    AssertReturn(pLayout, 0);
+    int iRow = 0;
     if (fCreateLabels)
     {
         m_pNameOSTypeLabel = new QIRichTextLabel;
         if (m_pNameOSTypeLabel)
-            pLayout->addWidget(m_pNameOSTypeLabel);
+            pLayout->addWidget(m_pNameOSTypeLabel, iRow++, 0, 1, 4);
     }
 
     m_pNameAndFolderEditor = new UINameAndSystemEditor(0, true, true, false);
     if (m_pNameAndFolderEditor)
-        pLayout->addWidget(m_pNameAndFolderEditor);
-
-    addLine(pLayout);
+        pLayout->addWidget(m_pNameAndFolderEditor, iRow++, 0, 1, 4);
+
+    pLayout->addWidget(horizontalLine(), iRow++, 0, 1, 4);
 
     if (fCreateLabels)
@@ -307 +307 @@
         m_pUnattendedLabel = new QIRichTextLabel;
         if (m_pUnattendedLabel)
-            pLayout->addWidget(m_pUnattendedLabel);
-    }
-
-    QGridLayout *pUnattendedInstall = new QGridLayout;
+            pLayout->addWidget(m_pUnattendedLabel, iRow++, 0, 1, 4);
+    }
+
     m_pEnableUnattendedInstallCheckBox = new QCheckBox;
-    pUnattendedInstall->addWidget(m_pEnableUnattendedInstallCheckBox, 0, 0, 1, 4, Qt::AlignLeft);
+    pLayout->addWidget(m_pEnableUnattendedInstallCheckBox, iRow++, 0, 1, 2, Qt::AlignLeft);
 
     m_pISOSelectorLabel = new QLabel;
@@ -320 +319 @@
         m_pISOSelectorLabel->setSizePolicy(QSizePolicy::Maximum, QSizePolicy::Fixed);
         m_pISOSelectorLabel->setEnabled(false);
-        pUnattendedInstall->addWidget(m_pISOSelectorLabel, 1, 0, 1, 1, Qt::AlignRight);
+        pLayout->addWidget(m_pISOSelectorLabel, iRow, 0, 1, 1, Qt::AlignRight);
     }
     m_pISOFilePathSelector = new UIFilePathSelector;
@@ -330 +329 @@
         m_pISOFilePathSelector->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed);
         m_pISOFilePathSelector->setEnabled(false);
-        pUnattendedInstall->addWidget(m_pISOFilePathSelector, 1, 1, 1, 4);
+        pLayout->addWidget(m_pISOFilePathSelector, iRow++, 1, 1, 3);
     }
 
@@ -337 +336 @@
     {
         m_pStartHeadlessCheckBox->setEnabled(false);
-        pUnattendedInstall->addWidget(m_pStartHeadlessCheckBox, 2, 1, 1, 1);
-    }
-    pLayout->addLayout(pUnattendedInstall);
-    addLine(pLayout);
+        pLayout->addWidget(m_pStartHeadlessCheckBox, iRow++, 1, 1, 1);
+    }
+
+    pLayout->addWidget(horizontalLine(), iRow++, 0, 1, 4);
+
     m_pSystemTypeEditor = new UINameAndSystemEditor(0, false, false, true);
     if (m_pSystemTypeEditor)
-        pLayout->addWidget(m_pSystemTypeEditor);
-
+        pLayout->addWidget(m_pSystemTypeEditor, iRow++, 0, 1, 4);
+    return iRow;
 }
 
@@ -517 +517 @@
 void UIWizardNewVMPageBasic1::prepare()
 {
-    QVBoxLayout *pPageLayout = new QVBoxLayout(this);
-    createNameOSTypeWidgets(pPageLayout, false);
-    pPageLayout->addStretch();
+    QGridLayout *pPageLayout = new QGridLayout(this);
+    int iRow = createNameOSTypeWidgets(pPageLayout, false);
+    pPageLayout->addItem(new QSpacerItem(20, 40, QSizePolicy::Expanding, QSizePolicy::Expanding),
+                         iRow, 0, 1, 4);
     createConnections();
     /* Register fields: */

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageBasic1.h

@@ -28 +28 @@
 class QBoxLayout;
 class QCheckBox;
+class QFrame;
 class QLabel;
 class QRadioButton;
-class QVBoxLayout;
+class QGridLayout;
 class QIRichTextLabel;
 class UIFilePathSelector;
@@ -76 +77 @@
     void composeMachineFilePath();
     /** Creates the page widgets and adds them into the @p pGridLayout. */
-    void createNameOSTypeWidgets(QVBoxLayout *pLayout, bool fCreateLabels = true);
+    int createNameOSTypeWidgets(QGridLayout *pLayout, bool fCreateLabels = true);
     void setTypeByISODetectedOSType(const QString &strDetectedOSType);
     /** Colors the widgets red if they cause isComplete to fail. */
@@ -103 +104 @@
 
     bool checkISOFile() const;
-    void addLine(QBoxLayout *pLayout);
+    QFrame *horizontalLine();
 
     /** Full path (including the file name) of the machine's configuration file. */

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageExpert.cpp

@@ -52 +52 @@
         m_pToolBox = new QToolBox;
         m_pNameAndSystemContainer = new QWidget(this);
-        QVBoxLayout *pNameContainerLayout = new QVBoxLayout(m_pNameAndSystemContainer);
+        QGridLayout *pNameContainerLayout = new QGridLayout(m_pNameAndSystemContainer);
         createNameOSTypeWidgets(pNameContainerLayout, false);
         m_pGAInstallContainer = createGAInstallWidgets();