Changeset 86846 in vbox

Timestamp:

Nov 10, 2020 11:13:28 AM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9722: VirtualBox Manager: Extend public key loading validation with file presence check and check whether file size is less than 10KB.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIMessageCenter.cpp (modified) (1 diff)
• globals/UIMessageCenter.h (modified) (1 diff)
• manager/UIVirtualBoxManager.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.cpp

@@ -1071 +1071 @@
     alert(pParent, MessageType_Error,
           tr("Public key file path is empty."));
+}
+
+void UIMessageCenter::publicKeyFileDoesntExist(const QString &strPath, QWidget *pParent /* = 0 */) const
+{
+    alert(pParent, MessageType_Error,
+          tr("Failed to open the public key file <nobr><b>%1</b></nobr>. File doesn't exist.")
+             .arg(strPath));
+}
+
+void UIMessageCenter::publicKeyFileIsOfTooLargeSize(const QString &strPath, QWidget *pParent /* = 0 */) const
+{
+    alert(pParent, MessageType_Error,
+          tr("Failed to open the public key file <nobr><b>%1</b></nobr>. File is too large for the key.")
+             .arg(strPath));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.h

@@ -310 +310 @@
     void cannotDeleteConsoleConnection(const CProgress &comProgress, const QString &strMachineName, QWidget *pParent = 0);
     void publicKeyFilePathIsEmpty(QWidget *pParent = 0) const;
+    void publicKeyFileDoesntExist(const QString &strPath, QWidget *pParent = 0) const;
+    void publicKeyFileIsOfTooLargeSize(const QString &strPath, QWidget *pParent = 0) const;
     void publicKeyFileIsntReadable(const QString &strPath, QWidget *pParent = 0) const;
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.cpp

@@ -246 +246 @@
     }
 
+    /* Make sure file exists and is of suitable size: */
+    QFileInfo fi(strPath);
+    if (!fi.exists())
+    {
+        if (!fIgnoreErrors)
+            msgCenter().publicKeyFileDoesntExist(strPath);
+        return false;
+    }
+    if (fi.size() > 10 * _1K)
+    {
+        if (!fIgnoreErrors)
+            msgCenter().publicKeyFileIsOfTooLargeSize(strPath);
+        return false;
+    }
+
     /* Make sure file can be opened: */
     QFile file(strPath);