Changeset 85241 in vbox

Timestamp:

Jul 11, 2020 11:03:20 PM (4 years ago)

Author:

vboxsync

Message:

Main/netif.h: Signedness issue in getDefaultIPv4Address(). bugref:9790

File:

• trunk/src/VBox/Main/include/netif.h (modified) (1 diff)

trunk/src/VBox/Main/include/netif.h

@@ -115 +115 @@
     Utf8Str strTmp = bstrIfName;
     const char *pcszIfName = strTmp.c_str();
-    int iInstance = 0;
     size_t iPos = strcspn(pcszIfName, "0123456789");
+    uint32_t uInstance = 0;
     if (pcszIfName[iPos])
-        iInstance = RTStrToUInt32(pcszIfName + iPos);
+        uInstance = RTStrToUInt32(pcszIfName + iPos);
 
     in_addr tmp;
 #if defined(RT_OS_WINDOWS)
-    tmp.S_un.S_addr = VBOXNET_IPV4ADDR_DEFAULT + (iInstance << 16);
+    tmp.S_un.S_addr = VBOXNET_IPV4ADDR_DEFAULT + (uInstance << 16);
 #else
-    tmp.s_addr = VBOXNET_IPV4ADDR_DEFAULT + (iInstance << 16);
+    tmp.s_addr = VBOXNET_IPV4ADDR_DEFAULT + (uInstance << 16);
 #endif
     char *addr = inet_ntoa(tmp);