Changeset 85239 in vbox

Timestamp:

Jul 11, 2020 11:00:38 PM (4 years ago)

Author:

vboxsync

Message:

Main/EventImpl.cpp: Made VBoxEvent::waitProcessed and ListenerRecord::dequeue interpret all negative timeout values as meaning RT_INDEFINITE_WAIT like we do elsewhere in the API. Stumbled upon this due to a sign conversion issue highlighted by Clang 11. bugref:9790

File:

• trunk/src/VBox/Main/src-all/EventImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-all/EventImpl.cpp

@@ -214 +214 @@
     alock.release();
     /** @todo maybe while loop for spurious wakeups? */
-    int vrc = ::RTSemEventWait(m->mWaitEvent, aTimeout);
+    int vrc = ::RTSemEventWait(m->mWaitEvent, aTimeout < 0 ? RT_INDEFINITE_WAIT : (RTMSINTERVAL)aTimeout);
     AssertMsg(RT_SUCCESS(vrc) || vrc == VERR_TIMEOUT || vrc == VERR_INTERRUPTED,
               ("RTSemEventWait returned %Rrc\n", vrc));
@@ -921 +921 @@
             aAlock.release();
 
-            ::RTSemEventWait(hEvt, aTimeout);
+            ::RTSemEventWait(hEvt, aTimeout < 0 ? RT_INDEFINITE_WAIT : (RTMSINTERVAL)aTimeout);
             ASMAtomicDecS32(&mQEventBusyCnt);