Changeset 83256 in vbox

Timestamp:

Mar 11, 2020 10:57:46 AM (5 years ago)

Author:

vboxsync

Message:

VMSVGA: Reversed bit order of converted cursor AND mask to match VBVA expectations.

File:

• trunk/src/VBox/Devices/Graphics/DevVGA-SVGA.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA.cpp

@@ -2752 +2752 @@
                 {
                     uint8_t bDst = 0;
-                    uint8_t fBit = 1;
+                    uint8_t fBit = 0x80;
                     do
                     {
@@ -2760 +2760 @@
                               | (pThis->last_palette[idxPal] >> 16)) & 0xff) > 0xfc)
                             bDst |= fBit;
-                        fBit <<= 1;
+                        fBit >>= 1;
                         x++;
                     } while (x < cx && (x & 7));
@@ -2775 +2775 @@
                 {
                     uint8_t bDst = 0;
-                    uint8_t fBit = 1;
+                    uint8_t fBit = 0x80;
                     do
                     {
                         if ((pbSrc[x * 2] | (pbSrc[x * 2 + 1] & 0x7f)) >= 0xfc)
                             bDst |= fBit;
-                        fBit <<= 1;
+                        fBit >>= 1;
                         x++;
                     } while (x < cx && (x & 7));
@@ -2795 +2795 @@
                 {
                     uint8_t bDst = 0;
-                    uint8_t fBit = 1;
+                    uint8_t fBit = 0x80;
                     do
                     {
                         if ((pbSrc[x * 2] | pbSrc[x * 2 + 1]) >= 0xfc)
                             bDst |= fBit;
-                        fBit <<= 1;
+                        fBit >>= 1;
                         x++;
                     } while (x < cx && (x & 7));
@@ -2815 +2815 @@
                 {
                     uint8_t bDst = 0;
-                    uint8_t fBit = 1;
+                    uint8_t fBit = 0x80;
                     do
                     {
                         if ((pbSrc[x * 3] | pbSrc[x * 3 + 1] | pbSrc[x * 3 + 2]) >= 0xfc)
                             bDst |= fBit;
-                        fBit <<= 1;
+                        fBit >>= 1;
                         x++;
                     } while (x < cx && (x & 7));
@@ -2835 +2835 @@
                 {
                     uint8_t bDst = 0;
-                    uint8_t fBit = 1;
+                    uint8_t fBit = 0x80;
                     do
                     {
                         if ((pbSrc[x * 4] | pbSrc[x * 4 + 1] | pbSrc[x * 4 + 2] | pbSrc[x * 4 + 3]) >= 0xfc)
                             bDst |= fBit;
-                        fBit <<= 1;
+                        fBit >>= 1;
                         x++;
                     } while (x < cx && (x & 7));