Changeset 83197 in vbox

Timestamp:

Mar 4, 2020 9:18:18 AM (5 years ago)

Author:

vboxsync

Message:

VMM/CPUM: Fix the Timer description string outliving the stack, allocate it on the hyper-heap.

File:

• trunk/src/VBox/VMM/VMMR3/CPUM.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/CPUM.cpp

@@ -4560 +4560 @@
                 {
                     PVMCPU pVCpu = pVM->apCpusR3[idCpu];
-                    char aszTimerName[128];
-                    RTStrPrintf(&aszTimerName[0], sizeof(aszTimerName), "Nested Guest VMX-preempt. timer %u", idCpu);
+                    /* The string cannot live on the stack. It should be safe to call MMR3HeapAPrintf here as
+                       MMR3HyperInitFinalize has already completed at this point. */
+                    char *pszTimerName = MMR3HeapAPrintf(pVM, MM_TAG_CPUM_CTX, "Nested Guest VMX-preempt. timer %u", idCpu);
                     int rc = TMR3TimerCreateInternal(pVM, TMCLOCK_VIRTUAL_SYNC, cpumR3VmxPreemptTimerCallback, pVCpu,
-                                                     aszTimerName, &pVCpu->cpum.s.pNestedVmxPreemptTimerR3);
+                                                     pszTimerName, &pVCpu->cpum.s.pNestedVmxPreemptTimerR3);
                     AssertLogRelRCReturn(rc, rc);
                     pVCpu->cpum.s.pNestedVmxPreemptTimerR0 = TMTimerR0Ptr(pVCpu->cpum.s.pNestedVmxPreemptTimerR3);