Changeset 83040 in vbox

Timestamp:

Feb 10, 2020 5:08:22 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Chooser pane: No dragging for cloud groups and items.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser

Files:

• UIChooserItem.cpp (modified) (1 diff)
• UIChooserNode.h (modified) (1 diff)
• UIChooserNodeGlobal.cpp (modified) (1 diff)
• UIChooserNodeGlobal.h (modified) (1 diff)
• UIChooserNodeGroup.cpp (modified) (1 diff)
• UIChooserNodeGroup.h (modified) (1 diff)
• UIChooserNodeMachine.cpp (modified) (1 diff)
• UIChooserNodeMachine.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItem.cpp

@@ -495 +495 @@
         return;
 
-    /* Initialize dragging: */
-    QDrag *pDrag = new QDrag(pEvent->widget());
-    model()->setCurrentDragObject(pDrag);
-    pDrag->setPixmap(toPixmap());
-    pDrag->setMimeData(createMimeData());
-    pDrag->exec(Qt::MoveAction | Qt::CopyAction, Qt::MoveAction);
+    /* Initialize dragging for local VMs only: */
+    if (!m_pNode->hasAtLeastOneCloudNode())
+    {
+        QDrag *pDrag = new QDrag(pEvent->widget());
+        model()->setCurrentDragObject(pDrag);
+        pDrag->setPixmap(toPixmap());
+        pDrag->setMimeData(createMimeData());
+        pDrag->exec(Qt::MoveAction | Qt::CopyAction, Qt::MoveAction);
+    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNode.h

@@ -97 +97 @@
     virtual void updateAllNodes(const QUuid &uId) = 0;
 
+    /** Returns whether this node is a cloud node itself
+      * or contains at least one cloud VM node child. */
+    virtual bool hasAtLeastOneCloudNode() const = 0;
+
     /** Returns node position. */
     int position();

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNodeGlobal.cpp

@@ -109 +109 @@
 }
 
+bool UIChooserNodeGlobal::hasAtLeastOneCloudNode() const
+{
+    return false;
+}
+
 int UIChooserNodeGlobal::positionOf(UIChooserNode *pNode)
 {

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNodeGlobal.h

@@ -77 +77 @@
     virtual void updateAllNodes(const QUuid &uId) /* override */;
 
+    /** Returns whether this node is a cloud node itself
+      * or contains at least one cloud VM node child. */
+    virtual bool hasAtLeastOneCloudNode() const /* override */;
+
     /** Returns position of specified node inside this one. */
     virtual int positionOf(UIChooserNode *pNode) /* override */;

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNodeGroup.cpp

@@ -163 +163 @@
     foreach (UIChooserNode *pNode, nodes())
         pNode->updateAllNodes(uId);
+}
+
+bool UIChooserNodeGroup::hasAtLeastOneCloudNode() const
+{
+    foreach (UIChooserNode *pNode, m_nodesGroup)
+        if (pNode->hasAtLeastOneCloudNode())
+            return true;
+
+    foreach (UIChooserNode *pNode, m_nodesMachine)
+        if (pNode->hasAtLeastOneCloudNode())
+            return true;
+
+    return false;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNodeGroup.h

@@ -79 +79 @@
     virtual void updateAllNodes(const QUuid &uId) /* override */;
 
+    /** Returns whether this node is a cloud node itself
+      * or contains at least one cloud VM node child. */
+    virtual bool hasAtLeastOneCloudNode() const /* override */;
+
     /** Returns position of specified node inside this one. */
     virtual int positionOf(UIChooserNode *pNode) /* override */;

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNodeMachine.cpp

@@ -161 +161 @@
 }
 
+bool UIChooserNodeMachine::hasAtLeastOneCloudNode() const
+{
+    return cache()->itemType() != UIVirtualMachineItem::ItemType_Local;
+}
+
 int UIChooserNodeMachine::positionOf(UIChooserNode *pNode)
 {

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserNodeMachine.h

@@ -95 +95 @@
     virtual void updateAllNodes(const QUuid &uId) /* override */;
 
+    /** Returns whether this node is a cloud node itself
+      * or contains at least one cloud VM node child. */
+    virtual bool hasAtLeastOneCloudNode() const /* override */;
+
     /** Returns position of specified node inside this one. */
     virtual int positionOf(UIChooserNode *pNode) /* override */;