Changeset 83027 in vbox

Timestamp:

Feb 8, 2020 9:21:29 PM (5 years ago)

Author:

vboxsync

Message:

BIOS: Always report non-IDE disks as ready, reading the ATA status register is harmful for SCSI etc. drives.

File:

• trunk/src/VBox/Devices/PC/BIOS/disk.c (modified) (3 diffs)

trunk/src/VBox/Devices/PC/BIOS/disk.c

@@ -68 +68 @@
 
 /* Generic disk read/write routine signature. */
-typedef __fastcall (* dsk_rw_func)(bio_dsk_t __far *bios_dsk);
+typedef int __fastcall (* dsk_rw_func)(bio_dsk_t __far *bios_dsk);
 
 /* Controller specific disk access routines. Declared as a union to reduce
@@ -426 +426 @@
         // should look at 40:8E also???
 
+#ifdef VBOX_WITH_SCSI
+        /* SCSI drives are always "ready". */
+        if (!VBOX_IS_SCSI_DEVICE(device)) {
+#endif
         // Read the status from controller
         status = inb(bios_dsk->channels[device/2].iobase1 + ATA_CB_STAT);
@@ -434 +438 @@
             goto int13_fail_noah;
         }
+#ifdef VBOX_WITH_SCSI
+        } else  /* It's not an ATA drive. */
+            goto int13_success;
+#endif
         break;