Changeset 81230 in vbox

Timestamp:

Oct 11, 2019 2:50:50 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: UIExtraDataManager: A bit of cleanup for setDialogGeometry/dialogGeometry stuff.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/extradata

Files:

• UIExtraDataManager.cpp (modified) (2 diffs)
• UIExtraDataManager.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.cpp

@@ -4972 +4972 @@
 }
 
-/* static */
-QString UIExtraDataManager::extraDataKeyPerScreen(const QString &strBase, ulong uScreenIndex, bool fSameRuleForPrimary /* = false */)
-{
-    return fSameRuleForPrimary || uScreenIndex ? strBase + QString::number(uScreenIndex) : strBase;
+void UIExtraDataManager::setDialogGeometry(const QString &strKey, const QRect &geometry, bool fMaximized)
+{
+    /* Serialize passed values: */
+    QStringList data;
+    data << QString::number(geometry.x());
+    data << QString::number(geometry.y());
+    data << QString::number(geometry.width());
+    data << QString::number(geometry.height());
+    if (fMaximized)
+        data << GUI_Geometry_State_Max;
+
+    /* Save corresponding extra-data: */
+    setExtraDataStringList(strKey, data);
 }
 
 QRect UIExtraDataManager::dialogGeometry(const QString &strKey, QWidget *pWidget, const QRect &defaultGeometry)
 {
-    /* Get corresponding extra-data: */
+    /* Load corresponding extra-data: */
     const QStringList data = extraDataStringList(strKey);
 
@@ -5021 +5030 @@
 }
 
-void UIExtraDataManager::setDialogGeometry(const QString &strKey, const QRect &geometry, bool fMaximized)
-{
-        /* Serialize passed values: */
-    QStringList data;
-    data << QString::number(geometry.x());
-    data << QString::number(geometry.y());
-    data << QString::number(geometry.width());
-    data << QString::number(geometry.height());
-    if (fMaximized)
-        data << GUI_Geometry_State_Max;
-
-    /* Re-cache corresponding extra-data: */
-    setExtraDataStringList(strKey, data);
+/* static */
+QString UIExtraDataManager::extraDataKeyPerScreen(const QString &strBase, ulong uScreenIndex, bool fSameRuleForPrimary /* = false */)
+{
+    return fSameRuleForPrimary || uScreenIndex ? strBase + QString::number(uScreenIndex) : strBase;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.h

@@ -807 +807 @@
     QString toFeatureRestricted(bool fRestricted);
 
+    /** Defines saved dialog geometry according to specified attributes.
+      * @param  strKey      Brings geometry extra-data key of particular dialog.
+      * @param  geometry    Brings the dialog geometry to save.
+      * @param  fMaximized  Brings whether saved dialog geometry should be marked as maximized. */
+    void setDialogGeometry(const QString &strKey, const QRect &geometry, bool fMaximized);
+    /** Returns saved dialog geometry according to specified attributes.
+      * @param  strKey           Brings geometry extra-data key of particular dialog.
+      * @param  pWidget          Brings the widget to limit geometry bounds according to.
+      * @param  defaultGeometry  Brings the default geometry which should be used to
+      *                          calculate resulting geometry if saved was not found. */
     QRect dialogGeometry(const QString &strKey, QWidget *pWidget, const QRect &defaultGeometry);
-    void setDialogGeometry(const QString &strKey, const QRect &geometry, bool fMaximized);
 
     /** Returns string consisting of @a strBase appended with @a uScreenIndex for the *non-primary* screen-index.