Changeset 78093 in vbox

Timestamp:

Apr 10, 2019 3:11:29 PM (5 years ago)

Author:

vboxsync

Message:

DnD/Main: Renamed GuestDnDInst() macro -> GUESTDNDINST().

Location:

trunk/src/VBox/Main

Files:

• include/GuestDnDPrivate.h (modified) (1 diff)
• src-client/ConsoleImpl2.cpp (modified) (1 diff)
• src-client/GuestDnDPrivate.cpp (modified) (2 diffs)
• src-client/GuestDnDSourceImpl.cpp (modified) (5 diffs)
• src-client/GuestDnDTargetImpl.cpp (modified) (10 diffs)

trunk/src/VBox/Main/include/GuestDnDPrivate.h

@@ -1122 +1122 @@
 };
 
-/** Access to the GuestDnD's singleton instance.
- * @todo r=bird: Please add a 'Get' or something to this as it currently looks
- *       like a class instantiation rather than a getter.  Alternatively, use
- *       UPPER_CASE like the coding guideline suggest for macros. */
-#define GuestDnDInst() GuestDnD::getInstance()
+/** Access to the GuestDnD's singleton instance. */
+#define GUESTDNDINST() GuestDnD::getInstance()
 
 /** List of pointers to guest DnD Messages. */

trunk/src/VBox/Main/src-client/ConsoleImpl2.cpp

@@ -3125 +3125 @@
                 rc = HGCMHostRegisterServiceExtension(&hDummy, "VBoxDragAndDropSvc",
                                                       &GuestDnD::notifyDnDDispatcher,
-                                                      GuestDnDInst());
+                                                      GUESTDNDINST());
                 if (RT_FAILURE(rc))
                     Log(("Cannot register VBoxDragAndDropSvc extension, rc=%Rrc\n", rc));

trunk/src/VBox/Main/src-client/GuestDnDPrivate.cpp

@@ -764 +764 @@
 {
     /* Initialize public attributes. */
-    m_lstFmtSupported = GuestDnDInst()->defaultFormats();
+    m_lstFmtSupported = GUESTDNDINST()->defaultFormats();
 
     /* Initialzie private stuff. */
@@ -929 +929 @@
     LogRel2(("DnD: Cancelling operation on guest ..."));
 
-    return GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+    return GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
 }
 

trunk/src/VBox/Main/src-client/GuestDnDSourceImpl.cpp

@@ -266 +266 @@
     Msg.setNextUInt32(uScreenId);
 
-    int rc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+    int rc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
     if (RT_SUCCESS(rc))
     {
-        GuestDnDResponse *pResp = GuestDnDInst()->response();
+        GuestDnDResponse *pResp = GUESTDNDINST()->response();
         AssertPtr(pResp);
 
@@ -348 +348 @@
 
     /* Dito. */
-    GuestDnDResponse *pResp = GuestDnDInst()->response();
+    GuestDnDResponse *pResp = GUESTDNDINST()->response();
     AssertPtr(pResp);
 
@@ -961 +961 @@
     AssertPtrReturn(pCtx, VERR_INVALID_POINTER);
 
-    GuestDnD *pInst = GuestDnDInst();
+    GuestDnD *pInst = GUESTDNDINST();
     if (!pInst)
         return VERR_INVALID_POINTER;
@@ -1096 +1096 @@
     AssertPtr(pCtx->mpResp);
 
-    GuestDnD *pInst = GuestDnDInst();
+    GuestDnD *pInst = GUESTDNDINST();
     if (!pInst)
         return VERR_INVALID_POINTER;
@@ -1201 +1201 @@
     AssertPtr(pCtx->mpResp);
 
-    GuestDnD *pInst = GuestDnDInst();
+    GuestDnD *pInst = GUESTDNDINST();
     if (!pInst)
         return VERR_INVALID_POINTER;

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -307 +307 @@
 
     /* Adjust the coordinates in a multi-monitor setup. */
-    int rc = GuestDnDInst()->adjustScreenCoordinates(aScreenId, &aX, &aY);
+    int rc = GUESTDNDINST()->adjustScreenCoordinates(aScreenId, &aX, &aY);
     if (RT_SUCCESS(rc))
     {
@@ -322 +322 @@
         Msg.setNextUInt32(cbFormats);
 
-        rc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+        rc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
         if (RT_SUCCESS(rc))
         {
-            GuestDnDResponse *pResp = GuestDnDInst()->response();
+            GuestDnDResponse *pResp = GUESTDNDINST()->response();
             if (pResp && RT_SUCCESS(pResp->waitForGuestResponse()))
                 resAction = GuestDnD::toMainAction(pResp->getActionDefault());
@@ -385 +385 @@
     HRESULT hr = S_OK;
 
-    int rc = GuestDnDInst()->adjustScreenCoordinates(aScreenId, &aX, &aY);
+    int rc = GUESTDNDINST()->adjustScreenCoordinates(aScreenId, &aX, &aY);
     if (RT_SUCCESS(rc))
     {
@@ -400 +400 @@
         Msg.setNextUInt32(cbFormats);
 
-        rc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+        rc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
         if (RT_SUCCESS(rc))
         {
-            GuestDnDResponse *pResp = GuestDnDInst()->response();
+            GuestDnDResponse *pResp = GUESTDNDINST()->response();
             if (pResp && RT_SUCCESS(pResp->waitForGuestResponse()))
                 resAction = GuestDnD::toMainAction(pResp->getActionDefault());
@@ -440 +440 @@
         Msg.setNextUInt32(0); /** @todo ContextID not used yet. */
 
-    int rc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+    int rc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
     if (RT_SUCCESS(rc))
     {
-        GuestDnDResponse *pResp = GuestDnDInst()->response();
+        GuestDnDResponse *pResp = GUESTDNDINST()->response();
         if (pResp)
             pResp->waitForGuestResponse();
@@ -507 +507 @@
 
     /* Adjust the coordinates in a multi-monitor setup. */
-    HRESULT hr = GuestDnDInst()->adjustScreenCoordinates(aScreenId, &aX, &aY);
+    HRESULT hr = GUESTDNDINST()->adjustScreenCoordinates(aScreenId, &aX, &aY);
     if (SUCCEEDED(hr))
     {
@@ -522 +522 @@
         Msg.setNextUInt32(cbFormats);
 
-        int vrc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+        int vrc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
         if (RT_SUCCESS(vrc))
         {
-            GuestDnDResponse *pResp = GuestDnDInst()->response();
+            GuestDnDResponse *pResp = GUESTDNDINST()->response();
             AssertPtr(pResp);
 
@@ -625 +625 @@
 
     /* Ditto. */
-    GuestDnDResponse *pResp = GuestDnDInst()->response();
+    GuestDnDResponse *pResp = GUESTDNDINST()->response();
     AssertPtr(pResp);
 
@@ -838 +838 @@
     }
 
-    int rc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+    int rc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
     if (RT_SUCCESS(rc))
         rc = updateProgress(pData, pCtx->mpResp, pData->getMeta().getSize());
@@ -869 +869 @@
     Msg.setNextUInt32(0);                                                /** @todo cbChecksum; not used yet. */
 
-    int rc = GuestDnDInst()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
+    int rc = GUESTDNDINST()->hostCall(Msg.getType(), Msg.getCount(), Msg.getParms());
 
     LogFlowFuncLeaveRC(rc);