VirtualBox

Changeset 75986 in vbox for trunk


Ignore:
Timestamp:
Dec 5, 2018 5:40:31 PM (6 years ago)
Author:
vboxsync
Message:

GuestProperties: Another parameter that should be passed by reference rather than copy.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/HostServices/GuestProperties/service.cpp

    r75985 r75986  
    430430    int getNotification(uint32_t u32ClientId, VBOXHGCMCALLHANDLE callHandle, uint32_t cParms, VBOXHGCMSVCPARM paParms[]);
    431431    int getOldNotificationInternal(const char *pszPattern, uint64_t nsTimestamp, Property *pProp);
    432     int getNotificationWriteOut(uint32_t cParms, VBOXHGCMSVCPARM paParms[], Property prop);
     432    int getNotificationWriteOut(uint32_t cParms, VBOXHGCMSVCPARM paParms[], Property const &prop);
    433433    int doNotifications(const char *pszProperty, uint64_t nsTimestamp);
    434434    int notifyHost(const char *pszName, const char *pszValue, uint64_t nsTimestamp, const char *pszFlags);
     
    10791079
    10801080/** Helper query used by getNotification */
    1081 int Service::getNotificationWriteOut(uint32_t cParms, VBOXHGCMSVCPARM paParms[], Property prop)
     1081int Service::getNotificationWriteOut(uint32_t cParms, VBOXHGCMSVCPARM paParms[], Property const &rProp)
    10821082{
    10831083    AssertReturn(cParms == 4, VERR_INVALID_PARAMETER); /* Basic sanity checking. */
     
    10901090    {
    10911091        char szFlags[GUEST_PROP_MAX_FLAGS_LEN];
    1092         rc = GuestPropWriteFlags(prop.mFlags, szFlags);
     1092        rc = GuestPropWriteFlags(rProp.mFlags, szFlags);
    10931093        if (RT_SUCCESS(rc))
    10941094        {
    1095             HGCMSvcSetU64(&paParms[1], prop.mTimestamp);
     1095            HGCMSvcSetU64(&paParms[1], rProp.mTimestamp);
    10961096
    10971097            size_t const cbFlags  = strlen(szFlags) + 1;
    1098             size_t const cbName   = prop.mName.length() + 1;
    1099             size_t const cbValue  = prop.mValue.length() + 1;
     1098            size_t const cbName   = rProp.mName.length() + 1;
     1099            size_t const cbValue  = rProp.mValue.length() + 1;
    11001100            size_t const cbNeeded = cbName + cbValue + cbFlags;
    11011101            HGCMSvcSetU32(&paParms[3], (uint32_t)cbNeeded);
    11021102            if (cbNeeded <= cbBuf)
    11031103            {
    1104                 memcpy(pchBuf, prop.mName.c_str(), cbName);
     1104                memcpy(pchBuf, rProp.mName.c_str(), cbName);
    11051105                pchBuf += cbName;
    1106                 memcpy(pchBuf, prop.mValue.c_str(), cbValue);
     1106                memcpy(pchBuf, rProp.mValue.c_str(), cbValue);
    11071107                pchBuf += cbValue;
    11081108                memcpy(pchBuf, szFlags, cbFlags);
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette