VirtualBox

Changeset 75361 in vbox


Ignore:
Timestamp:
Nov 9, 2018 12:56:40 PM (6 years ago)
Author:
vboxsync
Message:

Recording/Main: Renamed the IRecord* interfaces again to IRecording* to make it more standardized.

Location:
trunk
Files:
31 edited
4 moved

Legend:

Unmodified
Added
Removed
  • trunk/include/VBox/log.h

    r75341 r75361  
    594594    /** Main group, IProgressTaskCompletedEvent. */
    595595    LOG_GROUP_MAIN_PROGRESSTASKCOMPLETEDEVENT,
    596     /** Main group, IRecordChangedEvent. */
    597     LOG_GROUP_MAIN_RECORDCHANGEDEVENT,
    598     /** Main group, IRecordSettings. */
    599     LOG_GROUP_MAIN_RECORDSETTINGS,
    600     /** Main group, IRecordScreenSettings. */
    601     LOG_GROUP_MAIN_RECORDSCREENSETTINGS,
     596    /** Main group, IRecordingChangedEvent. */
     597    LOG_GROUP_MAIN_RECORDINGCHANGEDEVENT,
     598    /** Main group, IRecordingSettings. */
     599    LOG_GROUP_MAIN_RECORDINGSETTINGS,
     600    /** Main group, IRecordingScreenSettings. */
     601    LOG_GROUP_MAIN_RECORDINGSCREENSETTINGS,
    602602    /** Main group, IReusableEvent. */
    603603    LOG_GROUP_MAIN_REUSABLEEVENT,
     
    11241124    "MAIN_PROGRESSPERCENTAGECHANGEDEVENT", \
    11251125    "MAIN_PROGRESSTASKCOMPLETEDEVENT", \
    1126     "MAIN_RECORDCHANGEDEVENT", \
    1127     "MAIN_RECORDSETTINGS", \
    1128     "MAIN_RECORDSCREENSETTINGS", \
     1126    "MAIN_RECORDINGCHANGEDEVENT", \
     1127    "MAIN_RECORDINGSETTINGS", \
     1128    "MAIN_RECORDINGSCREENSETTINGS", \
    11291129    "MAIN_REUSABLEEVENT", \
    11301130    "MAIN_RUNTIMEERROREVENT", \
  • trunk/include/VBox/settings.h

    r75341 r75361  
    482482
    483483/** List for keeping a recording feature list. */
    484 typedef std::map<RecordFeature_T, bool> RecordFeatureMap;
    485 
    486 struct RecordScreenSettings
    487 {
    488     RecordScreenSettings();
    489 
    490     virtual ~RecordScreenSettings();
     484typedef std::map<RecordingFeature_T, bool> RecordingFeatureMap;
     485
     486struct RecordingScreenSettings
     487{
     488    RecordingScreenSettings();
     489
     490    virtual ~RecordingScreenSettings();
    491491
    492492    void applyDefaults(void);
     
    494494    bool areDefaultSettings(void) const;
    495495
    496     bool isFeatureEnabled(RecordFeature_T enmFeature) const;
    497 
    498     bool operator==(const RecordScreenSettings &d) const;
    499 
    500     bool                 fEnabled;       // requires settings version 1.14 (VirtualBox 4.3)
    501     RecordDestination_T enmDest;        // new since VirtualBox 6.0.
    502     RecordFeatureMap    featureMap;    // new since VirtualBox 6.0.
    503     uint32_t             ulMaxTimeS;    // requires settings version 1.14 (VirtualBox 4.3)
    504     com::Utf8Str         strOptions;    // new since VirtualBox 5.2.
     496    bool isFeatureEnabled(RecordingFeature_T enmFeature) const;
     497
     498    bool operator==(const RecordingScreenSettings &d) const;
     499
     500    bool                   fEnabled;   // requires settings version 1.14 (VirtualBox 4.3)
     501    RecordingDestination_T enmDest;    // new since VirtualBox 6.0.
     502    RecordingFeatureMap    featureMap; // new since VirtualBox 6.0.
     503    uint32_t               ulMaxTimeS; // requires settings version 1.14 (VirtualBox 4.3)
     504    com::Utf8Str           strOptions; // new since VirtualBox 5.2.
    505505
    506506    struct Audio
    507507    {
    508508        Audio()
    509             : enmAudioCodec(RecordAudioCodec_Opus)
     509            : enmAudioCodec(RecordingAudioCodec_Opus)
    510510            , uHz(22050)
    511511            , cBits(16)
     
    513513
    514514        /** The audio codec type to use. */
    515         RecordAudioCodec_T enmAudioCodec; // new since VirtualBox 6.0.
     515        RecordingAudioCodec_T enmAudioCodec; // new since VirtualBox 6.0.
    516516        /** Hz rate. */
    517         uint16_t            uHz;           // new since VirtualBox 6.0.
     517        uint16_t              uHz;           // new since VirtualBox 6.0.
    518518        /** Bits per sample. */
    519         uint8_t             cBits;         // new since VirtualBox 6.0.
     519        uint8_t               cBits;         // new since VirtualBox 6.0.
    520520        /** Number of audio channels. */
    521         uint8_t             cChannels;     // new since VirtualBox 6.0.
     521        uint8_t               cChannels;     // new since VirtualBox 6.0.
    522522    } Audio;
    523523
     
    525525    {
    526526        Video()
    527             : enmCodec(RecordVideoCodec_VP8)
     527            : enmCodec(RecordingVideoCodec_VP8)
    528528            , ulWidth(1024)
    529529            , ulHeight(768)
     
    531531            , ulFPS(25) { }
    532532
    533         RecordVideoCodec_T enmCodec;  // new since VirtualBox 6.0.
    534         uint32_t             ulWidth;   // requires settings version 1.14 (VirtualBox 4.3)
    535         uint32_t             ulHeight;  // requires settings version 1.14 (VirtualBox 4.3)
    536         uint32_t             ulRate;    // requires settings version 1.14 (VirtualBox 4.3)
    537         uint32_t             ulFPS;     // requires settings version 1.14 (VirtualBox 4.3)
     533        RecordingVideoCodec_T enmCodec;  // new since VirtualBox 6.0.
     534        uint32_t              ulWidth;   // requires settings version 1.14 (VirtualBox 4.3)
     535        uint32_t              ulHeight;  // requires settings version 1.14 (VirtualBox 4.3)
     536        uint32_t              ulRate;    // requires settings version 1.14 (VirtualBox 4.3)
     537        uint32_t              ulFPS;     // requires settings version 1.14 (VirtualBox 4.3)
    538538    } Video;
    539539
     
    549549
    550550/** Map for keeping settings per virtual screen. */
    551 typedef std::map<uint32_t, RecordScreenSettings> RecordScreenMap;
    552 
    553 /**
    554  * NOTE: If you add any fields in here, you must update a) the constructor and b)
    555  * the operator== which is used by MachineConfigFile::operator==(), or otherwise
    556  * your settings might never get saved.
    557  */
    558 struct RecordSettings
    559 {
    560     RecordSettings();
     551typedef std::map<uint32_t, RecordingScreenSettings> RecordingScreenMap;
     552
     553/**
     554 * NOTE: If you add any fields in here, you must update a) the constructor and b)
     555 * the operator== which is used by MachineConfigFile::operator==(), or otherwise
     556 * your settings might never get saved.
     557 */
     558struct RecordingSettings
     559{
     560    RecordingSettings();
    561561
    562562    void applyDefaults(void);
     
    564564    bool areDefaultSettings(void) const;
    565565
    566     bool operator==(const RecordSettings &d) const;
    567 
    568     bool            fEnabled;       // requires settings version 1.14 (VirtualBox 4.3)
    569     RecordScreenMap mapScreens;
     566    bool operator==(const RecordingSettings &d) const;
     567
     568    bool               fEnabled;       // requires settings version 1.14 (VirtualBox 4.3)
     569    RecordingScreenMap mapScreens;
    570570};
    571571
     
    10391039
    10401040    BIOSSettings        biosSettings;
    1041     RecordSettings      recordSettings;
     1041    RecordingSettings   recordingSettings;
    10421042    USB                 usbSettings;
    10431043    NetworkAdaptersList llNetworkAdapters;
  • trunk/src/VBox/Frontends/VBoxHeadless/VBoxHeadless.cpp

    r75345 r75361  
    961961        if (fRecordEnabled)
    962962        {
    963             ComPtr<IRecordSettings> RecordSettings;
    964             CHECK_ERROR_BREAK(machine, COMGETTER(RecordSettings)(RecordSettings.asOutParam()));
    965             CHECK_ERROR_BREAK(RecordSettings, COMSETTER(Enabled)(TRUE));
    966 
    967             SafeIfaceArray <IRecordScreenSettings> saRecordScreenScreens;
    968             CHECK_ERROR_BREAK(RecordSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordScreenScreens)));
     963            ComPtr<IRecordingSettings> recordingSettings;
     964            CHECK_ERROR_BREAK(machine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()));
     965            CHECK_ERROR_BREAK(recordingSettings, COMSETTER(Enabled)(TRUE));
     966
     967            SafeIfaceArray <IRecordingScreenSettings> saRecordScreenScreens;
     968            CHECK_ERROR_BREAK(recordingSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordScreenScreens)));
    969969
    970970            /* Note: For now all screens have the same configuration. */
     
    12321232            if (!machine.isNull())
    12331233            {
    1234                 ComPtr<IRecordSettings> RecordSettings;
    1235                 CHECK_ERROR_BREAK(machine, COMGETTER(RecordSettings)(RecordSettings.asOutParam()));
    1236                 CHECK_ERROR_BREAK(RecordSettings, COMSETTER(Enabled)(FALSE));
     1234                ComPtr<IRecordingSettings> recordingSettings;
     1235                CHECK_ERROR_BREAK(machine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()));
     1236                CHECK_ERROR_BREAK(recordingSettings, COMSETTER(Enabled)(FALSE));
    12371237            }
    12381238        }
  • trunk/src/VBox/Frontends/VBoxManage/VBoxManageControlVM.cpp

    r75345 r75361  
    18641864            }
    18651865
    1866             ComPtr<IRecordSettings> RecordSettings;
    1867             CHECK_ERROR_BREAK(machine, COMGETTER(RecordSettings)(RecordSettings.asOutParam()));
    1868 
    1869             SafeIfaceArray <IRecordScreenSettings> saRecordScreenScreens;
    1870             CHECK_ERROR_BREAK(RecordSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordScreenScreens)));
     1866            ComPtr<IRecordingSettings> recordingSettings;
     1867            CHECK_ERROR_BREAK(machine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()));
     1868
     1869            SafeIfaceArray <IRecordingScreenSettings> saRecordingScreenScreens;
     1870            CHECK_ERROR_BREAK(recordingSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordingScreenScreens)));
    18711871
    18721872            /* Note: For now all screens have the same configuration. */
     
    18781878            if (!strcmp(a->argv[2], "on"))
    18791879            {
    1880                 CHECK_ERROR_RET(RecordSettings, COMSETTER(Enabled)(TRUE), RTEXITCODE_FAILURE);
     1880                CHECK_ERROR_RET(recordingSettings, COMSETTER(Enabled)(TRUE), RTEXITCODE_FAILURE);
    18811881            }
    18821882            else if (!strcmp(a->argv[2], "off"))
    18831883            {
    1884                 CHECK_ERROR_RET(RecordSettings, COMSETTER(Enabled)(FALSE), RTEXITCODE_FAILURE);
     1884                CHECK_ERROR_RET(recordingSettings, COMSETTER(Enabled)(FALSE), RTEXITCODE_FAILURE);
    18851885            }
    18861886            else if (!strcmp(a->argv[2], "screens"))
     
    19301930                }
    19311931
    1932                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    1933                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(Enabled)(saScreens[i]));
     1932                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     1933                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(Enabled)(saScreens[i]));
    19341934            }
    19351935            else if (!strcmp(a->argv[2], "filename"))
     
    19421942                }
    19431943
    1944                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    1945                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(FileName)(Bstr(a->argv[2]).raw()));
     1944                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     1945                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(FileName)(Bstr(a->argv[2]).raw()));
    19461946            }
    19471947            else if (   !strcmp(a->argv[2], "videores")
     
    19721972                }
    19731973
    1974                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    1975                 {
    1976                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(VideoWidth)(uVal));
    1977                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(VideoHeight)(uVal));
     1974                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     1975                {
     1976                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(VideoWidth)(uVal));
     1977                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(VideoHeight)(uVal));
    19781978                }
    19791979            }
     
    19961996                }
    19971997
    1998                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    1999                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(VideoRate)(uVal));
     1998                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     1999                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(VideoRate)(uVal));
    20002000            }
    20012001            else if (!strcmp(a->argv[2], "videofps"))
     
    20172017                }
    20182018
    2019                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    2020                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(VideoFPS)(uVal));
     2019                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     2020                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(VideoFPS)(uVal));
    20212021            }
    20222022            else if (!strcmp(a->argv[2], "maxtime"))
     
    20382038                }
    20392039
    2040                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    2041                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(MaxTime)(uVal));
     2040                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     2041                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(MaxTime)(uVal));
    20422042            }
    20432043            else if (!strcmp(a->argv[2], "maxfilesize"))
     
    20592059                }
    20602060
    2061                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    2062                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(MaxFileSize)(uVal));
     2061                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     2062                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(MaxFileSize)(uVal));
    20632063            }
    20642064            else if (!strcmp(a->argv[2], "opts"))
     
    20712071                }
    20722072
    2073                 for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    2074                     CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(Options)(Bstr(a->argv[3]).raw()));
     2073                for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     2074                    CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(Options)(Bstr(a->argv[3]).raw()));
    20752075            }
    20762076        }
  • trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp

    r75345 r75361  
    23792379# endif
    23802380
    2381         ComPtr<IRecordSettings> RecordSettings;
    2382         CHECK_ERROR_RET(machine, COMGETTER(RecordSettings)(RecordSettings.asOutParam()), rc);
    2383 
    2384         SafeIfaceArray <IRecordScreenSettings> saCaptureScreenScreens;
    2385         CHECK_ERROR_RET(RecordSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saCaptureScreenScreens)), rc);
     2381        ComPtr<IRecordingSettings> recordingSettings;
     2382        CHECK_ERROR_RET(machine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()), rc);
     2383
     2384        SafeIfaceArray <IRecordingScreenSettings> saRecordingScreenScreens;
     2385        CHECK_ERROR_RET(recordingSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordingScreenScreens)), rc);
    23862386
    23872387        /* For now all screens have the same configuration; so take screen 0 and work with that. */
    23882388        ULONG fFeatures;
    2389         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(Features)(&fFeatures), rc);
     2389        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(Features)(&fFeatures), rc);
    23902390        ULONG Width;
    2391         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(VideoWidth)(&Width), rc);
     2391        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(VideoWidth)(&Width), rc);
    23922392        ULONG Height;
    2393         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(VideoHeight)(&Height), rc);
     2393        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(VideoHeight)(&Height), rc);
    23942394        ULONG Rate;
    2395         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(VideoRate)(&Rate), rc);
     2395        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(VideoRate)(&Rate), rc);
    23962396        ULONG Fps;
    2397         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(VideoFPS)(&Fps), rc);
     2397        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(VideoFPS)(&Fps), rc);
    23982398        Bstr  bstrFile;
    2399         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(FileName)(bstrFile.asOutParam()), rc);
     2399        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(FileName)(bstrFile.asOutParam()), rc);
    24002400        Bstr  bstrOptions;
    2401         CHECK_ERROR_RET(saCaptureScreenScreens[0], COMGETTER(Options)(bstrOptions.asOutParam()), rc);
     2401        CHECK_ERROR_RET(saRecordingScreenScreens[0], COMGETTER(Options)(bstrOptions.asOutParam()), rc);
    24022402
    24032403        Utf8Str strOptions(bstrOptions);
     
    24232423# endif
    24242424        szValue[0] = '\0';
    2425         for (size_t i = 0, off = 0; i < saCaptureScreenScreens.size(); i++)
     2425        for (size_t i = 0, off = 0; i < saRecordingScreenScreens.size(); i++)
    24262426        {
    24272427            BOOL fEnabled;
    2428             CHECK_ERROR_RET(saCaptureScreenScreens[i], COMGETTER(Enabled)(&fEnabled), rc);
     2428            CHECK_ERROR_RET(saRecordingScreenScreens[i], COMGETTER(Enabled)(&fEnabled), rc);
    24292429            if (fEnabled && off < sizeof(szValue) - 3)
    24302430                off += RTStrPrintf(&szValue[off], sizeof(szValue) - off, off ? ",%zu" : "%zu", i);
  • trunk/src/VBox/Frontends/VBoxManage/VBoxManageModifyVM.cpp

    r75345 r75361  
    29502950            case MODIFYVM_RECORD_OPTIONS:
    29512951            {
    2952                 ComPtr<IRecordSettings> RecordSettings;
    2953                 CHECK_ERROR_BREAK(machine, COMGETTER(RecordSettings)(RecordSettings.asOutParam()));
    2954                 SafeIfaceArray <IRecordScreenSettings> saRecordScreenScreens;
    2955                 CHECK_ERROR_BREAK(RecordSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordScreenScreens)));
     2952                ComPtr<IRecordingSettings> recordingSettings;
     2953                CHECK_ERROR_BREAK(machine, COMGETTER(RecordingSettings)(recordingSettings.asOutParam()));
     2954                SafeIfaceArray <IRecordingScreenSettings> saRecordingScreenScreens;
     2955                CHECK_ERROR_BREAK(recordingSettings, COMGETTER(Screens)(ComSafeArrayAsOutParam(saRecordingScreenScreens)));
    29562956
    29572957                switch (c)
     
    29592959                    case MODIFYVM_RECORD:
    29602960                    {
    2961                         CHECK_ERROR(RecordSettings, COMSETTER(Enabled)(ValueUnion.f));
     2961                        CHECK_ERROR(recordingSettings, COMSETTER(Enabled)(ValueUnion.f));
    29622962                        break;
    29632963                    }
     
    29742974                        }
    29752975
    2976                         if (cMonitors > saRecordScreenScreens.size()) /* Paranoia. */
    2977                             cMonitors = (ULONG)saRecordScreenScreens.size();
     2976                        if (cMonitors > saRecordingScreenScreens.size()) /* Paranoia. */
     2977                            cMonitors = (ULONG)saRecordingScreenScreens.size();
    29782978
    29792979                        for (size_t i = 0; i < cMonitors; ++i)
    2980                             CHECK_ERROR_BREAK(saRecordScreenScreens[i], COMSETTER(Enabled)(screens[i]));
     2980                            CHECK_ERROR_BREAK(saRecordingScreenScreens[i], COMSETTER(Enabled)(screens[i]));
    29812981                        break;
    29822982                    }
     
    29982998                        }
    29992999
    3000                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3001                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(FileName)(bstr.raw()));
     3000                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3001                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(FileName)(bstr.raw()));
    30023002                        break;
    30033003                    }
    30043004                    case MODIFYVM_RECORD_VIDEO_WIDTH:
    30053005                    {
    3006                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3007                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(VideoWidth)(ValueUnion.u32));
     3006                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3007                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(VideoWidth)(ValueUnion.u32));
    30083008                        break;
    30093009                    }
    30103010                    case MODIFYVM_RECORD_VIDEO_HEIGHT:
    30113011                    {
    3012                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3013                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(VideoHeight)(ValueUnion.u32));
     3012                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3013                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(VideoHeight)(ValueUnion.u32));
    30143014                        break;
    30153015                    }
     
    30343034                        }
    30353035
    3036                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
     3036                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
    30373037                        {
    3038                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(VideoWidth)(uWidth));
    3039                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(VideoHeight)(uHeight));
     3038                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(VideoWidth)(uWidth));
     3039                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(VideoHeight)(uHeight));
    30403040                        }
    30413041                        break;
     
    30433043                    case MODIFYVM_RECORD_VIDEO_RATE:
    30443044                    {
    3045                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3046                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(VideoRate)(ValueUnion.u32));
     3045                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3046                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(VideoRate)(ValueUnion.u32));
    30473047                        break;
    30483048                    }
    30493049                    case MODIFYVM_RECORD_VIDEO_FPS:
    30503050                    {
    3051                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3052                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(VideoFPS)(ValueUnion.u32));
     3051                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3052                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(VideoFPS)(ValueUnion.u32));
    30533053                        break;
    30543054                    }
    30553055                    case MODIFYVM_RECORD_MAXTIME:
    30563056                    {
    3057                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3058                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(MaxTime)(ValueUnion.u32));
     3057                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3058                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(MaxTime)(ValueUnion.u32));
    30593059                        break;
    30603060                    }
    30613061                    case MODIFYVM_RECORD_MAXSIZE:
    30623062                    {
    3063                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3064                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(MaxFileSize)(ValueUnion.u32));
     3063                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3064                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(MaxFileSize)(ValueUnion.u32));
    30653065                        break;
    30663066                    }
     
    30683068                    {
    30693069                        Bstr bstr(ValueUnion.psz);
    3070                         for (size_t i = 0; i < saRecordScreenScreens.size(); ++i)
    3071                             CHECK_ERROR(saRecordScreenScreens[i], COMSETTER(Options)(bstr.raw()));
     3070                        for (size_t i = 0; i < saRecordingScreenScreens.size(); ++i)
     3071                            CHECK_ERROR(saRecordingScreenScreens[i], COMSETTER(Options)(bstr.raw()));
    30723072                        break;
    30733073                    }
  • trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMainEventListener.cpp

    r75341 r75361  
    375375            break;
    376376        }
    377         case KVBoxEventType_OnRecordChanged:
     377        case KVBoxEventType_OnRecordingChanged:
    378378        {
    379379            emit sigRecordingChange();
  • trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsElements.cpp

    r75341 r75361  
    4444# include "CMediumAttachment.h"
    4545# include "CAudioAdapter.h"
    46 # include "CRecordSettings.h"
    47 # include "CRecordScreenSettings.h"
     46# include "CRecordingSettings.h"
     47# include "CRecordingScreenSettings.h"
    4848# include "CNetworkAdapter.h"
    4949# include "CSerialPort.h"
     
    450450
    451451        /* Recording info: */
    452         CRecordSettings comRecordingSettings = machine.GetRecordSettings();
     452        CRecordingSettings comRecordingSettings = machine.GetRecordingSettings();
    453453        if (comRecordingSettings.GetEnabled())
    454454        {
    455455            /* For now all screens have the same config: */
    456             CRecordScreenSettings comRecordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
     456            CRecordingScreenSettings comRecordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
    457457
    458458            /** @todo r=andy Refine these texts (wrt audio and/or video). */
  • trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIConsoleEventHandler.cpp

    r75341 r75361  
    188188        << KVBoxEventType_OnVRDEServerChanged
    189189        << KVBoxEventType_OnVRDEServerInfoChanged
    190         << KVBoxEventType_OnRecordChanged
     190        << KVBoxEventType_OnRecordingChanged
    191191        << KVBoxEventType_OnUSBControllerChanged
    192192        << KVBoxEventType_OnUSBDeviceStateChanged
  • trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIIndicatorsPool.cpp

    r75341 r75361  
    4343/* COM includes: */
    4444# include "CAudioAdapter.h"
    45 # include "CRecordSettings.h"
    46 # include "CRecordScreenSettings.h"
     45# include "CRecordingSettings.h"
     46# include "CRecordingScreenSettings.h"
    4747# include "CConsole.h"
    4848# include "CMachine.h"
     
    884884
    885885        /* Update indicator state early: */
    886         CRecordSettings comRecordingSettings = comMachine.GetRecordSettings();
     886        CRecordingSettings comRecordingSettings = comMachine.GetRecordingSettings();
    887887        Assert(comRecordingSettings.isOk());
    888888        if (!comRecordingSettings.GetEnabled())
     
    918918
    919919                /* For now all screens have the same config: */
    920                 CRecordScreenSettings comRecordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
     920                CRecordingScreenSettings comRecordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
    921921                Assert(comRecordingScreen0Settings.isOk());
    922922
     
    955955            return;
    956956
    957         CRecordSettings comRecordingSettings = comMachine.GetRecordSettings();
     957        CRecordingSettings comRecordingSettings = comMachine.GetRecordingSettings();
    958958        /* For now all screens have the same config: */
    959         CRecordScreenSettings recordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
    960         if (recordingScreen0Settings.IsFeatureEnabled(KRecordFeature_Video))
     959        CRecordingScreenSettings recordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
     960        if (recordingScreen0Settings.IsFeatureEnabled(KRecordingFeature_Video))
    961961            m_enmRecordingMode = (UIIndicatorStateRecordingMode)((int)m_enmRecordingMode | (int)UIIndicatorStateRecordingMode_Video);
    962962
    963         if (recordingScreen0Settings.IsFeatureEnabled(KRecordFeature_Audio))
     963        if (recordingScreen0Settings.IsFeatureEnabled(KRecordingFeature_Audio))
    964964            m_enmRecordingMode = (UIIndicatorStateRecordingMode)((int)m_enmRecordingMode | (int)UIIndicatorStateRecordingMode_Audio);
    965965    }
  • trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineLogic.cpp

    r75341 r75361  
    7777/* COM includes: */
    7878# include "CAudioAdapter.h"
    79 # include "CRecordSettings.h"
     79# include "CRecordingSettings.h"
    8080# include "CVirtualBoxErrorInfo.h"
    8181# include "CMachineDebugger.h"
     
    21042104
    21052105    /* Make sure something had changed: */
    2106     CRecordSettings comRecordingSettings = machine().GetRecordSettings();
     2106    CRecordingSettings comRecordingSettings = machine().GetRecordingSettings();
    21072107    if (comRecordingSettings.GetEnabled() == static_cast<BOOL>(fEnabled))
    21082108        return;
  • trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

    r75341 r75361  
    6060/* COM includes: */
    6161# include "CAudioAdapter.h"
    62 # include "CRecordSettings.h"
     62# include "CRecordingSettings.h"
    6363# include "CSystemProperties.h"
    6464# include "CStorageController.h"
     
    724724void UISession::sltRecordingChange()
    725725{
    726     CRecordSettings comRecordingSettings = machine().GetRecordSettings();
     726    CRecordingSettings comRecordingSettings = machine().GetRecordingSettings();
    727727
    728728    /* Check/Uncheck Capture action depending on feature status: */
  • trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp

    r75341 r75361  
    3131
    3232/* COM includes: */
    33 # include "CRecordSettings.h"
    34 # include "CRecordScreenSettings.h"
     33# include "CRecordingSettings.h"
     34# include "CRecordingScreenSettings.h"
    3535# include "CExtPack.h"
    3636# include "CExtPackManager.h"
     
    383383
    384384    /* Gather old 'Recording' data: */
    385     CRecordSettings recordingSettings = m_machine.GetRecordSettings();
     385    CRecordingSettings recordingSettings = m_machine.GetRecordingSettings();
    386386    Assert(recordingSettings.isNotNull());
    387387    oldDisplayData.m_fRecordingEnabled = recordingSettings.GetEnabled();
    388388
    389389    /* For now we're using the same settings for all screens; so get settings from screen 0 and work with that. */
    390     CRecordScreenSettings recordingScreen0Settings = recordingSettings.GetScreenSettings(0);
     390    CRecordingScreenSettings recordingScreen0Settings = recordingSettings.GetScreenSettings(0);
    391391    if (!recordingScreen0Settings.isNull())
    392392    {
     
    400400    }
    401401
    402     CRecordScreenSettingsVector recordingScreenSettingsVector = recordingSettings.GetScreens();
     402    CRecordingScreenSettingsVector recordingScreenSettingsVector = recordingSettings.GetScreens();
    403403    oldDisplayData.m_vecRecordingScreens.resize(recordingScreenSettingsVector.size());
    404404    for (int iScreenIndex = 0; iScreenIndex < recordingScreenSettingsVector.size(); ++iScreenIndex)
    405405    {
    406         CRecordScreenSettings recordingScreenSettings = recordingScreenSettingsVector.at(iScreenIndex);
     406        CRecordingScreenSettings recordingScreenSettings = recordingScreenSettingsVector.at(iScreenIndex);
    407407        if (!recordingScreenSettings.isNull())
    408408            oldDisplayData.m_vecRecordingScreens[iScreenIndex] = recordingScreenSettings.GetEnabled();
     
    15111511        const UIDataSettingsMachineDisplay &newDisplayData = m_pCache->data();
    15121512
    1513         CRecordSettings recordingSettings = m_machine.GetRecordSettings();
     1513        CRecordingSettings recordingSettings = m_machine.GetRecordingSettings();
    15141514        Assert(recordingSettings.isNotNull());
    15151515
     
    15331533                if (fSuccess)
    15341534                {
    1535                     CRecordScreenSettingsVector RecordScreenSettingsVector = recordingSettings.GetScreens();
     1535                    CRecordingScreenSettingsVector RecordScreenSettingsVector = recordingSettings.GetScreens();
    15361536                    for (int iScreenIndex = 0; fSuccess && iScreenIndex < RecordScreenSettingsVector.size(); ++iScreenIndex)
    15371537                    {
     
    15391539                            continue;
    15401540
    1541                         CRecordScreenSettings recordingScreenSettings = RecordScreenSettingsVector.at(iScreenIndex);
     1541                        CRecordingScreenSettings recordingScreenSettings = RecordScreenSettingsVector.at(iScreenIndex);
    15421542                        recordingScreenSettings.SetEnabled(newDisplayData.m_vecRecordingScreens[iScreenIndex]);
    15431543                        fSuccess = recordingScreenSettings.isOk();
     
    15481548            else
    15491549            {
    1550                 CRecordScreenSettingsVector recordingScreenSettingsVector = recordingSettings.GetScreens();
     1550                CRecordingScreenSettingsVector recordingScreenSettingsVector = recordingSettings.GetScreens();
    15511551                for (int iScreenIndex = 0; fSuccess && iScreenIndex < recordingScreenSettingsVector.size(); ++iScreenIndex)
    15521552                {
     
    15541554                        continue;
    15551555
    1556                     CRecordScreenSettings recordingScreenSettings = recordingScreenSettingsVector.at(iScreenIndex);
     1556                    CRecordingScreenSettings recordingScreenSettings = recordingScreenSettingsVector.at(iScreenIndex);
    15571557
    15581558                    // We should save all the options *before* 'Recording' activation.
     
    16231623        else
    16241624        {
    1625             CRecordScreenSettingsVector recordingScreenSettingsVector = recordingSettings.GetScreens();
     1625            CRecordingScreenSettingsVector recordingScreenSettingsVector = recordingSettings.GetScreens();
    16261626            for (int iScreenIndex = 0; fSuccess && iScreenIndex < recordingScreenSettingsVector.size(); ++iScreenIndex)
    16271627            {
     
    16291629                    continue;
    16301630
    1631                 CRecordScreenSettings recordingScreenSettings = recordingScreenSettingsVector.at(iScreenIndex);
     1631                CRecordingScreenSettings recordingScreenSettings = recordingScreenSettingsVector.at(iScreenIndex);
    16321632
    16331633                /* Save recording file path: */
  • trunk/src/VBox/Frontends/VirtualBox/src/snapshots/UISnapshotDetailsWidget.cpp

    r75341 r75361  
    4848/* COM includes: */
    4949# include "CAudioAdapter.h"
    50 # include "CRecordSettings.h"
    51 # include "CRecordScreenSettings.h"
     50# include "CRecordingSettings.h"
     51# include "CRecordingScreenSettings.h"
    5252# include "CMachine.h"
    5353# include "CMedium.h"
     
    17481748    QStringList aReport;
    17491749    /* Acquire recording status: */
    1750     CRecordSettings comRecordingSettings = comMachine.GetRecordSettings();
     1750    CRecordingSettings comRecordingSettings = comMachine.GetRecordingSettings();
    17511751    /* For now all screens have the same config: */
    1752     CRecordScreenSettings comRecordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
     1752    CRecordingScreenSettings comRecordingScreen0Settings = comRecordingSettings.GetScreenSettings(0);
    17531753    if (comRecordingScreen0Settings.GetEnabled())
    17541754    {
  • trunk/src/VBox/Main/Makefile.kmk

    r75345 r75361  
    457457        src-server/BandwidthGroupImpl.cpp \
    458458        src-server/BIOSSettingsImpl.cpp \
    459         src-server/RecordSettingsImpl.cpp \
    460         src-server/RecordScreenSettingsImpl.cpp \
     459        src-server/RecordingSettingsImpl.cpp \
     460        src-server/RecordingScreenSettingsImpl.cpp \
    461461        src-server/ClientWatcher.cpp \
    462462        src-server/ClientToken.cpp \
  • trunk/src/VBox/Main/idl/VirtualBox.xidl

    r75341 r75361  
    46904690
    46914691  <enum
    4692     name="RecordDestination"
    4693     uuid="F52E217E-CA05-41BA-8851-0FA38B3BA38B"
     4692    name="RecordingDestination"
     4693    uuid="11E3F06B-DEC1-48B9-BDC4-1E618D72893C"
    46944694    >
    46954695    <desc>
     
    47064706
    47074707  <enum
    4708     name="RecordFeature"
    4709     uuid="52AEC901-4EF5-4E04-8CA3-EF1478BB0930"
     4708    name="RecordingFeature"
     4709    uuid="A7DDC6A5-DAA8-4485-B860-E9F2E98A7794"
    47104710    >
    47114711    <desc>
     
    47254725
    47264726  <enum
    4727     name="RecordAudioCodec"
    4728     uuid="B72DD288-0D3F-4652-AE66-D6F621D2F275"
     4727    name="RecordingAudioCodec"
     4728    uuid="0AEFF775-053A-42F8-9C00-E445107DBED8"
    47294729    >
    47304730    <desc>
     
    47454745
    47464746  <enum
    4747     name="RecordVideoCodec"
    4748     uuid="823F3AD4-151F-4BDB-AFF9-F7C998E46105"
     4747    name="RecordingVideoCodec"
     4748    uuid="663BFC39-AFFF-49FA-98DD-322A857E877B"
    47494749    >
    47504750    <desc>
     
    47674767
    47684768  <enum
    4769     name="RecordVideoScalingMethod"
    4770     uuid="8D656085-BAE6-4F63-86F9-616776EB3773"
     4769    name="RecordingVideoScalingMethod"
     4770    uuid="5576D890-48EE-449A-A81B-B776233598B7"
    47714771    >
    47724772    <desc>
     
    48084808
    48094809  <interface
    4810     name="IRecordScreenSettings" extends="$unknown"
    4811     uuid="7811A5C6-11DB-4F9A-8FAE-1CE238AB4B73"
     4810    name="IRecordingScreenSettings" extends="$unknown"
     4811    uuid="41E56E39-C36D-440E-867B-FB80C4CE6FAA"
    48124812    wsmap="managed"
    48134813    >
    48144814
    48154815    <desc>
    4816       The IRecordScreenSettings interface represents recording settings of a
    4817       single virtual screen. This is used only in the <link to="IRecordSettings" />
     4816      The IRecordingScreenSettings interface represents recording settings of a
     4817      single virtual screen. This is used only in the <link to="IRecordingSettings" />
    48184818      interface.
    48194819    </desc>
     
    48224822      <desc>Returns whether a particular recording feature is enabled for this
    48234823        screen or not.</desc>
    4824       <param name="feature" type="RecordFeature" dir="in">
     4824      <param name="feature" type="RecordingFeature" dir="in">
    48254825        <desc>Feature to check for.</desc>
    48264826      </param>
     
    48474847    </attribute>
    48484848
    4849     <attribute name="destination" type="RecordDestination">
     4849    <attribute name="destination" type="RecordingDestination">
    48504850      <desc>This setting determines the recording destination for this
    48514851        screen.</desc>
     
    49064906    </attribute>
    49074907
    4908     <attribute name="audioCodec" type="RecordAudioCodec">
     4908    <attribute name="audioCodec" type="RecordingAudioCodec">
    49094909      <desc>
    49104910        Determines the audio codec to use for encoding the
     
    49374937    </attribute>
    49384938
    4939     <attribute name="videoCodec" type="RecordVideoCodec">
     4939    <attribute name="videoCodec" type="RecordingVideoCodec">
    49404940      <desc>
    49414941        Determines the video codec to use for encoding the recorded video data.
     
    49824982    </attribute>
    49834983
    4984     <attribute name="videoScalingMethod" type="RecordVideoScalingMethod">
     4984    <attribute name="videoScalingMethod" type="RecordingVideoScalingMethod">
    49854985      <desc>
    49864986        Determines the video scaling method to use.
     
    49924992
    49934993  <interface
    4994     name="IRecordSettings" extends="$unknown"
    4995     uuid="7202BACF-2BFE-46AA-AEF6-69B32FDDE236"
     4994    name="IRecordingSettings" extends="$unknown"
     4995    uuid="D88F2A5A-47C7-4A3F-AAE1-1B516817DB41"
    49964996    wsmap="managed"
    49974997    >
    49984998
    49994999    <desc>
    5000       The IRecordSettings interface represents recording settings of the virtual
     5000      The IRecordingSettings interface represents recording settings of the virtual
    50015001      machine. This is used only in the <link to="IMachine::recordSettings" />
    50025002      attribute.
     
    50085008        <desc>Screen ID to retrieve recording screen settings for.</desc>
    50095009      </param>
    5010       <param name="recordScreenSettings" type="IRecordScreenSettings" dir="return">
     5010      <param name="recordScreenSettings" type="IRecordingScreenSettings" dir="return">
    50115011        <desc>Recording screen settings for the requested screen.</desc>
    50125012      </param>
     
    50195019    </attribute>
    50205020
    5021     <attribute name="screens" type="IRecordScreenSettings" readonly="yes" safearray="yes">
     5021    <attribute name="screens" type="IRecordingScreenSettings" readonly="yes" safearray="yes">
    50225022      <desc>
    50235023        This setting returns an array for recording settings of all configured
     
    52215221  <interface
    52225222    name="IMachine" extends="$unknown"
    5223     uuid="7210DD84-2301-4C3B-8DB3-72DEBD3B91F9"
     5223    uuid="BD65ADC6-7F47-4F69-B881-96EA06CF9924"
    52245224    wsmap="managed"
    52255225    wrap-hint-server-addinterfaces="IInternalMachineControl"
     
    55065506    </attribute>
    55075507
    5508     <attribute name="recordSettings" type="IRecordSettings" readonly="yes">
     5508    <attribute name="recordingSettings" type="IRecordingSettings" readonly="yes">
    55095509      <desc>Object containing all recording settings.</desc>
    55105510    </attribute>
     
    2065220652  <interface
    2065320653    name="IInternalSessionControl" extends="$unknown"
    20654     uuid="5CEB7885-5DD5-48E4-96C1-EEF4F4FD9FAC"
     20654    uuid="DE773CFC-B679-4225-8EAE-938D294B73D2"
    2065520655    internal="yes"
    2065620656    wsmap="suppress"
     
    2095220952    </method>
    2095320953
    20954     <method name="onRecordChange">
     20954    <method name="onRecordingChange">
    2095520955      <desc>
    2095620956        Triggered when recording settings have changed.
     
    2277722777  <enum
    2277822778    name="VBoxEventType"
    22779     uuid="b2ddb312-2f9e-4e69-98df-7235e43b2149"
     22779    uuid="822087CA-4703-49E4-B20D-C6D794E67969"
    2278022780    >
    2278122781
     
    2313623136      </desc>
    2313723137    </const>
    23138     <const name="OnRecordChanged" value="91">
    23139       <desc>
    23140         See <link to="IRecordChangedEvent">IRecordChangeEvent</link>.
     23138    <const name="OnRecordingChanged" value="91">
     23139      <desc>
     23140        See <link to="IRecordingChangedEvent">IRecordingChangeEvent</link>.
    2314123141      </desc>
    2314223142    </const>
     
    2452324523
    2452424524  <interface
    24525     name="IRecordChangedEvent" extends="IEvent"
    24526     uuid="DA51AA0C-E642-4AA0-9DDD-B07E2911188B"
    24527     wsmap="managed" autogen="VBoxEvent" id="OnRecordChanged"
     24525    name="IRecordingChangedEvent" extends="IEvent"
     24526    uuid="B5DDB370-08A7-4C8F-910D-47AABD67253A"
     24527    wsmap="managed" autogen="VBoxEvent" id="OnRecordingChanged"
    2452824528    >
    2452924529    <desc>
  • trunk/src/VBox/Main/include/ConsoleImpl.h

    r75354 r75361  
    145145    void i_recordingDestroy(void);
    146146    int i_recordingEnable(BOOL fEnable, util::AutoWriteLock *pAutoLock);
    147     int i_recordingGetSettings(settings::RecordSettings &Settings);
     147    int i_recordingGetSettings(settings::RecordingSettings &Settings);
    148148    int i_recordingStart(void);
    149149    int i_recordingStop(void);
     
    179179    HRESULT i_onDnDModeChange(DnDMode_T aDnDMode);
    180180    HRESULT i_onVRDEServerChange(BOOL aRestart);
    181     HRESULT i_onRecordChange();
     181    HRESULT i_onRecordingChange();
    182182    HRESULT i_onUSBControllerChange();
    183183    HRESULT i_onSharedFolderChange(BOOL aGlobal);
  • trunk/src/VBox/Main/include/DrvAudioRec.h

    r75354 r75361  
    4545public:
    4646
    47     int applyConfiguration(const settings::RecordSettings &Settings);
     47    int applyConfiguration(const settings::RecordingSettings &Settings);
    4848
    4949public:
     
    6161    struct DRVAUDIORECORDING         *mpDrv;
    6262    /** Capturing configuration used for configuring the driver. */
    63     struct settings::RecordSettings mVideoRecCfg;
     63    struct settings::RecordingSettings mVideoRecCfg;
    6464};
    6565
  • trunk/src/VBox/Main/include/MachineImpl.h

    r75341 r75361  
    3232#include "ParallelPortImpl.h"
    3333#include "BIOSSettingsImpl.h"
    34 #include "RecordSettingsImpl.h"
     34#include "RecordingSettingsImpl.h"
    3535#include "StorageControllerImpl.h"          // required for MachineImpl.h to compile on Windows
    3636#include "USBControllerImpl.h"              // required for MachineImpl.h to compile on Windows
     
    266266        GraphicsControllerType_T mGraphicsControllerType;
    267267        ULONG               mVRAMSize;
    268         settings::RecordSettings mRecordSettings;
     268        settings::RecordingSettings mRecordSettings;
    269269        ULONG               mMonitorCount;
    270270        BOOL                mHWVirtExEnabled;
     
    777777    const ComObjPtr<USBDeviceFilters>  mUSBDeviceFilters;
    778778    const ComObjPtr<BIOSSettings>      mBIOSSettings;
    779     const ComObjPtr<RecordSettings>    mRecordSettings;
     779    const ComObjPtr<RecordingSettings> mRecordingSettings;
    780780    const ComObjPtr<BandwidthControl>  mBandwidthControl;
    781781
     
    825825
    826826    friend class Appliance;
    827     friend class RecordSettings;
    828     friend class RecordScreenSettings;
     827    friend class RecordingSettings;
     828    friend class RecordingScreenSettings;
    829829    friend class SessionMachine;
    830830    friend class SnapshotMachine;
     
    880880    HRESULT setMonitorCount(ULONG aMonitorCount);
    881881    HRESULT getBIOSSettings(ComPtr<IBIOSSettings> &aBIOSSettings);
    882     HRESULT getRecordSettings(ComPtr<IRecordSettings> &aRecordSettings);
     882    HRESULT getRecordingSettings(ComPtr<IRecordingSettings> &aRecordingSettings);
    883883    HRESULT getFirmwareType(FirmwareType_T *aFirmwareType);
    884884    HRESULT setFirmwareType(FirmwareType_T aFirmwareType);
  • trunk/src/VBox/Main/include/Recording.h

    r75354 r75361  
    4141    RecordingContext(Console *pConsole);
    4242
    43     RecordingContext(Console *pConsole, const settings::RecordSettings &a_Settings);
     43    RecordingContext(Console *pConsole, const settings::RecordingSettings &a_Settings);
    4444
    4545    virtual ~RecordingContext(void);
     
    4747public:
    4848
    49     const settings::RecordSettings &GetConfig(void) const;
     49    const settings::RecordingSettings &GetConfig(void) const;
    5050    RecordingStream *GetStream(unsigned uScreen) const;
    5151    size_t GetStreamCount(void) const;
    5252
    53     int Create(const settings::RecordSettings &a_Settings);
     53    int Create(const settings::RecordingSettings &a_Settings);
    5454    int Destroy(void);
    5555
     
    6464public:
    6565
    66     bool IsFeatureEnabled(RecordFeature_T enmFeature) const;
     66    bool IsFeatureEnabled(RecordingFeature_T enmFeature) const;
    6767    bool IsReady(void) const;
    6868    bool IsReady(uint32_t uScreen, uint64_t uTimeStampMs) const;
     
    7272protected:
    7373
    74     int createInternal(const settings::RecordSettings &a_Settings);
     74    int createInternal(const settings::RecordingSettings &a_Settings);
    7575    int startInternal(void);
    7676    int stopInternal(void);
     
    104104    Console                  *pConsole;
    105105    /** Used recording configuration. */
    106     settings::RecordSettings  Settings;
     106    settings::RecordingSettings  Settings;
    107107    /** The current state. */
    108108    RECORDINGSTS              enmState;
  • trunk/src/VBox/Main/include/RecordingScreenSettingsImpl.h

    r75360 r75361  
    33/** @file
    44 *
    5  * VirtualBox COM class implementation - Capture settings of one virtual screen.
     5 * VirtualBox COM class implementation - Recording settings of one virtual screen.
    66 */
    77
     
    1818 */
    1919
    20 #ifndef ____H_RecordScreenSettings
    21 #define ____H_RecordScreenSettings
     20#ifndef ____H_RecordingScreenSettings
     21#define ____H_RecordingScreenSettings
    2222
    23 #include "RecordScreenSettingsWrap.h"
     23#include "RecordingScreenSettingsWrap.h"
    2424
    25 class RecordSettings;
     25class RecordingSettings;
    2626
    2727namespace settings
    2828{
    29     struct RecordScreenSettings;
     29    struct RecordingScreenSettings;
    3030}
    3131
    32 class ATL_NO_VTABLE RecordScreenSettings :
    33     public RecordScreenSettingsWrap
     32class ATL_NO_VTABLE RecordingScreenSettings :
     33    public RecordingScreenSettingsWrap
    3434{
    3535public:
    3636
    37     DECLARE_EMPTY_CTOR_DTOR(RecordScreenSettings)
     37    DECLARE_EMPTY_CTOR_DTOR(RecordingScreenSettings)
    3838
    3939    HRESULT FinalConstruct();
     
    4141
    4242    // public initializer/uninitializer for internal purposes only
    43     HRESULT init(RecordSettings *aParent, uint32_t uScreenId, const settings::RecordScreenSettings& data);
    44     HRESULT init(RecordSettings *aParent, RecordScreenSettings *that);
    45     HRESULT initCopy(RecordSettings *aParent, RecordScreenSettings *that);
     43    HRESULT init(RecordingSettings *aParent, uint32_t uScreenId, const settings::RecordingScreenSettings& data);
     44    HRESULT init(RecordingSettings *aParent, RecordingScreenSettings *that);
     45    HRESULT initCopy(RecordingSettings *aParent, RecordingScreenSettings *that);
    4646    void uninit();
    4747
    4848    // public methods only for internal purposes
    49     HRESULT i_loadSettings(const settings::RecordScreenSettings &data);
    50     HRESULT i_saveSettings(settings::RecordScreenSettings &data);
     49    HRESULT i_loadSettings(const settings::RecordingScreenSettings &data);
     50    HRESULT i_saveSettings(settings::RecordingScreenSettings &data);
    5151
    5252    void i_rollback();
    5353    void i_commit();
    54     void i_copyFrom(RecordScreenSettings *aThat);
     54    void i_copyFrom(RecordingScreenSettings *aThat);
    5555    void i_applyDefaults();
    5656
    5757private:
    5858
    59     // wrapped IRecordScreenSettings methods
    60     HRESULT isFeatureEnabled(RecordFeature_T aFeature, BOOL *aEnabled);
     59    // wrapped IRecordingScreenSettings methods
     60    HRESULT isFeatureEnabled(RecordingFeature_T aFeature, BOOL *aEnabled);
    6161
    62     // wrapped IRecordScreenSettings properties
     62    // wrapped IRecordingScreenSettings properties
    6363    HRESULT getId(ULONG *id);
    6464    HRESULT getEnabled(BOOL *enabled);
     
    6666    HRESULT getFeatures(ULONG *aFeatures);
    6767    HRESULT setFeatures(ULONG aFeatures);
    68     HRESULT getDestination(RecordDestination_T *aDestination);
    69     HRESULT setDestination(RecordDestination_T aDestination);
     68    HRESULT getDestination(RecordingDestination_T *aDestination);
     69    HRESULT setDestination(RecordingDestination_T aDestination);
    7070
    7171    HRESULT getFileName(com::Utf8Str &aFileName);
     
    7878    HRESULT setOptions(const com::Utf8Str &aOptions);
    7979
    80     HRESULT getAudioCodec(RecordAudioCodec_T *aCodec);
    81     HRESULT setAudioCodec(RecordAudioCodec_T aCodec);
     80    HRESULT getAudioCodec(RecordingAudioCodec_T *aCodec);
     81    HRESULT setAudioCodec(RecordingAudioCodec_T aCodec);
    8282    HRESULT getAudioHz(ULONG *aHz);
    8383    HRESULT setAudioHz(ULONG aHz);
     
    8787    HRESULT setAudioChannels(ULONG aChannels);
    8888
    89     HRESULT getVideoCodec(RecordVideoCodec_T *aCodec);
    90     HRESULT setVideoCodec(RecordVideoCodec_T aCodec);
     89    HRESULT getVideoCodec(RecordingVideoCodec_T *aCodec);
     90    HRESULT setVideoCodec(RecordingVideoCodec_T aCodec);
    9191    HRESULT getVideoWidth(ULONG *aVideoWidth);
    9292    HRESULT setVideoWidth(ULONG aVideoWidth);
     
    9999    HRESULT getVideoFPS(ULONG *aVideoFPS);
    100100    HRESULT setVideoFPS(ULONG aVideoFPS);
    101     HRESULT getVideoScalingMethod(RecordVideoScalingMethod_T *aMode);
    102     HRESULT setVideoScalingMethod(RecordVideoScalingMethod_T aMode);
     101    HRESULT getVideoScalingMethod(RecordingVideoScalingMethod_T *aMode);
     102    HRESULT setVideoScalingMethod(RecordingVideoScalingMethod_T aMode);
    103103
    104104private:
     
    113113};
    114114
    115 #endif // ____H_RecordScreenSettings
     115#endif // ____H_RecordingScreenSettings
    116116
  • trunk/src/VBox/Main/include/RecordingSettingsImpl.h

    r75360 r75361  
    2121#define ____H_RecordSettings
    2222
    23 #include "RecordSettingsWrap.h"
     23#include "RecordingSettingsWrap.h"
    2424
    2525namespace settings
    2626{
    27     struct RecordSettings;
    28     struct RecordScreenSettings;
     27    struct RecordingSettings;
     28    struct RecordingScreenSettings;
    2929}
    3030
    31 class RecordScreenSettings;
     31class RecordingScreenSettings;
    3232
    33 class ATL_NO_VTABLE RecordSettings :
    34     public RecordSettingsWrap
     33class ATL_NO_VTABLE RecordingSettings :
     34    public RecordingSettingsWrap
    3535{
    3636public:
    3737
    38     DECLARE_EMPTY_CTOR_DTOR(RecordSettings)
     38    DECLARE_EMPTY_CTOR_DTOR(RecordingSettings)
    3939
    4040    HRESULT FinalConstruct();
     
    4343    // public initializer/uninitializer for internal purposes only
    4444    HRESULT init(Machine *parent);
    45     HRESULT init(Machine *parent, RecordSettings *that);
    46     HRESULT initCopy(Machine *parent, RecordSettings *that);
     45    HRESULT init(Machine *parent, RecordingSettings *that);
     46    HRESULT initCopy(Machine *parent, RecordingSettings *that);
    4747    void uninit();
    4848
    4949    // public methods only for internal purposes
    50     HRESULT i_loadSettings(const settings::RecordSettings &data);
    51     HRESULT i_saveSettings(settings::RecordSettings &data);
     50    HRESULT i_loadSettings(const settings::RecordingSettings &data);
     51    HRESULT i_saveSettings(settings::RecordingSettings &data);
    5252
    5353    void i_rollback();
    5454    void i_commit();
    55     void i_copyFrom(RecordSettings *aThat);
     55    void i_copyFrom(RecordingSettings *aThat);
    5656    void i_applyDefaults(void);
    5757
     
    6363
    6464    /** Map of screen settings objects. The key specifies the screen ID. */
    65     typedef std::map <uint32_t, ComObjPtr<RecordScreenSettings> > RecordScreenSettingsMap;
     65    typedef std::map <uint32_t, ComObjPtr<RecordingScreenSettings> > RecordScreenSettingsMap;
    6666
    6767    void i_reset(void);
    6868    int i_syncToMachineDisplays(void);
    69     int i_createScreenObj(RecordScreenSettingsMap &screenSettingsMap, uint32_t uScreenId, const settings::RecordScreenSettings &data);
     69    int i_createScreenObj(RecordScreenSettingsMap &screenSettingsMap, uint32_t uScreenId, const settings::RecordingScreenSettings &data);
    7070    int i_destroyScreenObj(RecordScreenSettingsMap &screenSettingsMap, uint32_t uScreenId);
    7171    int i_destroyAllScreenObj(RecordScreenSettingsMap &screenSettingsMap);
     
    7373private:
    7474
    75     // wrapped IRecordSettings properties
     75    // wrapped IRecordingSettings properties
    7676    HRESULT getEnabled(BOOL *enabled);
    7777    HRESULT setEnabled(BOOL enable);
    78     HRESULT getScreens(std::vector<ComPtr<IRecordScreenSettings> > &aRecordScreenSettings);
     78    HRESULT getScreens(std::vector<ComPtr<IRecordingScreenSettings> > &aRecordScreenSettings);
    7979
    80     // wrapped IRecordSettings methods
    81     HRESULT getScreenSettings(ULONG uScreenId, ComPtr<IRecordScreenSettings> &aRecordScreenSettings);
     80    // wrapped IRecordingSettings methods
     81    HRESULT getScreenSettings(ULONG uScreenId, ComPtr<IRecordingScreenSettings> &aRecordScreenSettings);
    8282
    8383private:
  • trunk/src/VBox/Main/include/RecordingStream.h

    r75355 r75361  
    111111    RecordingStream(RecordingContext *pCtx);
    112112
    113     RecordingStream(RecordingContext *pCtx, uint32_t uScreen, const settings::RecordScreenSettings &Settings);
     113    RecordingStream(RecordingContext *pCtx, uint32_t uScreen, const settings::RecordingScreenSettings &Settings);
    114114
    115115    virtual ~RecordingStream(void);
     
    117117public:
    118118
    119     int Init(RecordingContext *pCtx, uint32_t uScreen, const settings::RecordScreenSettings &Settings);
     119    int Init(RecordingContext *pCtx, uint32_t uScreen, const settings::RecordingScreenSettings &Settings);
    120120    int Uninit(void);
    121121
     
    124124                       uint32_t uSrcWidth, uint32_t uSrcHeight, uint8_t *puSrcData, uint64_t uTimeStampMs);
    125125
    126     const settings::RecordScreenSettings &GetConfig(void) const;
     126    const settings::RecordingScreenSettings &GetConfig(void) const;
    127127    bool IsLimitReached(uint64_t tsNowMs) const;
    128128    bool IsReady(void) const;
     
    130130protected:
    131131
    132     int open(const settings::RecordScreenSettings &Settings);
     132    int open(const settings::RecordingScreenSettings &Settings);
    133133    int close(void);
    134134
    135     int initInternal(RecordingContext *pCtx, uint32_t uScreen, const settings::RecordScreenSettings &Settings);
     135    int initInternal(RecordingContext *pCtx, uint32_t uScreen, const settings::RecordingScreenSettings &Settings);
    136136    int uninitInternal(void);
    137137
     
    205205    } Video;
    206206
    207     settings::RecordScreenSettings ScreenSettings;
     207    settings::RecordingScreenSettings ScreenSettings;
    208208    /** Common set of recording (data) blocks, needed for
    209209     *  multiplexing to all recording streams. */
  • trunk/src/VBox/Main/include/SessionImpl.h

    r75341 r75361  
    102102    HRESULT onCPUExecutionCapChange(ULONG aExecutionCap);
    103103    HRESULT onVRDEServerChange(BOOL aRestart);
    104     HRESULT onRecordChange();
     104    HRESULT onRecordingChange();
    105105    HRESULT onUSBControllerChange();
    106106    HRESULT onSharedFolderChange(BOOL aGlobal);
  • trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

    r75354 r75361  
    56325632# ifdef VBOX_WITH_AUDIO_RECORDING
    56335633                    /* Attach the video recording audio driver if required. */
    5634                     if (   Recording.mpCtx->IsFeatureEnabled(RecordFeature_Audio)
     5634                    if (   Recording.mpCtx->IsFeatureEnabled(RecordingFeature_Audio)
    56355635                        && Recording.mAudioRec)
    56365636                    {
     
    56675667#endif /* VBOX_WITH_RECORDING */
    56685668
    5669 HRESULT Console::i_onRecordChange()
     5669HRESULT Console::i_onRecordingChange()
    56705670{
    56715671    AutoCaller autoCaller(this);
     
    56805680    if (ptrVM.isOk())
    56815681    {
    5682         ComPtr<IRecordSettings> RecordSettings;
    5683         rc = mMachine->COMGETTER(RecordSettings)(RecordSettings.asOutParam());
     5682        ComPtr<IRecordingSettings> recordingSettings;
     5683        rc = mMachine->COMGETTER(RecordingSettings)(recordingSettings.asOutParam());
    56845684        AssertComRCReturnRC(rc);
    56855685
    56865686        BOOL fEnabled;
    5687         rc = RecordSettings->COMGETTER(Enabled)(&fEnabled);
     5687        rc = recordingSettings->COMGETTER(Enabled)(&fEnabled);
    56885688        AssertComRCReturnRC(rc);
    56895689
     
    56925692        {
    56935693            alock.release();
    5694             fireRecordChangedEvent(mEventSource);
     5694            fireRecordingChangedEvent(mEventSource);
    56955695        }
    56965696
     
    68826882
    68836883    if (   Recording.mpCtx->IsStarted()
    6884         && Recording.mpCtx->IsFeatureEnabled(RecordFeature_Audio))
     6884        && Recording.mpCtx->IsFeatureEnabled(RecordingFeature_Audio))
    68856885    {
    68866886        return Recording.mpCtx->SendAudioFrame(pvData, cbData, uTimestampMs);
     
    68926892
    68936893#ifdef VBOX_WITH_RECORDING
    6894 int Console::i_recordingGetSettings(settings::RecordSettings &Settings)
     6894int Console::i_recordingGetSettings(settings::RecordingSettings &Settings)
    68956895{
    68966896    Assert(mMachine.isNotNull());
     
    68986898    Settings.applyDefaults();
    68996899
    6900     ComPtr<IRecordSettings> pRecordSettings;
    6901     HRESULT hrc = mMachine->COMGETTER(RecordSettings)(pRecordSettings.asOutParam());
     6900    ComPtr<IRecordingSettings> pRecordSettings;
     6901    HRESULT hrc = mMachine->COMGETTER(RecordingSettings)(pRecordSettings.asOutParam());
    69026902    AssertComRCReturn(hrc, VERR_INVALID_PARAMETER);
    69036903
     
    69076907    Settings.fEnabled = RT_BOOL(fTemp);
    69086908
    6909     SafeIfaceArray<IRecordScreenSettings> paRecordingScreens;
     6909    SafeIfaceArray<IRecordingScreenSettings> paRecordingScreens;
    69106910    hrc = pRecordSettings->COMGETTER(Screens)(ComSafeArrayAsOutParam(paRecordingScreens));
    69116911    AssertComRCReturn(hrc, VERR_INVALID_PARAMETER);
     
    69136913    for (unsigned long i = 0; i < (unsigned long)paRecordingScreens.size(); ++i)
    69146914    {
    6915         settings::RecordScreenSettings RecordScreenSettings;
    6916         ComPtr<IRecordScreenSettings> pRecordScreenSettings = paRecordingScreens[i];
     6915        settings::RecordingScreenSettings RecordScreenSettings;
     6916        ComPtr<IRecordingScreenSettings> pRecordScreenSettings = paRecordingScreens[i];
    69176917
    69186918        hrc = pRecordScreenSettings->COMGETTER(Enabled)(&fTemp);
     
    69716971    }
    69726972
    6973     settings::RecordSettings Settings;
     6973    settings::RecordingSettings Settings;
    69746974    rc = i_recordingGetSettings(Settings);
    69756975    if (RT_SUCCESS(rc))
     
    70437043            mDisplay->i_recordingScreenChanged(uScreen);
    70447044
    7045         ComPtr<IRecordSettings> pRecordSettings;
    7046         HRESULT hrc = mMachine->COMGETTER(RecordSettings)(pRecordSettings.asOutParam());
     7045        ComPtr<IRecordingSettings> pRecordSettings;
     7046        HRESULT hrc = mMachine->COMGETTER(RecordingSettings)(pRecordSettings.asOutParam());
    70477047        ComAssertComRC(hrc);
    70487048        hrc = pRecordSettings->COMSETTER(Enabled)(false);
     
    1014610146
    1014710147#ifdef VBOX_WITH_RECORDING
    10148         ComPtr<IRecordSettings> RecordSettings;
    10149         rc = pConsole->mMachine->COMGETTER(RecordSettings)(RecordSettings.asOutParam());
     10148        ComPtr<IRecordingSettings> recordingSettings;
     10149        rc = pConsole->mMachine->COMGETTER(RecordingSettings)(recordingSettings.asOutParam());
    1015010150        AssertComRCReturnVoid(rc);
    1015110151
    10152         BOOL fCaptureEnabled;
    10153         rc = RecordSettings->COMGETTER(Enabled)(&fCaptureEnabled);
     10152        BOOL fRecordingEnabled;
     10153        rc = recordingSettings->COMGETTER(Enabled)(&fRecordingEnabled);
    1015410154        AssertComRCReturnVoid(rc);
    1015510155
    10156         if (fCaptureEnabled)
    10157         {
    10158             int vrc2 = pConsole->i_recordingEnable(fCaptureEnabled, &alock);
     10156        if (fRecordingEnabled)
     10157        {
     10158            int vrc2 = pConsole->i_recordingEnable(fRecordingEnabled, &alock);
    1015910159            if (RT_SUCCESS(vrc2))
    1016010160            {
    10161                 fireRecordChangedEvent(pConsole->mEventSource);
     10161                fireRecordingChangedEvent(pConsole->mEventSource);
    1016210162            }
    1016310163            else
  • trunk/src/VBox/Main/src-client/DisplayImpl.cpp

    r75354 r75361  
    33933393    if (   pCtx
    33943394        && pCtx->IsStarted()
    3395         && pCtx->IsFeatureEnabled(RecordFeature_Video))
     3395        && pCtx->IsFeatureEnabled(RecordingFeature_Video))
    33963396    {
    33973397        do {
     
    38593859    if (   pCtx
    38603860        && pCtx->IsStarted()
    3861         && pCtx->IsFeatureEnabled(RecordFeature_Video))
     3861        && pCtx->IsFeatureEnabled(RecordingFeature_Video))
    38623862    {
    38633863        int rc2 = pCtx->SendVideoFrame(uScreen, x, y,
  • trunk/src/VBox/Main/src-client/DrvAudioRec.cpp

    r75354 r75361  
    10881088 * @param   Settings        Capturing configuration to apply.
    10891089 */
    1090 int AudioVideoRec::applyConfiguration(const settings::RecordSettings &Settings)
     1090int AudioVideoRec::applyConfiguration(const settings::RecordingSettings &Settings)
    10911091{
    10921092    /** @todo Do some validation here. */
     
    11081108    /** @todo For now we're using the configuration of the first screen here audio-wise. */
    11091109    Assert(mVideoRecCfg.mapScreens.size() >= 1);
    1110     const settings::RecordScreenSettings &Screen0Settings = mVideoRecCfg.mapScreens[0];
     1110    const settings::RecordingScreenSettings &Screen0Settings = mVideoRecCfg.mapScreens[0];
    11111111
    11121112    rc = CFGMR3InsertInteger(pLunCfg, "ContainerType", (uint64_t)Screen0Settings.enmDest);
    11131113    AssertRCReturn(rc, rc);
    1114     if (Screen0Settings.enmDest == RecordDestination_File)
     1114    if (Screen0Settings.enmDest == RecordingDestination_File)
    11151115    {
    11161116        rc = CFGMR3InsertString(pLunCfg, "ContainerFileName", Utf8Str(Screen0Settings.File.strName).c_str());
  • trunk/src/VBox/Main/src-client/Recording.cpp

    r75355 r75361  
    9494    , enmState(RECORDINGSTS_UNINITIALIZED) { }
    9595
    96 RecordingContext::RecordingContext(Console *a_pConsole, const settings::RecordSettings &a_Settings)
     96RecordingContext::RecordingContext(Console *a_pConsole, const settings::RecordingSettings &a_Settings)
    9797    : pConsole(a_pConsole)
    9898    , enmState(RECORDINGSTS_UNINITIALIZED)
     
    177177 * @param   a_Settings          Capture settings to use for context creation.
    178178 */
    179 int RecordingContext::createInternal(const settings::RecordSettings &a_Settings)
     179int RecordingContext::createInternal(const settings::RecordingSettings &a_Settings)
    180180{
    181181    int rc = RTCritSectInit(&this->CritSect);
     
    183183        return rc;
    184184
    185     settings::RecordScreenMap::const_iterator itScreen = a_Settings.mapScreens.begin();
     185    settings::RecordingScreenMap::const_iterator itScreen = a_Settings.mapScreens.begin();
    186186    while (itScreen != a_Settings.mapScreens.end())
    187187    {
     
    318318}
    319319
    320 const settings::RecordSettings &RecordingContext::GetConfig(void) const
     320const settings::RecordingSettings &RecordingContext::GetConfig(void) const
    321321{
    322322    return this->Settings;
     
    355355}
    356356
    357 int RecordingContext::Create(const settings::RecordSettings &a_Settings)
     357int RecordingContext::Create(const settings::RecordingSettings &a_Settings)
    358358{
    359359    return createInternal(a_Settings);
     
    375375}
    376376
    377 bool RecordingContext::IsFeatureEnabled(RecordFeature_T enmFeature) const
     377bool RecordingContext::IsFeatureEnabled(RecordingFeature_T enmFeature) const
    378378{
    379379    RecordingStreams::const_iterator itStream = this->vecStreams.begin();
  • trunk/src/VBox/Main/src-client/RecordingStream.cpp

    r75354 r75361  
    5151}
    5252
    53 RecordingStream::RecordingStream(RecordingContext *a_pCtx, uint32_t uScreen, const settings::RecordScreenSettings &Settings)
     53RecordingStream::RecordingStream(RecordingContext *a_pCtx, uint32_t uScreen, const settings::RecordingScreenSettings &Settings)
    5454    : enmState(RECORDINGSTREAMSTATE_UNINITIALIZED)
    5555    , tsStartMs(0)
     
    7474 * @returns IPRT status code.
    7575 */
    76 int RecordingStream::open(const settings::RecordScreenSettings &Settings)
     76int RecordingStream::open(const settings::RecordingScreenSettings &Settings)
    7777{
    7878    /* Sanity. */
    79     Assert(Settings.enmDest != RecordDestination_None);
     79    Assert(Settings.enmDest != RecordingDestination_None);
    8080
    8181    int rc;
     
    8383    switch (Settings.enmDest)
    8484    {
    85         case RecordDestination_File:
     85        case RecordingDestination_File:
    8686        {
    8787            Assert(Settings.File.strName.isNotEmpty());
     
    209209            if (value.compare("false", Utf8Str::CaseInsensitive) == 0)
    210210            {
    211                 this->ScreenSettings.featureMap[RecordFeature_Video] = false;
     211                this->ScreenSettings.featureMap[RecordingFeature_Video] = false;
    212212#ifdef VBOX_WITH_AUDIO_RECORDING
    213213                LogRel(("Recording: Only audio will be recorded\n"));
     
    220220            if (value.compare("true", Utf8Str::CaseInsensitive) == 0)
    221221            {
    222                 this->ScreenSettings.featureMap[RecordFeature_Audio] = true;
     222                this->ScreenSettings.featureMap[RecordingFeature_Audio] = true;
    223223            }
    224224            else
     
    255255}
    256256
    257 const settings::RecordScreenSettings &RecordingStream::GetConfig(void) const
     257const settings::RecordingScreenSettings &RecordingStream::GetConfig(void) const
    258258{
    259259    return this->ScreenSettings;
     
    277277    }
    278278
    279     if (this->ScreenSettings.enmDest == RecordDestination_File)
     279    if (this->ScreenSettings.enmDest == RecordingDestination_File)
    280280    {
    281281
     
    661661 * @param   Settings            Capturing configuration to use for initialization.
    662662 */
    663 int RecordingStream::Init(RecordingContext *a_pCtx, uint32_t uScreen, const settings::RecordScreenSettings &Settings)
     663int RecordingStream::Init(RecordingContext *a_pCtx, uint32_t uScreen, const settings::RecordingScreenSettings &Settings)
    664664{
    665665    return initInternal(a_pCtx, uScreen, Settings);
     
    674674 * @param   Settings            Capturing configuration to use for initialization.
    675675 */
    676 int RecordingStream::initInternal(RecordingContext *a_pCtx, uint32_t uScreen, const settings::RecordScreenSettings &Settings)
     676int RecordingStream::initInternal(RecordingContext *a_pCtx, uint32_t uScreen, const settings::RecordingScreenSettings &Settings)
    677677{
    678678    int rc = parseOptionsString(Settings.strOptions);
     
    688688        return rc;
    689689
    690     const bool fVideoEnabled = Settings.isFeatureEnabled(RecordFeature_Video);
    691     const bool fAudioEnabled = Settings.isFeatureEnabled(RecordFeature_Audio);
     690    const bool fVideoEnabled = Settings.isFeatureEnabled(RecordingFeature_Video);
     691    const bool fAudioEnabled = Settings.isFeatureEnabled(RecordingFeature_Audio);
    692692
    693693    if (fVideoEnabled)
     
    699699    switch (this->ScreenSettings.enmDest)
    700700    {
    701         case RecordDestination_File:
     701        case RecordingDestination_File:
    702702        {
    703703            const char *pszFile = this->ScreenSettings.File.strName.c_str();
     
    706706            rc = File.pWEBM->OpenEx(pszFile, &this->File.hFile,
    707707#ifdef VBOX_WITH_AUDIO_RECORDING
    708                                       Settings.isFeatureEnabled(RecordFeature_Audio)
     708                                      Settings.isFeatureEnabled(RecordingFeature_Audio)
    709709                                    ? WebMWriter::AudioCodec_Opus : WebMWriter::AudioCodec_None,
    710710#else
    711711                                      WebMWriter::AudioCodec_None,
    712712#endif
    713                                       Settings.isFeatureEnabled(RecordFeature_Video)
     713                                      Settings.isFeatureEnabled(RecordingFeature_Video)
    714714                                    ? WebMWriter::VideoCodec_VP8 : WebMWriter::VideoCodec_None);
    715715            if (RT_FAILURE(rc))
     
    814814        switch (this->ScreenSettings.enmDest)
    815815        {
    816             case RecordDestination_File:
     816            case RecordingDestination_File:
    817817            {
    818818                if (this->File.pWEBM)
     
    839839    switch (this->ScreenSettings.enmDest)
    840840    {
    841         case RecordDestination_File:
     841        case RecordingDestination_File:
    842842        {
    843843            if (RTFileIsValid(this->File.hFile))
     
    891891        return rc;
    892892
    893     if (this->ScreenSettings.isFeatureEnabled(RecordFeature_Video))
     893    if (this->ScreenSettings.isFeatureEnabled(RecordingFeature_Video))
    894894    {
    895895        int rc2 = unitVideo();
     
    10251025{
    10261026#ifdef VBOX_WITH_AUDIO_RECORDING
    1027     if (this->ScreenSettings.isFeatureEnabled(RecordFeature_Audio))
     1027    if (this->ScreenSettings.isFeatureEnabled(RecordingFeature_Audio))
    10281028    {
    10291029        /* Sanity. */
  • trunk/src/VBox/Main/src-client/SessionImpl.cpp

    r75341 r75361  
    725725}
    726726
    727 HRESULT Session::onRecordChange()
    728 {
    729     LogFlowThisFunc(("\n"));
    730 
    731     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
    732     AssertReturn(mState == SessionState_Locked, VBOX_E_INVALID_VM_STATE);
    733     AssertReturn(mType == SessionType_WriteLock, VBOX_E_INVALID_OBJECT_STATE);
    734 #ifndef VBOX_COM_INPROC_API_CLIENT
    735     AssertReturn(mConsole, VBOX_E_INVALID_OBJECT_STATE);
    736 
    737     return mConsole->i_onRecordChange();
     727HRESULT Session::onRecordingChange()
     728{
     729    LogFlowThisFunc(("\n"));
     730
     731    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
     732    AssertReturn(mState == SessionState_Locked, VBOX_E_INVALID_VM_STATE);
     733    AssertReturn(mType == SessionType_WriteLock, VBOX_E_INVALID_OBJECT_STATE);
     734#ifndef VBOX_COM_INPROC_API_CLIENT
     735    AssertReturn(mConsole, VBOX_E_INVALID_OBJECT_STATE);
     736
     737    return mConsole->i_onRecordingChange();
    738738#else
    739739    return S_OK;
  • trunk/src/VBox/Main/src-server/MachineImpl.cpp

    r75341 r75361  
    359359
    360360        /* Apply record defaults. */
    361         mRecordSettings->i_applyDefaults();
     361        mRecordingSettings->i_applyDefaults();
    362362
    363363        /* Apply network adapters defaults */
     
    19401940}
    19411941
    1942 HRESULT Machine::getRecordSettings(ComPtr<IRecordSettings> &aRecordSettings)
    1943 {
    1944     /* mRecordSettings is constant during life time, no need to lock */
    1945     aRecordSettings = mRecordSettings;
     1942HRESULT Machine::getRecordingSettings(ComPtr<IRecordingSettings> &aRecordingSettings)
     1943{
     1944    /* mRecordingSettings is constant during life time, no need to lock */
     1945    aRecordingSettings = mRecordingSettings;
    19461946
    19471947    return S_OK;
     
    82608260
    82618261    /* create associated record settings object */
    8262     unconst(mRecordSettings).createObject();
    8263     mRecordSettings->init(this);
     8262    unconst(mRecordingSettings).createObject();
     8263    mRecordingSettings->init(this);
    82648264
    82658265    /* create an associated VRDE object (default is disabled) */
     
    83788378    }
    83798379
    8380     if (mRecordSettings)
    8381     {
    8382         mRecordSettings->uninit();
    8383         unconst(mRecordSettings).setNull();
     8380    if (mRecordingSettings)
     8381    {
     8382        mRecordingSettings->uninit();
     8383        unconst(mRecordingSettings).setNull();
    83848384    }
    83858385
     
    88988898        if (FAILED(rc)) return rc;
    88998899
    8900         /* Record settings */
    8901         rc = mRecordSettings->i_loadSettings(data.recordSettings);
     8900        /* Recording settings */
     8901        rc = mRecordingSettings->i_loadSettings(data.recordingSettings);
    89028902        if (FAILED(rc)) return rc;
    89038903
     
    1021710217        if (FAILED(rc)) throw rc;
    1021810218
    10219         /* Record settings (required) */
    10220         rc = mRecordSettings->i_saveSettings(data.recordSettings);
     10219        /* Recording settings (required) */
     10220        rc = mRecordingSettings->i_saveSettings(data.recordingSettings);
    1022110221        if (FAILED(rc)) throw rc;
    1022210222
     
    1172311723        mBIOSSettings->i_rollback();
    1172411724
    11725     if (mRecordSettings && (mData->flModifications & IsModified_Record))
    11726         mRecordSettings->i_rollback();
     11725    if (mRecordingSettings && (mData->flModifications & IsModified_Record))
     11726        mRecordingSettings->i_rollback();
    1172711727
    1172811728    if (mVRDEServer && (mData->flModifications & IsModified_VRDEServer))
     
    1183611836
    1183711837    mBIOSSettings->i_commit();
    11838     mRecordSettings->i_commit();
     11838    mRecordingSettings->i_commit();
    1183911839    mVRDEServer->i_commit();
    1184011840    mAudioAdapter->i_commit();
     
    1208912089
    1209012090    mBIOSSettings->i_copyFrom(aThat->mBIOSSettings);
    12091     mRecordSettings->i_copyFrom(aThat->mRecordSettings);
     12091    mRecordingSettings->i_copyFrom(aThat->mRecordingSettings);
    1209212092    mVRDEServer->i_copyFrom(aThat->mVRDEServer);
    1209312093    mAudioAdapter->i_copyFrom(aThat->mAudioAdapter);
     
    1246312463    unconst(mBIOSSettings).createObject();
    1246412464    mBIOSSettings->init(this, aMachine->mBIOSSettings);
    12465     unconst(mRecordSettings).createObject();
    12466     mRecordSettings->init(this, aMachine->mRecordSettings);
     12465    unconst(mRecordingSettings).createObject();
     12466    mRecordingSettings->init(this, aMachine->mRecordingSettings);
    1246712467    /* create another VRDEServer object that will be mutable */
    1246812468    unconst(mVRDEServer).createObject();
     
    1411614116        return S_OK;
    1411714117
    14118     return directControl->OnRecordChange();
     14118    return directControl->OnRecordingChange();
    1411914119}
    1412014120
     
    1505115051
    1505215052    /* Initialize default record settings. */
    15053     mRecordSettings->i_applyDefaults();
     15053    mRecordingSettings->i_applyDefaults();
    1505415054
    1505515055    /* Initialize default BIOS settings here */
  • trunk/src/VBox/Main/src-server/RecordingScreenSettingsImpl.cpp

    r75360 r75361  
    22/** @file
    33 *
    4  * VirtualBox COM class implementation - Capture settings of one virtual screen.
     4 * VirtualBox COM class implementation - Recording settings of one virtual screen.
    55 */
    66
     
    1717 */
    1818
    19 #define LOG_GROUP LOG_GROUP_MAIN_RECORDSCREENSETTINGS
     19#define LOG_GROUP LOG_GROUP_MAIN_RECORDINGSCREENSETTINGS
    2020#include "LoggingNew.h"
    2121
    22 #include "RecordScreenSettingsImpl.h"
    23 #include "RecordSettingsImpl.h"
     22#include "RecordingScreenSettingsImpl.h"
     23#include "RecordingSettingsImpl.h"
    2424#include "MachineImpl.h"
    2525
     
    3838////////////////////////////////////////////////////////////////////////////////
    3939
    40 struct RecordScreenSettings::Data
     40struct RecordingScreenSettings::Data
    4141{
    4242    Data()
     
    4444    { }
    4545
    46     RecordSettings * const          pParent;
    47     ComObjPtr<RecordScreenSettings> pPeer;
    48     uint32_t                         uScreenId;
     46    RecordingSettings * const          pParent;
     47    ComObjPtr<RecordingScreenSettings> pPeer;
     48    uint32_t                           uScreenId;
    4949
    5050    // use the XML settings structure in the members for simplicity
    51     Backupable<settings::RecordScreenSettings> bd;
     51    Backupable<settings::RecordingScreenSettings> bd;
    5252};
    5353
     
    5555/////////////////////////////////////////////////////////////////////////////
    5656
    57 DEFINE_EMPTY_CTOR_DTOR(RecordScreenSettings)
    58 
    59 HRESULT RecordScreenSettings::FinalConstruct()
     57DEFINE_EMPTY_CTOR_DTOR(RecordingScreenSettings)
     58
     59HRESULT RecordingScreenSettings::FinalConstruct()
    6060{
    6161    return BaseFinalConstruct();
    6262}
    6363
    64 void RecordScreenSettings::FinalRelease()
     64void RecordingScreenSettings::FinalRelease()
    6565{
    6666    uninit();
     
    7676 * @returns COM result indicator
    7777 */
    78 HRESULT RecordScreenSettings::init(RecordSettings *aParent, uint32_t uScreenId, const settings::RecordScreenSettings& data)
     78HRESULT RecordingScreenSettings::init(RecordingSettings *aParent, uint32_t uScreenId, const settings::RecordingScreenSettings& data)
    7979{
    8080    LogFlowThisFuncEnter();
     
    123123 *  it shares data with is destroyed.
    124124 */
    125 HRESULT RecordScreenSettings::init(RecordSettings *aParent, RecordScreenSettings *that)
     125HRESULT RecordingScreenSettings::init(RecordingSettings *aParent, RecordingScreenSettings *that)
    126126{
    127127    LogFlowThisFuncEnter();
     
    166166 *  of the original object passed as an argument.
    167167 */
    168 HRESULT RecordScreenSettings::initCopy(RecordSettings *aParent, RecordScreenSettings *that)
     168HRESULT RecordingScreenSettings::initCopy(RecordingSettings *aParent, RecordingScreenSettings *that)
    169169{
    170170    LogFlowThisFuncEnter();
     
    208208 *  Called either from FinalRelease() or by the parent when it gets destroyed.
    209209 */
    210 void RecordScreenSettings::uninit()
     210void RecordingScreenSettings::uninit()
    211211{
    212212    LogFlowThisFuncEnter();
     
    228228}
    229229
    230 HRESULT RecordScreenSettings::isFeatureEnabled(RecordFeature_T aFeature, BOOL *aEnabled)
    231 {
    232     AutoCaller autoCaller(this);
    233     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    234 
    235     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
    236 
    237     settings::RecordFeatureMap::const_iterator itFeature = m->bd->featureMap.find(aFeature);
     230HRESULT RecordingScreenSettings::isFeatureEnabled(RecordingFeature_T aFeature, BOOL *aEnabled)
     231{
     232    AutoCaller autoCaller(this);
     233    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     234
     235    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
     236
     237    settings::RecordingFeatureMap::const_iterator itFeature = m->bd->featureMap.find(aFeature);
    238238
    239239    *aEnabled = (   itFeature != m->bd->featureMap.end()
     
    243243}
    244244
    245 HRESULT RecordScreenSettings::getId(ULONG *id)
     245HRESULT RecordingScreenSettings::getId(ULONG *id)
    246246{
    247247    AutoCaller autoCaller(this);
     
    255255}
    256256
    257 HRESULT RecordScreenSettings::getEnabled(BOOL *enabled)
     257HRESULT RecordingScreenSettings::getEnabled(BOOL *enabled)
    258258{
    259259    AutoCaller autoCaller(this);
     
    267267}
    268268
    269 HRESULT RecordScreenSettings::setEnabled(BOOL enabled)
     269HRESULT RecordingScreenSettings::setEnabled(BOOL enabled)
    270270{
    271271    AutoCaller autoCaller(this);
     
    275275
    276276    if (!m->pParent->i_canChangeSettings())
    277         return setError(E_INVALIDARG, tr("Cannot change enabled state of screen while capturing is enabled"));
     277        return setError(E_INVALIDARG, tr("Cannot change enabled state of screen while recording is enabled"));
    278278
    279279    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    292292}
    293293
    294 HRESULT RecordScreenSettings::getFeatures(ULONG *aFeatures)
     294HRESULT RecordingScreenSettings::getFeatures(ULONG *aFeatures)
    295295{
    296296    AutoCaller autoCaller(this);
     
    301301    *aFeatures = 0;
    302302
    303     settings::RecordFeatureMap::const_iterator itFeature = m->bd->featureMap.begin();
     303    settings::RecordingFeatureMap::const_iterator itFeature = m->bd->featureMap.begin();
    304304    while (itFeature != m->bd->featureMap.end())
    305305    {
     
    313313}
    314314
    315 HRESULT RecordScreenSettings::setFeatures(ULONG aFeatures)
    316 {
    317     AutoCaller autoCaller(this);
    318     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    319 
    320     if (!m->pParent->i_canChangeSettings())
    321         return setError(E_INVALIDARG, tr("Cannot change features while capturing is enabled"));
     315HRESULT RecordingScreenSettings::setFeatures(ULONG aFeatures)
     316{
     317    AutoCaller autoCaller(this);
     318    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     319
     320    if (!m->pParent->i_canChangeSettings())
     321        return setError(E_INVALIDARG, tr("Cannot change features while recording is enabled"));
    322322
    323323    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    326326    m->bd->featureMap.clear();
    327327
    328     if (aFeatures & RecordFeature_Audio)
    329         m->bd->featureMap[RecordFeature_Audio] = true;
    330     if (aFeatures & RecordFeature_Video)
    331         m->bd->featureMap[RecordFeature_Video] = true;
     328    if (aFeatures & RecordingFeature_Audio)
     329        m->bd->featureMap[RecordingFeature_Audio] = true;
     330    if (aFeatures & RecordingFeature_Video)
     331        m->bd->featureMap[RecordingFeature_Video] = true;
    332332
    333333    alock.release();
     
    336336}
    337337
    338 HRESULT RecordScreenSettings::getDestination(RecordDestination_T *aDestination)
     338HRESULT RecordingScreenSettings::getDestination(RecordingDestination_T *aDestination)
    339339{
    340340    AutoCaller autoCaller(this);
     
    348348}
    349349
    350 HRESULT RecordScreenSettings::setDestination(RecordDestination_T aDestination)
    351 {
    352     AutoCaller autoCaller(this);
    353     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    354 
    355     if (!m->pParent->i_canChangeSettings())
    356         return setError(E_INVALIDARG, tr("Cannot change destination type while capturing is enabled"));
     350HRESULT RecordingScreenSettings::setDestination(RecordingDestination_T aDestination)
     351{
     352    AutoCaller autoCaller(this);
     353    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     354
     355    if (!m->pParent->i_canChangeSettings())
     356        return setError(E_INVALIDARG, tr("Cannot change destination type while recording is enabled"));
    357357
    358358    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    364364}
    365365
    366 HRESULT RecordScreenSettings::getFileName(com::Utf8Str &aFileName)
     366HRESULT RecordingScreenSettings::getFileName(com::Utf8Str &aFileName)
    367367{
    368368    AutoCaller autoCaller(this);
     
    376376}
    377377
    378 HRESULT RecordScreenSettings::setFileName(const com::Utf8Str &aFileName)
    379 {
    380     AutoCaller autoCaller(this);
    381     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    382 
    383     if (!m->pParent->i_canChangeSettings())
    384         return setError(E_INVALIDARG, tr("Cannot change file name while capturing is enabled"));
     378HRESULT RecordingScreenSettings::setFileName(const com::Utf8Str &aFileName)
     379{
     380    AutoCaller autoCaller(this);
     381    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     382
     383    if (!m->pParent->i_canChangeSettings())
     384        return setError(E_INVALIDARG, tr("Cannot change file name while recording is enabled"));
    385385
    386386    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    397397}
    398398
    399 HRESULT RecordScreenSettings::getMaxTime(ULONG *aMaxTimeS)
     399HRESULT RecordingScreenSettings::getMaxTime(ULONG *aMaxTimeS)
    400400{
    401401    AutoCaller autoCaller(this);
     
    409409}
    410410
    411 HRESULT RecordScreenSettings::setMaxTime(ULONG aMaxTimeS)
    412 {
    413     AutoCaller autoCaller(this);
    414     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    415 
    416     if (!m->pParent->i_canChangeSettings())
    417         return setError(E_INVALIDARG, tr("Cannot change maximum time while capturing is enabled"));
     411HRESULT RecordingScreenSettings::setMaxTime(ULONG aMaxTimeS)
     412{
     413    AutoCaller autoCaller(this);
     414    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     415
     416    if (!m->pParent->i_canChangeSettings())
     417        return setError(E_INVALIDARG, tr("Cannot change maximum time while recording is enabled"));
    418418
    419419    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    425425}
    426426
    427 HRESULT RecordScreenSettings::getMaxFileSize(ULONG *aMaxFileSizeMB)
     427HRESULT RecordingScreenSettings::getMaxFileSize(ULONG *aMaxFileSizeMB)
    428428{
    429429    AutoCaller autoCaller(this);
     
    437437}
    438438
    439 HRESULT RecordScreenSettings::setMaxFileSize(ULONG aMaxFileSize)
    440 {
    441     AutoCaller autoCaller(this);
    442     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    443 
    444     if (!m->pParent->i_canChangeSettings())
    445         return setError(E_INVALIDARG, tr("Cannot change maximum file size while capturing is enabled"));
     439HRESULT RecordingScreenSettings::setMaxFileSize(ULONG aMaxFileSize)
     440{
     441    AutoCaller autoCaller(this);
     442    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     443
     444    if (!m->pParent->i_canChangeSettings())
     445        return setError(E_INVALIDARG, tr("Cannot change maximum file size while recording is enabled"));
    446446
    447447    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    453453}
    454454
    455 HRESULT RecordScreenSettings::getOptions(com::Utf8Str &aOptions)
     455HRESULT RecordingScreenSettings::getOptions(com::Utf8Str &aOptions)
    456456{
    457457    AutoCaller autoCaller(this);
     
    465465}
    466466
    467 HRESULT RecordScreenSettings::setOptions(const com::Utf8Str &aOptions)
    468 {
    469     AutoCaller autoCaller(this);
    470     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    471 
    472     if (!m->pParent->i_canChangeSettings())
    473         return setError(E_INVALIDARG, tr("Cannot change options while capturing is enabled"));
     467HRESULT RecordingScreenSettings::setOptions(const com::Utf8Str &aOptions)
     468{
     469    AutoCaller autoCaller(this);
     470    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     471
     472    if (!m->pParent->i_canChangeSettings())
     473        return setError(E_INVALIDARG, tr("Cannot change options while recording is enabled"));
    474474
    475475    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    481481}
    482482
    483 HRESULT RecordScreenSettings::getAudioCodec(RecordAudioCodec_T *aCodec)
     483HRESULT RecordingScreenSettings::getAudioCodec(RecordingAudioCodec_T *aCodec)
    484484{
    485485    AutoCaller autoCaller(this);
     
    493493}
    494494
    495 HRESULT RecordScreenSettings::setAudioCodec(RecordAudioCodec_T aCodec)
    496 {
    497     AutoCaller autoCaller(this);
    498     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    499 
    500     if (!m->pParent->i_canChangeSettings())
    501         return setError(E_INVALIDARG, tr("Cannot change audio codec while capturing is enabled"));
     495HRESULT RecordingScreenSettings::setAudioCodec(RecordingAudioCodec_T aCodec)
     496{
     497    AutoCaller autoCaller(this);
     498    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     499
     500    if (!m->pParent->i_canChangeSettings())
     501        return setError(E_INVALIDARG, tr("Cannot change audio codec while recording is enabled"));
    502502
    503503    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    509509}
    510510
    511 HRESULT RecordScreenSettings::getAudioHz(ULONG *aHz)
     511HRESULT RecordingScreenSettings::getAudioHz(ULONG *aHz)
    512512{
    513513    AutoCaller autoCaller(this);
     
    521521}
    522522
    523 HRESULT RecordScreenSettings::setAudioHz(ULONG aHz)
    524 {
    525     AutoCaller autoCaller(this);
    526     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    527 
    528     if (!m->pParent->i_canChangeSettings())
    529         return setError(E_INVALIDARG, tr("Cannot change audio Hertz rate while capturing is enabled"));
     523HRESULT RecordingScreenSettings::setAudioHz(ULONG aHz)
     524{
     525    AutoCaller autoCaller(this);
     526    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     527
     528    if (!m->pParent->i_canChangeSettings())
     529        return setError(E_INVALIDARG, tr("Cannot change audio Hertz rate while recording is enabled"));
    530530
    531531    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    537537}
    538538
    539 HRESULT RecordScreenSettings::getAudioBits(ULONG *aBits)
     539HRESULT RecordingScreenSettings::getAudioBits(ULONG *aBits)
    540540{
    541541    AutoCaller autoCaller(this);
     
    549549}
    550550
    551 HRESULT RecordScreenSettings::setAudioBits(ULONG aBits)
    552 {
    553     AutoCaller autoCaller(this);
    554     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    555 
    556     if (!m->pParent->i_canChangeSettings())
    557         return setError(E_INVALIDARG, tr("Cannot change audio bits while capturing is enabled"));
     551HRESULT RecordingScreenSettings::setAudioBits(ULONG aBits)
     552{
     553    AutoCaller autoCaller(this);
     554    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     555
     556    if (!m->pParent->i_canChangeSettings())
     557        return setError(E_INVALIDARG, tr("Cannot change audio bits while recording is enabled"));
    558558
    559559    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    565565}
    566566
    567 HRESULT RecordScreenSettings::getAudioChannels(ULONG *aChannels)
     567HRESULT RecordingScreenSettings::getAudioChannels(ULONG *aChannels)
    568568{
    569569    AutoCaller autoCaller(this);
     
    577577}
    578578
    579 HRESULT RecordScreenSettings::setAudioChannels(ULONG aChannels)
    580 {
    581     AutoCaller autoCaller(this);
    582     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    583 
    584     if (!m->pParent->i_canChangeSettings())
    585         return setError(E_INVALIDARG, tr("Cannot change audio channels while capturing is enabled"));
     579HRESULT RecordingScreenSettings::setAudioChannels(ULONG aChannels)
     580{
     581    AutoCaller autoCaller(this);
     582    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     583
     584    if (!m->pParent->i_canChangeSettings())
     585        return setError(E_INVALIDARG, tr("Cannot change audio channels while recording is enabled"));
    586586
    587587    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    593593}
    594594
    595 HRESULT RecordScreenSettings::getVideoCodec(RecordVideoCodec_T *aCodec)
     595HRESULT RecordingScreenSettings::getVideoCodec(RecordingVideoCodec_T *aCodec)
    596596{
    597597    AutoCaller autoCaller(this);
     
    605605}
    606606
    607 HRESULT RecordScreenSettings::setVideoCodec(RecordVideoCodec_T aCodec)
    608 {
    609     AutoCaller autoCaller(this);
    610     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    611 
    612     if (!m->pParent->i_canChangeSettings())
    613         return setError(E_INVALIDARG, tr("Cannot change video codec while capturing is enabled"));
     607HRESULT RecordingScreenSettings::setVideoCodec(RecordingVideoCodec_T aCodec)
     608{
     609    AutoCaller autoCaller(this);
     610    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     611
     612    if (!m->pParent->i_canChangeSettings())
     613        return setError(E_INVALIDARG, tr("Cannot change video codec while recording is enabled"));
    614614
    615615    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    621621}
    622622
    623 HRESULT RecordScreenSettings::getVideoWidth(ULONG *aVideoWidth)
     623HRESULT RecordingScreenSettings::getVideoWidth(ULONG *aVideoWidth)
    624624{
    625625    AutoCaller autoCaller(this);
     
    633633}
    634634
    635 HRESULT RecordScreenSettings::setVideoWidth(ULONG aVideoWidth)
    636 {
    637     AutoCaller autoCaller(this);
    638     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    639 
    640     if (!m->pParent->i_canChangeSettings())
    641         return setError(E_INVALIDARG, tr("Cannot change video width while capturing is enabled"));
     635HRESULT RecordingScreenSettings::setVideoWidth(ULONG aVideoWidth)
     636{
     637    AutoCaller autoCaller(this);
     638    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     639
     640    if (!m->pParent->i_canChangeSettings())
     641        return setError(E_INVALIDARG, tr("Cannot change video width while recording is enabled"));
    642642
    643643    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    649649}
    650650
    651 HRESULT RecordScreenSettings::getVideoHeight(ULONG *aVideoHeight)
     651HRESULT RecordingScreenSettings::getVideoHeight(ULONG *aVideoHeight)
    652652{
    653653    AutoCaller autoCaller(this);
     
    661661}
    662662
    663 HRESULT RecordScreenSettings::setVideoHeight(ULONG aVideoHeight)
    664 {
    665     AutoCaller autoCaller(this);
    666     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    667 
    668     if (!m->pParent->i_canChangeSettings())
    669         return setError(E_INVALIDARG, tr("Cannot change video height while capturing is enabled"));
     663HRESULT RecordingScreenSettings::setVideoHeight(ULONG aVideoHeight)
     664{
     665    AutoCaller autoCaller(this);
     666    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     667
     668    if (!m->pParent->i_canChangeSettings())
     669        return setError(E_INVALIDARG, tr("Cannot change video height while recording is enabled"));
    670670
    671671    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    677677}
    678678
    679 HRESULT RecordScreenSettings::getVideoRate(ULONG *aVideoRate)
     679HRESULT RecordingScreenSettings::getVideoRate(ULONG *aVideoRate)
    680680{
    681681    AutoCaller autoCaller(this);
     
    689689}
    690690
    691 HRESULT RecordScreenSettings::setVideoRate(ULONG aVideoRate)
    692 {
    693     AutoCaller autoCaller(this);
    694     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    695 
    696     if (!m->pParent->i_canChangeSettings())
    697         return setError(E_INVALIDARG, tr("Cannot change video rate while capturing is enabled"));
     691HRESULT RecordingScreenSettings::setVideoRate(ULONG aVideoRate)
     692{
     693    AutoCaller autoCaller(this);
     694    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     695
     696    if (!m->pParent->i_canChangeSettings())
     697        return setError(E_INVALIDARG, tr("Cannot change video rate while recording is enabled"));
    698698
    699699    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    705705}
    706706
    707 HRESULT RecordScreenSettings::getVideoRateControlMode(RecordVideoRateControlMode_T *aMode)
     707HRESULT RecordingScreenSettings::getVideoRateControlMode(RecordVideoRateControlMode_T *aMode)
    708708{
    709709    AutoCaller autoCaller(this);
     
    717717}
    718718
    719 HRESULT RecordScreenSettings::setVideoRateControlMode(RecordVideoRateControlMode_T aMode)
    720 {
    721     AutoCaller autoCaller(this);
    722     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    723 
    724     if (!m->pParent->i_canChangeSettings())
    725         return setError(E_INVALIDARG, tr("Cannot change video rate control mode while capturing is enabled"));
     719HRESULT RecordingScreenSettings::setVideoRateControlMode(RecordVideoRateControlMode_T aMode)
     720{
     721    AutoCaller autoCaller(this);
     722    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     723
     724    if (!m->pParent->i_canChangeSettings())
     725        return setError(E_INVALIDARG, tr("Cannot change video rate control mode while recording is enabled"));
    726726
    727727    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    733733}
    734734
    735 HRESULT RecordScreenSettings::getVideoFPS(ULONG *aVideoFPS)
     735HRESULT RecordingScreenSettings::getVideoFPS(ULONG *aVideoFPS)
    736736{
    737737    AutoCaller autoCaller(this);
     
    745745}
    746746
    747 HRESULT RecordScreenSettings::setVideoFPS(ULONG aVideoFPS)
    748 {
    749     AutoCaller autoCaller(this);
    750     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    751 
    752     if (!m->pParent->i_canChangeSettings())
    753         return setError(E_INVALIDARG, tr("Cannot change video FPS while capturing is enabled"));
     747HRESULT RecordingScreenSettings::setVideoFPS(ULONG aVideoFPS)
     748{
     749    AutoCaller autoCaller(this);
     750    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     751
     752    if (!m->pParent->i_canChangeSettings())
     753        return setError(E_INVALIDARG, tr("Cannot change video FPS while recording is enabled"));
    754754
    755755    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    761761}
    762762
    763 HRESULT RecordScreenSettings::getVideoScalingMethod(RecordVideoScalingMethod_T *aMode)
    764 {
    765     AutoCaller autoCaller(this);
    766     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    767 
    768     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
    769 
    770     *aMode = RecordVideoScalingMethod_None; /** @todo Implement this. */
    771 
    772     return S_OK;
    773 }
    774 
    775 HRESULT RecordScreenSettings::setVideoScalingMethod(RecordVideoScalingMethod_T aMode)
    776 {
    777     AutoCaller autoCaller(this);
    778     if (FAILED(autoCaller.rc())) return autoCaller.rc();
    779 
    780     if (!m->pParent->i_canChangeSettings())
    781         return setError(E_INVALIDARG, tr("Cannot change video rate scaling method while capturing is enabled"));
     763HRESULT RecordingScreenSettings::getVideoScalingMethod(RecordingVideoScalingMethod_T *aMode)
     764{
     765    AutoCaller autoCaller(this);
     766    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     767
     768    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
     769
     770    *aMode = RecordingVideoScalingMethod_None; /** @todo Implement this. */
     771
     772    return S_OK;
     773}
     774
     775HRESULT RecordingScreenSettings::setVideoScalingMethod(RecordingVideoScalingMethod_T aMode)
     776{
     777    AutoCaller autoCaller(this);
     778    if (FAILED(autoCaller.rc())) return autoCaller.rc();
     779
     780    if (!m->pParent->i_canChangeSettings())
     781        return setError(E_INVALIDARG, tr("Cannot change video rate scaling method while recording is enabled"));
    782782
    783783    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    794794 * @returns IPRT status code.
    795795 */
    796 int RecordScreenSettings::i_initInternal(void)
     796int RecordingScreenSettings::i_initInternal(void)
    797797{
    798798    Assert(m);
     
    802802    switch (m->bd->enmDest)
    803803    {
    804         case RecordDestination_File:
     804        case RecordingDestination_File:
    805805        {
    806806            if (m->bd->File.strName.isEmpty())
  • trunk/src/VBox/Main/src-server/RecordingSettingsImpl.cpp

    r75360 r75361  
    1717 */
    1818
    19 #define LOG_GROUP LOG_GROUP_MAIN_RECORDSETTINGS
     19#define LOG_GROUP LOG_GROUP_MAIN_RECORDINGSETTINGS
    2020#include "LoggingNew.h"
    2121
    22 #include "RecordSettingsImpl.h"
    23 #include "RecordScreenSettingsImpl.h"
     22#include "RecordingSettingsImpl.h"
     23#include "RecordingScreenSettingsImpl.h"
    2424#include "MachineImpl.h"
    2525
     
    3737////////////////////////////////////////////////////////////////////////////////
    3838
    39 struct RecordSettings::Data
     39struct RecordingSettings::Data
    4040{
    4141    Data()
     
    4343    { }
    4444
    45     Machine * const           pMachine;
    46     ComObjPtr<RecordSettings> pPeer;
    47     RecordScreenSettingsMap   mapScreenObj;
    48     bool                      fHasMachineLock;
     45    Machine * const              pMachine;
     46    ComObjPtr<RecordingSettings> pPeer;
     47    RecordScreenSettingsMap      mapScreenObj;
     48    bool                         fHasMachineLock;
    4949
    5050    // use the XML settings structure in the members for simplicity
    51     Backupable<settings::RecordSettings> bd;
     51    Backupable<settings::RecordingSettings> bd;
    5252};
    5353
    54 DEFINE_EMPTY_CTOR_DTOR(RecordSettings)
    55 
    56 HRESULT RecordSettings::FinalConstruct()
     54DEFINE_EMPTY_CTOR_DTOR(RecordingSettings)
     55
     56HRESULT RecordingSettings::FinalConstruct()
    5757{
    5858    return BaseFinalConstruct();
    5959}
    6060
    61 void RecordSettings::FinalRelease()
     61void RecordingSettings::FinalRelease()
    6262{
    6363    uninit();
     
    7070 * @returns COM result indicator
    7171 */
    72 HRESULT RecordSettings::init(Machine *aParent)
     72HRESULT RecordingSettings::init(Machine *aParent)
    7373{
    7474    LogFlowThisFuncEnter();
     
    103103 *  it shares data with is destroyed.
    104104 */
    105 HRESULT RecordSettings::init(Machine *aParent, RecordSettings *that)
     105HRESULT RecordingSettings::init(Machine *aParent, RecordingSettings *that)
    106106{
    107107    LogFlowThisFuncEnter();
     
    136136 *  of the original object passed as an argument.
    137137 */
    138 HRESULT RecordSettings::initCopy(Machine *aParent, RecordSettings *that)
     138HRESULT RecordingSettings::initCopy(Machine *aParent, RecordingSettings *that)
    139139{
    140140    LogFlowThisFuncEnter();
     
    168168 *  Called either from FinalRelease() or by the parent when it gets destroyed.
    169169 */
    170 void RecordSettings::uninit()
     170void RecordingSettings::uninit()
    171171{
    172172    LogFlowThisFuncEnter();
     
    194194/////////////////////////////////////////////////////////////////////////////
    195195
    196 HRESULT RecordSettings::getEnabled(BOOL *enabled)
     196HRESULT RecordingSettings::getEnabled(BOOL *enabled)
    197197{
    198198    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    203203}
    204204
    205 HRESULT RecordSettings::setEnabled(BOOL enable)
     205HRESULT RecordingSettings::setEnabled(BOOL enable)
    206206{
    207207    LogFlowThisFuncEnter();
     
    251251}
    252252
    253 HRESULT RecordSettings::getScreens(std::vector<ComPtr<IRecordScreenSettings> > &aRecordScreenSettings)
     253HRESULT RecordingSettings::getScreens(std::vector<ComPtr<IRecordingScreenSettings> > &aRecordScreenSettings)
    254254{
    255255    LogFlowThisFuncEnter();
     
    277277}
    278278
    279 HRESULT RecordSettings::getScreenSettings(ULONG uScreenId, ComPtr<IRecordScreenSettings> &aRecordScreenSettings)
     279HRESULT RecordingSettings::getScreenSettings(ULONG uScreenId, ComPtr<IRecordingScreenSettings> &aRecordScreenSettings)
    280280{
    281281    LogFlowThisFuncEnter();
     
    312312 * @param   data                Recording screen settings to use for that screen.
    313313 */
    314 int RecordSettings::i_createScreenObj(RecordScreenSettingsMap &screenSettingsMap,
    315                                        uint32_t uScreenId, const settings::RecordScreenSettings &data)
     314int RecordingSettings::i_createScreenObj(RecordScreenSettingsMap &screenSettingsMap,
     315                                       uint32_t uScreenId, const settings::RecordingScreenSettings &data)
    316316{
    317317    LogFlowThisFunc(("Screen %RU32\n", uScreenId));
     
    325325    int vrc = VINF_SUCCESS;
    326326
    327     ComObjPtr<RecordScreenSettings> RecordScreenSettings;
    328     HRESULT rc = RecordScreenSettings.createObject();
     327    ComObjPtr<RecordingScreenSettings> recordingScreenSettings;
     328    HRESULT rc = recordingScreenSettings.createObject();
    329329    if (SUCCEEDED(rc))
    330330    {
    331         rc = RecordScreenSettings->init(this, uScreenId, data);
     331        rc = recordingScreenSettings->init(this, uScreenId, data);
    332332        if (SUCCEEDED(rc))
    333333        {
    334334            try
    335335            {
    336                 screenSettingsMap[uScreenId] = RecordScreenSettings;
     336                screenSettingsMap[uScreenId] = recordingScreenSettings;
    337337            }
    338338            catch (std::bad_alloc &)
     
    353353 * @param   uScreenId           ID of screen to remove.
    354354 */
    355 int RecordSettings::i_destroyScreenObj(RecordScreenSettingsMap &screenSettingsMap, uint32_t uScreenId)
     355int RecordingSettings::i_destroyScreenObj(RecordScreenSettingsMap &screenSettingsMap, uint32_t uScreenId)
    356356{
    357357    LogFlowThisFunc(("Screen %RU32\n", uScreenId));
     
    368368    /* Make sure to consume the pointer before the one of the
    369369     * iterator gets released. */
    370     ComObjPtr<RecordScreenSettings> pScreenSettings = itScreen->second;
     370    ComObjPtr<RecordingScreenSettings> pScreenSettings = itScreen->second;
    371371
    372372    screenSettingsMap.erase(itScreen);
     
    383383 * @param   screenSettingsMap   Map to destroy screen settings objects for.
    384384 */
    385 int RecordSettings::i_destroyAllScreenObj(RecordScreenSettingsMap &screenSettingsMap)
     385int RecordingSettings::i_destroyAllScreenObj(RecordScreenSettingsMap &screenSettingsMap)
    386386{
    387387    LogFlowThisFuncEnter();
     
    392392        /* Make sure to consume the pointer before the one of the
    393393         * iterator gets released. */
    394         ComObjPtr<RecordScreenSettings> pScreenSettings = itScreen->second;
     394        ComObjPtr<RecordingScreenSettings> pScreenSettings = itScreen->second;
    395395
    396396        screenSettingsMap.erase(itScreen);
     
    412412 * @note Locks this object for writing.
    413413 */
    414 HRESULT RecordSettings::i_loadSettings(const settings::RecordSettings &data)
     414HRESULT RecordingSettings::i_loadSettings(const settings::RecordingSettings &data)
    415415{
    416416    LogFlowThisFuncEnter();
     
    427427    LogFlowThisFunc(("Data has %zu screens\n", data.mapScreens.size()));
    428428
    429     settings::RecordScreenMap::const_iterator itScreen = data.mapScreens.begin();
     429    settings::RecordingScreenMap::const_iterator itScreen = data.mapScreens.begin();
    430430    while (itScreen != data.mapScreens.end())
    431431    {
     
    457457 * Resets the internal object state by destroying all screen settings objects.
    458458 */
    459 void RecordSettings::i_reset(void)
     459void RecordingSettings::i_reset(void)
    460460{
    461461    LogFlowThisFuncEnter();
     
    472472 * @note Locks this object for reading.
    473473 */
    474 HRESULT RecordSettings::i_saveSettings(settings::RecordSettings &data)
     474HRESULT RecordingSettings::i_saveSettings(settings::RecordingSettings &data)
    475475{
    476476    LogFlowThisFuncEnter();
     
    486486    data = *m->bd.data();
    487487
    488     settings::RecordScreenMap::iterator itScreen = data.mapScreens.begin();
     488    settings::RecordingScreenMap::iterator itScreen = data.mapScreens.begin();
    489489    while (itScreen != data.mapScreens.end())
    490490    {
     
    499499}
    500500
    501 void RecordSettings::i_rollback()
     501void RecordingSettings::i_rollback()
    502502{
    503503    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    505505}
    506506
    507 void RecordSettings::i_commit()
     507void RecordingSettings::i_commit()
    508508{
    509509    /* sanity */
     
    531531}
    532532
    533 void RecordSettings::i_copyFrom(RecordSettings *aThat)
     533void RecordingSettings::i_copyFrom(RecordingSettings *aThat)
    534534{
    535535    AssertReturnVoid(aThat != NULL);
     
    552552}
    553553
    554 void RecordSettings::i_applyDefaults(void)
     554void RecordingSettings::i_applyDefaults(void)
    555555{
    556556    /* sanity */
     
    566566 * Returns the full path to the default video capture file.
    567567 */
    568 int RecordSettings::i_getDefaultFileName(Utf8Str &strFile)
     568int RecordingSettings::i_getDefaultFileName(Utf8Str &strFile)
    569569{
    570570    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    582582 * @returns \c true if the settings can be changed, \c false if not.
    583583 */
    584 bool RecordSettings::i_canChangeSettings(void)
     584bool RecordingSettings::i_canChangeSettings(void)
    585585{
    586586    AutoAnyStateDependency adep(m->pMachine);
     
    598598 * have been changed.
    599599 */
    600 void RecordSettings::i_onSettingsChanged(void)
     600void RecordingSettings::i_onSettingsChanged(void)
    601601{
    602602    LogFlowThisFuncEnter();
     
    613613 * to the number of the machine's configured displays.
    614614 */
    615 int RecordSettings::i_syncToMachineDisplays(void)
     615int RecordingSettings::i_syncToMachineDisplays(void)
    616616{
    617617    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
     
    632632        if (m->mapScreenObj.find(i) == m->mapScreenObj.end())
    633633        {
    634             settings::RecordScreenMap::const_iterator itScreen = m->bd->mapScreens.find(i);
     634            settings::RecordingScreenMap::const_iterator itScreen = m->bd->mapScreens.find(i);
    635635            if (itScreen == m->bd->mapScreens.end())
    636636            {
    637                 settings::RecordScreenSettings defaultScreenSettings; /* Apply default settings. */
     637                settings::RecordingScreenSettings defaultScreenSettings; /* Apply default settings. */
    638638                m->bd->mapScreens[i] = defaultScreenSettings;
    639639            }
  • trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

    r75341 r75361  
    10821082    if (FAILED(rc)) return rc;
    10831083
    1084     unconst(mRecordSettings).createObject();
    1085     rc = mRecordSettings->initCopy(this, pMachine->mRecordSettings);
     1084    unconst(mRecordingSettings).createObject();
     1085    rc = mRecordingSettings->initCopy(this, pMachine->mRecordingSettings);
    10861086    if (FAILED(rc)) return rc;
    10871087
     
    12081208    mBIOSSettings->init(this);
    12091209
    1210     unconst(mRecordSettings).createObject();
    1211     mRecordSettings->init(this);
     1210    unconst(mRecordingSettings).createObject();
     1211    mRecordingSettings->init(this);
    12121212
    12131213    unconst(mVRDEServer).createObject();
  • trunk/src/VBox/Main/xml/Settings.cpp

    r75341 r75361  
    23712371}
    23722372
    2373 RecordScreenSettings::RecordScreenSettings(void)
     2373RecordingScreenSettings::RecordingScreenSettings(void)
    23742374{
    23752375    applyDefaults();
    23762376}
    23772377
    2378 RecordScreenSettings::~RecordScreenSettings()
    2379 {
    2380 
    2381 }
    2382 
    2383 void RecordScreenSettings::applyDefaults(void)
     2378RecordingScreenSettings::~RecordingScreenSettings()
     2379{
     2380
     2381}
     2382
     2383void RecordingScreenSettings::applyDefaults(void)
    23842384{
    23852385    /*
     
    23882388
    23892389    fEnabled            = false;
    2390     enmDest             = RecordDestination_File;
     2390    enmDest             = RecordingDestination_File;
    23912391    ulMaxTimeS          = 0;
    23922392    strOptions          = "";
    23932393    File.ulMaxSizeMB    = 0;
    23942394    File.strName        = "";
    2395     Video.enmCodec      = RecordVideoCodec_VP8;
     2395    Video.enmCodec      = RecordingVideoCodec_VP8;
    23962396    Video.ulWidth       = 1024;
    23972397    Video.ulHeight      = 768;
    23982398    Video.ulRate        = 512;
    23992399    Video.ulFPS         = 25;
    2400     Audio.enmAudioCodec = RecordAudioCodec_Opus;
     2400    Audio.enmAudioCodec = RecordingAudioCodec_Opus;
    24012401    Audio.cBits         = 16;
    24022402    Audio.cChannels     = 2;
    24032403    Audio.uHz           = 22050;
    24042404
    2405     featureMap[RecordFeature_Video] = true;
    2406     featureMap[RecordFeature_Audio] = false;
     2405    featureMap[RecordingFeature_Video] = true;
     2406    featureMap[RecordingFeature_Audio] = false;
    24072407}
    24082408
     
    24102410 * Check if all settings have default values.
    24112411 */
    2412 bool RecordScreenSettings::areDefaultSettings(void) const
     2412bool RecordingScreenSettings::areDefaultSettings(void) const
    24132413{
    24142414    return    fEnabled            == false
    2415            && enmDest             == RecordDestination_File
     2415           && enmDest             == RecordingDestination_File
    24162416           && ulMaxTimeS          == 0
    24172417           && strOptions          == ""
    24182418           && File.ulMaxSizeMB    == 0
    24192419           && File.strName        == ""
    2420            && Video.enmCodec      == RecordVideoCodec_VP8
     2420           && Video.enmCodec      == RecordingVideoCodec_VP8
    24212421           && Video.ulWidth       == 1024
    24222422           && Video.ulHeight      == 768
    24232423           && Video.ulRate        == 512
    24242424           && Video.ulFPS         == 25
    2425            && Audio.enmAudioCodec == RecordAudioCodec_Opus
     2425           && Audio.enmAudioCodec == RecordingAudioCodec_Opus
    24262426           && Audio.cBits         == 16
    24272427           && Audio.cChannels     == 2
     
    24292429}
    24302430
    2431 bool RecordScreenSettings::isFeatureEnabled(RecordFeature_T enmFeature) const
    2432 {
    2433     RecordFeatureMap::const_iterator itFeature = featureMap.find(enmFeature);
     2431bool RecordingScreenSettings::isFeatureEnabled(RecordingFeature_T enmFeature) const
     2432{
     2433    RecordingFeatureMap::const_iterator itFeature = featureMap.find(enmFeature);
    24342434    if (itFeature != featureMap.end())
    24352435        return itFeature->second;
     
    24432443 * machine settings have really changed and thus need to be written out to disk.
    24442444 */
    2445 bool RecordScreenSettings::operator==(const RecordScreenSettings &d) const
     2445bool RecordingScreenSettings::operator==(const RecordingScreenSettings &d) const
    24462446{
    24472447    return    fEnabled            == d.fEnabled
     
    24652465 * Constructor. Needs to set sane defaults which stand the test of time.
    24662466 */
    2467 RecordSettings::RecordSettings()
     2467RecordingSettings::RecordingSettings()
    24682468{
    24692469    applyDefaults();
     
    24732473 * Applies the default settings.
    24742474 */
    2475 void RecordSettings::applyDefaults(void)
     2475void RecordingSettings::applyDefaults(void)
    24762476{
    24772477    fEnabled = false;
     
    24822482    {
    24832483        /* Always add screen 0 to the default configuration. */
    2484         RecordScreenSettings screenSettings; /* Apply default settings for screen 0. */
     2484        RecordingScreenSettings screenSettings; /* Apply default settings for screen 0. */
    24852485        screenSettings.fEnabled = true;       /* Enabled by default. */
    24862486        mapScreens[0] = screenSettings;
     
    24952495 * Check if all settings have default values.
    24962496 */
    2497 bool RecordSettings::areDefaultSettings() const
     2497bool RecordingSettings::areDefaultSettings() const
    24982498{
    24992499    const bool fDefault =    fEnabled          == false
     
    25022502        return false;
    25032503
    2504     RecordScreenMap::const_iterator itScreen = mapScreens.begin();
     2504    RecordingScreenMap::const_iterator itScreen = mapScreens.begin();
    25052505    return    itScreen->first == 0
    25062506           && itScreen->second.areDefaultSettings();
     
    25122512 * machine settings have really changed and thus need to be written out to disk.
    25132513 */
    2514 bool RecordSettings::operator==(const RecordSettings &d) const
     2514bool RecordingSettings::operator==(const RecordingSettings &d) const
    25152515{
    25162516    if (this == &d)
     
    25212521        return false;
    25222522
    2523     RecordScreenMap::const_iterator itScreen = mapScreens.begin();
     2523    RecordingScreenMap::const_iterator itScreen = mapScreens.begin();
    25242524    uint32_t i = 0;
    25252525    while (itScreen != mapScreens.end())
    25262526    {
    2527         RecordScreenMap::const_iterator itScreenThat = d.mapScreens.find(i);
     2527        RecordingScreenMap::const_iterator itScreenThat = d.mapScreens.find(i);
    25282528        if (itScreen->second == itScreenThat->second)
    25292529        {
     
    44094409        else if (pelmHwChild->nameEquals("VideoCapture"))
    44104410        {
    4411             pelmHwChild->getAttributeValue("enabled",   hw.recordSettings.fEnabled);
     4411            pelmHwChild->getAttributeValue("enabled",   hw.recordingSettings.fEnabled);
    44124412
    44134413            /* Right now I don't want to bump the settings version, so just convert the enabled
     
    44184418            /* At the moment we only support one capturing configuration, that is, all screens
    44194419             * have the same configuration. So load/save to/from screen 0. */
    4420             Assert(hw.recordSettings.mapScreens.size()); /* At least screen must be present. */
    4421             RecordScreenSettings &screen0Settings = hw.recordSettings.mapScreens[0];
     4420            Assert(hw.recordingSettings.mapScreens.size()); /* At least screen must be present. */
     4421            RecordingScreenSettings &screen0Settings = hw.recordingSettings.mapScreens[0];
    44224422
    44234423            pelmHwChild->getAttributeValue("maxTime",   screen0Settings.ulMaxTimeS);
     
    44334433            {
    44344434                /* Add screen i to config in any case. */
    4435                 hw.recordSettings.mapScreens[i] = screen0Settings;
     4435                hw.recordingSettings.mapScreens[i] = screen0Settings;
    44364436
    44374437                if (u64VideoCaptureScreens & RT_BIT_64(i)) /* Screen i enabled? */
    4438                     hw.recordSettings.mapScreens[i].fEnabled = true;
     4438                    hw.recordingSettings.mapScreens[i].fEnabled = true;
    44394439            }
    44404440        }
     
    58205820    }
    58215821
    5822     if (m->sv >= SettingsVersion_v1_14 && !hw.recordSettings.areDefaultSettings())
     5822    if (m->sv >= SettingsVersion_v1_14 && !hw.recordingSettings.areDefaultSettings())
    58235823    {
    58245824        xml::ElementNode *pelmVideoCapture = pelmHardware->createChild("VideoCapture");
    58255825
    5826         if (hw.recordSettings.fEnabled)
    5827             pelmVideoCapture->setAttribute("enabled", hw.recordSettings.fEnabled);
     5826        if (hw.recordingSettings.fEnabled)
     5827            pelmVideoCapture->setAttribute("enabled", hw.recordingSettings.fEnabled);
    58285828
    58295829        /* Right now I don't want to bump the settings version, so just convert the enabled
    58305830         * screens to the former uint64t_t bit array and vice versa. */
    58315831        uint64_t u64VideoCaptureScreens = 0;
    5832         RecordScreenMap::const_iterator itScreen = hw.recordSettings.mapScreens.begin();
    5833         while (itScreen != hw.recordSettings.mapScreens.end())
     5832        RecordingScreenMap::const_iterator itScreen = hw.recordingSettings.mapScreens.begin();
     5833        while (itScreen != hw.recordingSettings.mapScreens.end())
    58345834        {
    58355835            if (itScreen->second.fEnabled)
     
    58435843        /* At the moment we only support one capturing configuration, that is, all screens
    58445844         * have the same configuration. So load/save to/from screen 0. */
    5845         Assert(hw.recordSettings.mapScreens.size());
    5846         const RecordScreenMap::const_iterator itScreen0Settings = hw.recordSettings.mapScreens.find(0);
    5847         Assert(itScreen0Settings != hw.recordSettings.mapScreens.end());
     5845        Assert(hw.recordingSettings.mapScreens.size());
     5846        const RecordingScreenMap::const_iterator itScreen0Settings = hw.recordingSettings.mapScreens.find(0);
     5847        Assert(itScreen0Settings != hw.recordingSettings.mapScreens.end());
    58485848
    58495849        if (itScreen0Settings->second.ulMaxTimeS)
     
    74427442            || hardwareMachine.enmLongMode != Hardware::LongMode_Legacy
    74437443            || machineUserData.ovIcon.size() > 0
    7444             || hardwareMachine.recordSettings.fEnabled)
     7444            || hardwareMachine.recordingSettings.fEnabled)
    74457445        {
    74467446            m->sv = SettingsVersion_v1_14;
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette