Changeset 74849 in vbox

Timestamp:

Oct 15, 2018 4:26:52 PM (6 years ago)

Author:

vboxsync

Message:

VideoRec/Main: Let Opus decide which default bitrate to use.

File:

• trunk/src/VBox/Main/src-client/DrvAudioVideoRec.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/DrvAudioVideoRec.cpp

@@ -305 +305 @@
     }
 
-    LogRel2(("VideoRec: Recording audio in %RU16Hz, %RU8 channels, %RU32 bitrate\n", uHz, cChannels, uBitrate));
+    LogRel2(("VideoRec: Recording audio in %RU16Hz, %RU8 channels\n", uHz, cChannels));
 
     int orc;
@@ -317 +317 @@
     AssertPtr(pEnc);
 
-    opus_encoder_ctl(pEnc, OPUS_SET_BITRATE(uBitrate));
-    if (orc != OPUS_OK)
-    {
-        opus_encoder_destroy(pEnc);
-        pEnc = NULL;
-
-        LogRel(("VideoRec: Audio codec failed to set bitrate (%RU32): %s\n", uBitrate, opus_strerror(orc)));
-        return VERR_AUDIO_BACKEND_INIT_FAILED;
+    if (uBitrate) /* Only explicitly set the bitrate if we specified one. Otherwise let Opus decide. */
+    {
+        opus_encoder_ctl(pEnc, OPUS_SET_BITRATE(uBitrate));
+        if (orc != OPUS_OK)
+        {
+            opus_encoder_destroy(pEnc);
+            pEnc = NULL;
+
+            LogRel(("VideoRec: Audio codec failed to set bitrate (%RU32): %s\n", uBitrate, opus_strerror(orc)));
+            return VERR_AUDIO_BACKEND_INIT_FAILED;
+        }
     }
 
@@ -622 +625 @@
     CodecParms.cChannels = 2;                  /** @todo Make this configurable. */
     CodecParms.cBits     = 16;                 /** @todo Make this configurable. */
-    CodecParms.uBitrate  = 196000;             /** @todo Make this configurable. */
+    CodecParms.uBitrate  = 0;                  /* Let Opus decide, based on the number of channels and the input sampling rate. */
 
     int rc = avRecSinkInit(pThis, &pThis->Sink, &ContainerParms, &CodecParms);