Changeset 74729 in vbox

Timestamp:

Oct 10, 2018 3:18:09 AM (6 years ago)

Author:

vboxsync

Message:

VMM/IEM: Nested VMX: bugref:9180 Make sure to update VM-exit qualification for all VM-exits. It must be cleared and isn't
undefined like most other VM-exit read-only information fields.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp.h

@@ -2655 +2655 @@
  * @param   pVCpu           The cross context virtual CPU structure.
  * @param   uExitReason     The VM-exit reason.
+ *
+ * @remarks Make sure VM-exit qualification is updated before calling this
+ *          function!
  */
 IEM_STATIC VBOXSTRICTRC iemVmxVmexit(PVMCPU pVCpu, uint32_t uExitReason)
@@ -3523 +3526 @@
          * instruction length field and let the VM-exit handler update the RIP when appropriate.
          * It will then clear the VM-exit instruction length field before completing the VM-exit.
+         *
+         * The VM-exit qualification must be cleared.
          */
         iemVmxVmcsSetExitInstrLen(pVCpu, cbInstr);
+        iemVmxVmcsSetExitQual(pVCpu, 0);
         return iemVmxVmexit(pVCpu, VMX_EXIT_TPR_BELOW_THRESHOLD);
     }
@@ -5608 +5614 @@
                     iemVmxVmentrySaveForceFlags(pVCpu);
 
+                    /* Initialize the VM-exit qualification field as it MBZ for VM-exits where it isn't specified. */
+                    iemVmxVmcsSetExitQual(pVCpu, 0);
+
                     rc = iemVmxVmentryCheckGuestState(pVCpu, pszInstr);
                     if (RT_SUCCESS(rc))