Changeset 74009 in vbox

Timestamp:

Aug 31, 2018 7:28:56 PM (6 years ago)

Author:

vboxsync

Message:

IPRT/rest: Pass the response object as a parmeter to the api emthods to make sure we avoid all unnecessary object copying. Added rest() method to the response objects so they can be reused. bugref:9167

Location:

trunk

Files:

• include/iprt/cpp/restbase.h (modified) (3 diffs)
• src/VBox/Runtime/common/rest/RTCRestClientApiBase.cpp (modified) (3 diffs)
• src/VBox/Runtime/common/rest/RTCRestClientResponseBase.cpp (modified) (1 diff)

trunk/include/iprt/cpp/restbase.h

@@ -1455 +1455 @@
 
     /**
+     * Resets the object state.
+     */
+    virtual void reset(void);
+
+    /**
      * Prepares the HTTP handle for receiving the response.
      *
@@ -1704 +1709 @@
      * Implements stuff for making an API call.
      *
+     * @returns a_pResponse->getStatus()
      * @param   a_rRequest      Reference to the request object.
      * @param   a_enmHttpMethod The HTTP request method.
@@ -1709 +1715 @@
      * @param   a_pszMethod     The method name, for logging purposes.
      */
-    virtual void doCall(RTCRestClientRequestBase const &a_rRequest, RTHTTPMETHOD a_enmHttpMethod,
-                        RTCRestClientResponseBase *a_pResponse, const char *a_pszMethod);
+    virtual int doCall(RTCRestClientRequestBase const &a_rRequest, RTHTTPMETHOD a_enmHttpMethod,
+                       RTCRestClientResponseBase *a_pResponse, const char *a_pszMethod);
 
 };

trunk/src/VBox/Runtime/common/rest/RTCRestClientApiBase.cpp

@@ -63 +63 @@
 
 
-void RTCRestClientApiBase::doCall(RTCRestClientRequestBase const &a_rRequest, RTHTTPMETHOD a_enmHttpMethod,
-                                  RTCRestClientResponseBase *a_pResponse, const char *a_pszMethod)
+int RTCRestClientApiBase::doCall(RTCRestClientRequestBase const &a_rRequest, RTHTTPMETHOD a_enmHttpMethod,
+                                 RTCRestClientResponseBase *a_pResponse, const char *a_pszMethod)
 {
     LogFlow(("doCall: %s %s\n", a_pszMethod, RTHttpMethodName(a_enmHttpMethod)));
+
+    /*
+     * Reset the response object, allowing reuse of such.
+     */
+    a_pResponse->reset();
 
     /*
@@ -149 +154 @@
                         a_pResponse->receiveFinal();
 
-                        return;
+                        return a_pResponse->getStatus();
                     }
                 }
@@ -158 +163 @@
     a_pResponse->receiveComplete(rc, hHttp);
     RT_NOREF_PV(a_pszMethod);
+
+    return a_pResponse->getStatus();
 }
 

trunk/src/VBox/Runtime/common/rest/RTCRestClientResponseBase.cpp

@@ -84 +84 @@
 
     return *this;
+}
+
+
+void RTCRestClientResponseBase::reset()
+{
+    /* Return to default constructor state. */
+    m_rcStatus = VERR_WRONG_ORDER;
+    m_rcHttp   = VERR_NOT_AVAILABLE;
+    if (m_pErrInfo)
+        deleteErrInfo();
+    m_strContentType.setNull();
 }