Changeset 73886 in vbox

Timestamp:

Aug 25, 2018 9:51:12 AM (6 years ago)

Author:

vboxsync

Message:

IPRT/http: RTHttpDestroy shall return a status. bugref:9167

Location:

trunk

Files:

• include/iprt/http.h (modified) (3 diffs)
• src/VBox/Runtime/generic/http-curl.cpp (modified) (2 diffs)

trunk/include/iprt/http.h

@@ -53 +53 @@
  * Creates a HTTP client instance.
  *
- * @returns iprt status code.
- *
+ * @returns IPRT status code.
  * @param   phHttp      Where to store the HTTP handle.
  */
@@ -62 +61 @@
  * Resets a HTTP client instance.
  *
- * @returns iprt status code.
- *
+ * @returns IPRT status code.
  * @param   hHttp      Handle to the HTTP interface.
  */
@@ -71 +69 @@
  * Destroys a HTTP client instance.
  *
+ * @returns IPRT status code.
  * @param   hHttp       Handle to the HTTP interface.
  */
-RTR3DECL(void) RTHttpDestroy(RTHTTP hHttp);
+RTR3DECL(int) RTHttpDestroy(RTHTTP hHttp);
 
 

trunk/src/VBox/Runtime/generic/http-curl.cpp

@@ -313 +313 @@
 
 
-RTR3DECL(void) RTHttpDestroy(RTHTTP hHttp)
+RTR3DECL(int) RTHttpDestroy(RTHTTP hHttp)
 {
     if (hHttp == NIL_RTHTTP)
-        return;
+        return VINF_SUCCESS;
 
     PRTHTTPINTERNAL pThis = hHttp;
-    RTHTTP_VALID_RETURN_VOID(pThis);
+    RTHTTP_VALID_RETURN(pThis);
 
     Assert(!pThis->fBusy);
@@ -348 +348 @@
 
     curl_global_cleanup();
+
+    return VINF_SUCCESS;
 }