Changeset 71740 in vbox

Timestamp:

Apr 7, 2018 10:08:11 PM (6 years ago)

Author:

vboxsync

Message:

DevHDA: Added a @todo regarding PDMDevHlpPhysRead vs PDMDevHlpPCIPhysWrite in hdaR3CmdSync.

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -729 +729 @@
             Assert(pThis->cbCorbBuf);
 
+/** @todo r=bird: An explanation is required why PDMDevHlpPhysRead is used with
+ *        the CORB and PDMDevHlpPCIPhysWrite with RIRB below.  There are
+ *        similar unexplained inconsistencies in DevHDACommon.cpp. */
             rc = PDMDevHlpPhysRead(pThis->CTX_SUFF(pDevIns), pThis->u64CORBBase, pThis->pu32CorbBuf, pThis->cbCorbBuf);
             Log(("hdaR3CmdSync/CORB: read %RGp LB %#x (%Rrc)\n", pThis->u64CORBBase, pThis->cbCorbBuf, rc));