Changeset 71734 in vbox

Timestamp:

Apr 7, 2018 2:46:01 PM (6 years ago)

Author:

vboxsync

Message:

DevHDACommon: Added review comment on some inexplicable code in hdaTimerSet. Andy?

File:

• trunk/src/VBox/Devices/Audio/DevHDACommon.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DevHDACommon.cpp

@@ -568 +568 @@
 
 #ifdef IN_RING3
+
 # ifdef LOG_ENABLED
 void hdaBDLEDumpAll(PHDASTATE pThis, uint64_t u64BDLBase, uint16_t cBDLE)
@@ -708 +709 @@
     AssertPtr(pThis->pTimer[pStream->u8SD]);
 
-#ifdef VBOX_STRICT
+# ifdef VBOX_STRICT
+    /** @todo r=bird: This looks totally wrong inside \#ifdef VBOX_STRICT,
+     * especially with the comment.  If you're trying to avoid assertions in TM
+     * code, you better say so and explain why it's okay to try bypass it this
+     * way.  If that isn't the case, then I don't know what on earth you're doing
+     * here... */
     const uint64_t tsNow = TMTimerGet(pThis->pTimer[pStream->u8SD]);
 
     if (tsExpireMin < tsNow) /* Make sure to not go backwards in time. */
         tsExpireMin = tsNow;
-#endif
+# endif
 
       int rc2 = TMTimerSet(pThis->pTimer[pStream->u8SD], tsExpireMin);
@@ -720 +726 @@
     return true;
 }
+
 #endif /* IN_RING3 */