Changeset 70474 in vbox

Timestamp:

Jan 7, 2018 9:10:41 AM (7 years ago)

Author:

vboxsync

Message:

FE/Qt: Adding some comments and coding style corrections.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• extensions/QIManagerDialog.cpp (modified) (2 diffs)
• extensions/QISplitter.cpp (modified) (2 diffs)
• globals/UIMessageCenter.h (modified) (1 diff)
• logviewer/UIVMLogViewerFilterPanel.cpp (modified) (8 diffs)
• logviewer/UIVMLogViewerFilterPanel.h (modified) (1 diff)
• selector/UIToolsPaneMachine.cpp (modified) (3 diffs)
• widgets/UIPopupPane.cpp (modified) (2 diffs)
• widgets/UIPopupPaneDetails.cpp (modified) (2 diffs)
• widgets/UIPopupStack.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/extensions/QIManagerDialog.cpp

@@ -195 +195 @@
 void QIManagerDialog::prepareToolBar()
 {
-    if(!m_pWidgetToolbar)
+    if (!m_pWidgetToolbar)
         return;
     /* Enable unified toolbar on macOS: */
@@ -247 +247 @@
         showMaximized();
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/extensions/QISplitter.cpp

@@ -221 +221 @@
                             }
                         }
-                        else if(pEvent->type() == QEvent::MouseMove)
+                        else if (pEvent->type() == QEvent::MouseMove)
                         {
                             /* If we are in the near of the handle or currently
@@ -291 +291 @@
 
 #include "QISplitter.moc"
-

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.h

@@ -427 +427 @@
 
 #endif // __UIMessageCenter_h__
-

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerFilterPanel.cpp

@@ -91 +91 @@
 protected:
 
-    /* Overload the mouseXXXEvent to control how selection is made: */
+    /* Overload the mouseXXXEvent to control how selection is done: */
     virtual void        mouseDoubleClickEvent(QMouseEvent *){}
     virtual void        mouseMoveEvent(QMouseEvent *){}
     virtual void        mousePressEvent(QMouseEvent * event)
     {
-        /* Simulate double mouse click to select a word with a single click. */
+        /* Simulate double mouse click to select a word with a single click: */
         QLineEdit::mouseDoubleClickEvent(event);
     }
+
     virtual void        mouseReleaseEvent(QMouseEvent *){}
     virtual void paintEvent(QPaintEvent *event)
@@ -105 +106 @@
         int clearButtonSize = height();
         m_pClearAllButton->setGeometry(width() - clearButtonSize, 0, clearButtonSize, clearButtonSize);
+        /* If we have a selected term move the m_pRemoveTermButton to the end of the
+           or start of the word (depending on the location of the word within line edit itself: */
         if (hasSelectedText())
         {
@@ -111 +114 @@
             int buttonSize = 16;
             int charWidth = fontMetrics().width('x');
-
             int buttonLeft = cursorRect().right() - 0.5 * charWidth;
-
+            /* If buttonLeft is in far left of the line edit, move the
+               button to left side of the selected word: */
             if (buttonLeft + buttonSize  >=  width() - clearButtonSize)
             {
@@ -119 +122 @@
                 buttonLeft -= (selectionWidth + buttonSize);
             }
-
             m_pRemoveTermButton->setGeometry(buttonLeft, buttonY, buttonSize, buttonSize);
         }
@@ -128 +130 @@
 private slots:
 
-    /* Nofifies the listeners that selected word (filter term) has been removed. */
+    /* Nofifies the listeners that selected word (filter term) has been removed: */
     void sltRemoveFilterTerm()
     {
-        if(!hasSelectedText())
+        if (!hasSelectedText())
             return;
         emit sigFilterTermRemoved(selectedText());
@@ -138 +140 @@
     }
 
-    /* The whole content is removed. Listeners are notified. */
+    /* The whole content is removed. Listeners are notified: */
     void sltClearAll()
     {
-        if(text().isEmpty())
+        /* Check if we have some text to avoid recursive calls: */
+        if (text().isEmpty())
             return;
 
@@ -278 +281 @@
 void UIVMLogViewerFilterPanel::sltAddFilterTerm()
 {
-    if(!m_pFilterComboBox)
-        return;
-    if(m_pFilterComboBox->currentText().isEmpty())
+    if (!m_pFilterComboBox)
+        return;
+    if (m_pFilterComboBox->currentText().isEmpty())
         return;
 
@@ -299 +302 @@
 void UIVMLogViewerFilterPanel::sltClearFilterTerms()
 {
-    if(m_filterTermList.empty())
+    if (m_filterTermList.empty())
         return;
     m_filterTermList.clear();

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerFilterPanel.h

@@ -68 +68 @@
     /** Clear all the filter terms and reset the filtering. */
     void sltClearFilterTerms();
+    /** Executes the necessary code to handle filter's boolean operator change ('And', 'Or'). */
     void sltOperatorButtonChanged(int buttonId);
     void sltRemoveFilterTerm(const QString &termString);
 
 private:
+
     enum FilterOperatorButton{
         AndButton = 0,

trunk/src/VBox/Frontends/VirtualBox/src/selector/UIToolsPaneMachine.cpp

@@ -222 +222 @@
 {
     /* Update snapshots pane is it is open: */
-    if(isToolOpened(ToolTypeMachine_Snapshots))
+    if (isToolOpened(ToolTypeMachine_Snapshots))
     {
         AssertPtrReturnVoid(m_pPaneSnapshots);
@@ -228 +228 @@
     }
     /* Update logviewer pane is it is open: */
-    if(isToolOpened(ToolTypeMachine_LogViewer))
+    if (isToolOpened(ToolTypeMachine_LogViewer))
     {
         AssertPtrReturnVoid(m_pPaneLogViewer);
@@ -320 +320 @@
     }
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIPopupPane.cpp

@@ -128 +128 @@
 
     /* Details-pane: */
-    if(m_pDetailsPane->isVisible())
+    if (m_pDetailsPane->isVisible())
     {
         m_pDetailsPane->move(m_iLayoutMargin,
@@ -537 +537 @@
     }
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIPopupPaneDetails.cpp

@@ -219 +219 @@
         int iNewHeight = m_iMaximumPaneHeight;
         QTextDocument *pTextDocument = m_pTextEdit->document();
-        if(pTextDocument)
+        if (pTextDocument)
         {
             /* Adjust text-edit size: */
@@ -255 +255 @@
     return font;
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIPopupStack.cpp

@@ -342 +342 @@
             /* Search for existing status-bar child: */
             if (QStatusBar *pStatusBar = pMainWindow->findChild<QStatusBar*>())
-                if(pStatusBar->isVisible())
+                if (pStatusBar->isVisible())
                     return pStatusBar->height();
 
@@ -350 +350 @@
     return 0;
 }
-