Changeset 68784 in vbox

Timestamp:

Sep 18, 2017 4:07:33 PM (7 years ago)

Author:

vboxsync

Message:

VMM/IEM: SVM instruction nits.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h (modified) (10 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h

@@ -105 +105 @@
          * Disable the global interrupt flag to prevent interrupts during the 'atomic' world switch.
          */
-        pCtx->hwvirt.svm.fGif = 0;
+        pCtx->hwvirt.svm.fGif = false;
 
         Assert(CPUMSELREG_ARE_HIDDEN_PARTS_VALID(pVCpu, &pCtx->es));
@@ -219 +219 @@
         Assert(!CPUMIsGuestInSvmNestedHwVirtMode(pCtx));
 
+        /*
+         * Restore the subset of force-flags that were preserved.
+         */
+        if (pCtx->hwvirt.fLocalForcedActions)
+        {
+            VMCPU_FF_SET(pVCpu, pCtx->hwvirt.fLocalForcedActions);
+            pCtx->hwvirt.fLocalForcedActions = 0;
+        }
+
         if (RT_SUCCESS(rcStrict))
         {
@@ -490 +499 @@
          */
         pCtx->hwvirt.fLocalForcedActions = pVCpu->fLocalForcedActions & VMCPU_FF_BLOCK_NMIS;
+        VMCPU_FF_CLEAR(pVCpu, VMCPU_FF_BLOCK_NMIS);
 
         /*
@@ -566 +576 @@
          * Clear global interrupt flags to allow interrupts in the guest.
          */
-        pCtx->hwvirt.svm.fGif = 1;
+        pCtx->hwvirt.svm.fGif = true;
 
         /*
@@ -1016 +1026 @@
     IEM_SVM_INSTR_COMMON_CHECKS(pVCpu, vmrun);
 
-    RTGCPHYS const GCPhysVmcb = pVCpu->iem.s.enmEffAddrMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
+    /** @todo Check effective address size using address size prefix. */
+    RTGCPHYS const GCPhysVmcb = pVCpu->iem.s.enmCpuMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
     if (   (GCPhysVmcb & X86_PAGE_4K_OFFSET_MASK)
         || !PGMPhysIsGCPhysNormal(pVCpu->CTX_SUFF(pVM), GCPhysVmcb))
@@ -1079 +1090 @@
     IEM_SVM_INSTR_COMMON_CHECKS(pVCpu, vmload);
 
-    RTGCPHYS const GCPhysVmcb = pVCpu->iem.s.enmEffAddrMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
+    /** @todo Check effective address size using address size prefix. */
+    RTGCPHYS const GCPhysVmcb = pVCpu->iem.s.enmCpuMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
     if (   (GCPhysVmcb & X86_PAGE_4K_OFFSET_MASK)
         || !PGMPhysIsGCPhysNormal(pVCpu->CTX_SUFF(pVM), GCPhysVmcb))
@@ -1134 +1146 @@
     IEM_SVM_INSTR_COMMON_CHECKS(pVCpu, vmsave);
 
-    RTGCPHYS const GCPhysVmcb = pVCpu->iem.s.enmEffAddrMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
+    /** @todo Check effective address size using address size prefix. */
+    RTGCPHYS const GCPhysVmcb = pVCpu->iem.s.enmCpuMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
     if (   (GCPhysVmcb & X86_PAGE_4K_OFFSET_MASK)
         || !PGMPhysIsGCPhysNormal(pVCpu->CTX_SUFF(pVM), GCPhysVmcb))
@@ -1197 +1210 @@
     }
 
-    pCtx->hwvirt.svm.fGif = 0;
+    pCtx->hwvirt.svm.fGif = false;
     iemRegAddToRipAndClearRF(pVCpu, cbInstr);
 
@@ -1227 +1240 @@
     }
 
-    pCtx->hwvirt.svm.fGif = 1;
+    pCtx->hwvirt.svm.fGif = true;
     iemRegAddToRipAndClearRF(pVCpu, cbInstr);
 
@@ -1245 +1258 @@
 {
     PCPUMCTX pCtx = IEM_GET_CTX(pVCpu);
-    RTGCPTR  const GCPtrPage = pVCpu->iem.s.enmEffAddrMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
+    /** @todo Check effective address size using address size prefix. */
+    RTGCPTR  const GCPtrPage = pVCpu->iem.s.enmCpuMode == IEMMODE_64BIT ? pCtx->rax : pCtx->eax;
     /** @todo PGM needs virtual ASID support. */
 #if 0