Changeset 63717 in vbox

Timestamp:

Sep 5, 2016 3:13:48 PM (8 years ago)

Author:

vboxsync

Message:

Audio/DrvAudio: Only try to re-initialize once, and after that the backend has to tell us when to try again.

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -1024 +1024 @@
         if (pHstStream->fStatus & PDMAUDIOSTRMSTS_FLAG_PENDING_REINIT)
         {
+            /* Remove the pending re-init flag in any case, regardless whether the actual re-initialization succeeded
+             * or not. If it failed, the backend needs to notify us again to try again at some later point in time. */
+            pHstStream->fStatus &= ~PDMAUDIOSTRMSTS_FLAG_PENDING_REINIT;
+
             rc = drvAudioStreamReInitInternal(pThis, pStream);
             if (RT_FAILURE(rc))
                 break;
-
-            /* On success, remove pending re-init flag. */
-            pHstStream->fStatus &= ~PDMAUDIOSTRMSTS_FLAG_PENDING_REINIT;
         }
 
@@ -1134 +1135 @@
         if (pHstStream->fStatus & PDMAUDIOSTRMSTS_FLAG_PENDING_REINIT)
         {
+            /* Remove the pending re-init flag in any case, regardless whether the actual re-initialization succeeded
+             * or not. If it failed, the backend needs to notify us again to try again at some later point in time. */
+            pHstStream->fStatus &= ~PDMAUDIOSTRMSTS_FLAG_PENDING_REINIT;
+
             rc = drvAudioStreamReInitInternal(pThis, pStream);
             if (RT_FAILURE(rc))
                 break;
-
-            /* On success, remove pending re-init flag. */
-            pHstStream->fStatus &= ~PDMAUDIOSTRMSTS_FLAG_PENDING_REINIT;
         }