Changeset 63676 in vbox

Timestamp:

Aug 31, 2016 4:17:19 PM (8 years ago)

Author:

vboxsync

Message:

NAT: soread - errno is valid only when syscall indicates failure, so
set saved sockerr to 0 on success (because POLA).

File:

• trunk/src/VBox/Devices/Network/slirp/socket.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -322 +322 @@
     nn = recv(so->s, iov[0].iov_base, iov[0].iov_len, (so->so_tcpcb->t_force? MSG_OOB:0));
 #endif
-    sockerr = errno;  /* save it, as it may be clobbered by logging */
+    if (nn < 0)
+        sockerr = errno; /* save it, as it may be clobbered by logging */
+    else
+        sockerr = 0;
+
     Log2(("%s: read(1) nn = %d bytes\n", RT_GCC_EXTENSION __PRETTY_FUNCTION__, nn));
     Log2(("%s: so = %R[natsock] so->so_snd = %R[sbuf]\n", RT_GCC_EXTENSION __PRETTY_FUNCTION__, so, sb));