- Timestamp:
- Aug 16, 2016 2:04:28 PM (8 years ago)
- Location:
- trunk/src/VBox/Main
- Files:
-
- 30 edited
-
src-all/DisplayUtils.cpp (modified) (3 diffs)
-
src-all/EventImpl.cpp (modified) (1 diff)
-
src-client/ConsoleImpl2.cpp (modified) (4 diffs)
-
src-client/ConsoleVRDPServer.cpp (modified) (10 diffs)
-
src-client/DisplayImpl.cpp (modified) (4 diffs)
-
src-client/DisplayImplLegacy.cpp (modified) (5 diffs)
-
src-client/DrvAudioVideoRec.cpp (modified) (5 diffs)
-
src-client/HGCM.cpp (modified) (1 diff)
-
src-client/RemoteUSBBackend.cpp (modified) (2 diffs)
-
src-client/UsbCardReader.cpp (modified) (5 diffs)
-
src-client/UsbWebcamInterface.cpp (modified) (1 diff)
-
src-server/ApplianceImpl.cpp (modified) (2 diffs)
-
src-server/ApplianceImplExport.cpp (modified) (3 diffs)
-
src-server/ApplianceImplImport.cpp (modified) (5 diffs)
-
src-server/HostImpl.cpp (modified) (1 diff)
-
src-server/MachineImpl.cpp (modified) (8 diffs)
-
src-server/MediumImpl.cpp (modified) (2 diffs)
-
src-server/NetworkAdapterImpl.cpp (modified) (1 diff)
-
src-server/Performance.cpp (modified) (1 diff)
-
src-server/PerformanceImpl.cpp (modified) (1 diff)
-
src-server/SnapshotImpl.cpp (modified) (3 diffs)
-
src-server/VRDEServerImpl.cpp (modified) (2 diffs)
-
src-server/VirtualBoxImpl.cpp (modified) (1 diff)
-
src-server/darwin/PerformanceDarwin.cpp (modified) (1 diff)
-
src-server/freebsd/PerformanceFreeBSD.cpp (modified) (1 diff)
-
src-server/generic/USBProxyBackendUsbIp.cpp (modified) (2 diffs)
-
src-server/linux/PerformanceLinux.cpp (modified) (1 diff)
-
src-server/win/NetIf-win.cpp (modified) (8 diffs)
-
webservice/vboxweb.cpp (modified) (2 diffs)
-
xml/ovfreader.cpp (modified) (2 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/src/VBox/Main/src-all/DisplayUtils.cpp
r62485 r63563 28 28 LogFlowFunc(("u32Type = %d [%s]\n", u32Type, strStateFilePath.c_str())); 29 29 30 /* @todo cache read data */30 /** @todo cache read data */ 31 31 if (strStateFilePath.isEmpty()) 32 32 { … … 139 139 void freeSavedDisplayScreenshot(uint8_t *pu8Data) 140 140 { 141 /* @todo not necessary when caching is implemented. */141 /** @todo not necessary when caching is implemented. */ 142 142 RTMemFree(pu8Data); 143 143 } … … 149 149 LogFlowFunc(("u32ScreenId = %d [%s]\n", u32ScreenId, strStateFilePath.c_str())); 150 150 151 /* @todo cache read data */151 /** @todo cache read data */ 152 152 if (strStateFilePath.isEmpty()) 153 153 { -
trunk/src/VBox/Main/src-all/EventImpl.cpp
r61774 r63563 210 210 // must drop lock while waiting, because setProcessed() needs synchronization. 211 211 alock.release(); 212 /* @todo:maybe while loop for spurious wakeups? */212 /** @todo maybe while loop for spurious wakeups? */ 213 213 int vrc = ::RTSemEventWait(m->mWaitEvent, aTimeout); 214 214 AssertMsg(RT_SUCCESS(vrc) || vrc == VERR_TIMEOUT || vrc == VERR_INTERRUPTED, -
trunk/src/VBox/Main/src-client/ConsoleImpl2.cpp
r63423 r63563 612 612 * requires RAM preallocation. 613 613 */ 614 /** @todo :check if we can lift this requirement */614 /** @todo check if we can lift this requirement */ 615 615 CFGMR3RemoveValue(pRoot, "RamPreAlloc"); 616 616 InsertConfigInteger(pRoot, "RamPreAlloc", 1); … … 1535 1535 */ 1536 1536 BOOL fLpcEnabled; 1537 /** @todo :implement appropriate getter */1537 /** @todo implement appropriate getter */ 1538 1538 fLpcEnabled = fOsXGuest || (chipsetType == ChipsetType_ICH9); 1539 1539 if (fLpcEnabled) … … 3632 3632 { 3633 3633 LONG64 winId = 0; 3634 /* @todo deal with multimonitor setup */3634 /** @todo deal with multimonitor setup */ 3635 3635 Assert(cMonitorCount == 1); 3636 3636 hrc = pFramebuffer->COMGETTER(WinId)(&winId); … … 3849 3849 mUSBStorageDevices.push_back(UsbMsd); 3850 3850 3851 /** @todo :No LED after hotplugging. */3851 /** @todo No LED after hotplugging. */ 3852 3852 /* Attach the status driver */ 3853 3853 Assert(cLedUsb >= 8); -
trunk/src/VBox/Main/src-client/ConsoleVRDPServer.cpp
r63240 r63563 789 789 ) 790 790 { 791 /* @todo these features should be per client. */791 /** @todo these features should be per client. */ 792 792 NOREF(pFeature->u32ClientId); 793 793 … … 1842 1842 Assert(p->pThis); 1843 1843 1844 /* @todo find out what to do if size changes to 0x0 from non zero */1844 /** @todo find out what to do if size changes to 0x0 from non zero */ 1845 1845 if (w == 0 || h == 0) 1846 1846 { … … 1892 1892 { 1893 1893 /* Create a new bitmap handle. */ 1894 uint32_t u32ScreenId = 0; /* @todo clip to corresponding screens.1894 uint32_t u32ScreenId = 0; /** @todo clip to corresponding screens. 1895 1895 * Clipping can be done here or in VRDP server. 1896 1896 * If VRDP does clipping, then uScreenId parameter … … 2171 2171 if (u32StreamId != 0) 2172 2172 { 2173 p->fCreated = true; // @todo not needed?2173 p->fCreated = true; /// @todo not needed? 2174 2174 } 2175 2175 else … … 2331 2331 if (RT_SUCCESS(rc)) 2332 2332 { 2333 /* @todo contexts should be in a list for accounting. */2333 /** @todo contexts should be in a list for accounting. */ 2334 2334 *ppvChannel = pHostChCtx; 2335 2335 } … … 2536 2536 } 2537 2537 2538 /* @todo these defines must be in a header, which is used by guest component as well. */2538 /** @todo these defines must be in a header, which is used by guest component as well. */ 2539 2539 #define VBOX_TSMF_HCH_CREATE_ACCEPTED (VBOX_HOST_CHANNEL_EVENT_USER + 0) 2540 2540 #define VBOX_TSMF_HCH_CREATE_DECLINED (VBOX_HOST_CHANNEL_EVENT_USER + 1) … … 2875 2875 else if (pHeader->u16EventId == VRDEINPUT_EVENTID_DISMISS_HOVERING_CONTACT) 2876 2876 { 2877 /* @todo */2877 /** @todo */ 2878 2878 } 2879 2879 else … … 3939 3939 HRESULT VRDEServerInfo::get##_aName(_aType *a##_aName) \ 3940 3940 { \ 3941 /* todo:Not sure if a AutoReadLock would be sufficient. */ \3941 /** @todo Not sure if a AutoReadLock would be sufficient. */ \ 3942 3942 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); \ 3943 3943 \ … … 3957 3957 HRESULT VRDEServerInfo::get##_aName(_aType *a##_aName) \ 3958 3958 { \ 3959 /* todo:Not sure if a AutoReadLock would be sufficient. */ \3959 /** @todo Not sure if a AutoReadLock would be sufficient. */ \ 3960 3960 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); \ 3961 3961 \ … … 3976 3976 HRESULT VRDEServerInfo::get##_aName(_aType &a##_aName) \ 3977 3977 { \ 3978 /* todo:Not sure if a AutoReadLock would be sufficient. */ \3978 /** @todo Not sure if a AutoReadLock would be sufficient. */ \ 3979 3979 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); \ 3980 3980 \ -
trunk/src/VBox/Main/src-client/DisplayImpl.cpp
r63418 r63563 942 942 if (!maFramebuffers[uScreenId].pFramebuffer.isNull()) 943 943 { 944 HRESULT hr = maFramebuffers[uScreenId].pFramebuffer->NotifyChange(uScreenId, 0, 0, w, h); /* @todo origin */944 HRESULT hr = maFramebuffers[uScreenId].pFramebuffer->NotifyChange(uScreenId, 0, 0, w, h); /** @todo origin */ 945 945 LogFunc(("NotifyChange hr %08X\n", hr)); 946 946 NOREF(hr); … … 2586 2586 rc = setError(VBOX_E_IPRT_ERROR, 2587 2587 tr("Could not draw to the screen (%Rrc)"), rcVBox); 2588 // @todo2588 /// @todo 2589 2589 // else 2590 2590 // { … … 3951 3951 pHdrUnconst->y -= (int16_t)pFBInfo->yOrigin; 3952 3952 3953 /* @todo new SendUpdate entry which can get a separate cmd header or coords. */3953 /** @todo new SendUpdate entry which can get a separate cmd header or coords. */ 3954 3954 pThis->mParent->i_consoleVRDPServer()->SendUpdate(uScreenId, pCmd, (uint32_t)cbCmd); 3955 3955 … … 3966 3966 DISPLAYFBINFO *pFBInfo = &pThis->maFramebuffers[uScreenId]; 3967 3967 3968 /* @todo handleFramebufferUpdate (uScreenId,3968 /** @todo handleFramebufferUpdate (uScreenId, 3969 3969 * x - pThis->maFramebuffers[uScreenId].xOrigin, 3970 3970 * y - pThis->maFramebuffers[uScreenId].yOrigin, -
trunk/src/VBox/Main/src-client/DisplayImplLegacy.cpp
r63244 r63563 163 163 if (pFBInfo->fDefaultFormat) 164 164 { 165 // @todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer165 /// @todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer 166 166 prgn->pPort->pfnUpdateDisplayRect(prgn->pPort, phdr->x, phdr->y, phdr->w, phdr->h); 167 167 prgn->pDisplay->i_handleDisplayUpdate(uScreenId, phdr->x, phdr->y, phdr->w, phdr->h); … … 181 181 if (!pFBInfo->fDefaultFormat && w != 0 && h != 0) 182 182 { 183 // @todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer183 /// @todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer 184 184 prgn->pPort->pfnUpdateDisplayRect(prgn->pPort, pDirtyRect->xLeft, pDirtyRect->yTop, w, h); 185 185 prgn->pDisplay->i_handleDisplayUpdate(uScreenId, pDirtyRect->xLeft, pDirtyRect->yTop, w, h); … … 804 804 pu8 += u32VRAMSize - VBOX_VIDEO_ADAPTER_INFORMATION_SIZE; 805 805 806 // @todo806 /// @todo 807 807 uint8_t *pu8End = pu8 + VBOX_VIDEO_ADAPTER_INFORMATION_SIZE; 808 808 … … 864 864 case VBOX_VIDEO_QCI32_OFFSCREEN_HEAP_SIZE: 865 865 { 866 /* @todo make configurable. */866 /** @todo make configurable. */ 867 867 pConf32->u32Value = _1M; 868 868 } break; … … 908 908 pu8 += pFBInfo->u32Offset + pFBInfo->u32MaxFramebufferSize; 909 909 910 // @todo910 /// @todo 911 911 uint8_t *pu8End = pu8 + pFBInfo->u32InformationSize; 912 912 -
trunk/src/VBox/Main/src-client/DrvAudioVideoRec.cpp
r63534 r63563 43 43 #define CA_STATUS_IN_UNINIT UINT32_C(3) /* The device is currently uninitializing */ 44 44 45 // @todo move t_sample as a PDM interface45 /// @todo move t_sample as a PDM interface 46 46 //typedef struct { int mute; uint32_t r; uint32_t l; } volume_t; 47 47 … … 437 437 * we are filling this buffer with the audio data available from VRDP. Here we are reading it 438 438 */ 439 /* todo do I need to introduce a thread to fill the buffer in fltRecordcallback. So that439 /** @todo do I need to introduce a thread to fill the buffer in fltRecordcallback. So that 440 440 * filling is in separate thread and the reading of that buffer is in separate thread 441 441 */ … … 573 573 if (enmStreamCmd == PDMAUDIOSTREAMCMD_ENABLE) 574 574 { 575 // @todo if (!pVRDEVoice->fIsInit)575 /// @todo if (!pVRDEVoice->fIsInit) 576 576 // RTCircBufReset(pVRDEVoice->pRecordedVoiceBuf); 577 577 pVRDEVoice->fIsInit = 1; … … 704 704 //if (iSampleHz && iSampleHz != pVRDEVoice->pHostVoiceIn.Props.uFrequency) 705 705 { 706 /* @todo if the above condition is false then pVRDEVoice->uFrequency will remain 0 */706 /** @todo if the above condition is false then pVRDEVoice->uFrequency will remain 0 */ 707 707 /*mpDrv->pUpPort->pfnPrepareAudioConversion(mpDrv->pUpPort, iSampleHz, 708 708 pVRDEVoice->pHostVoiceIn.Props.uFrequency, … … 737 737 738 738 /* count of rate adjusted samples */ 739 pVRDEVoice->uFrequency = 22100; /* @todo handle this. How pVRDEVoice will get proper value */739 pVRDEVoice->uFrequency = 22100; /** @todo handle this. How pVRDEVoice will get proper value */ 740 740 cConvertedSamples = (cSamples * pVRDEVoice->pHostVoiceIn.Props.uHz) / pVRDEVoice->uFrequency; 741 741 vrdeReallocRateAdjSampleBuf(pVRDEVoice, cConvertedSamples); -
trunk/src/VBox/Main/src-client/HGCM.cpp
r62485 r63563 1145 1145 1146 1146 #ifdef VBOX_WITH_CRHGSMI 1147 /* @todo:could this actually happen that the service is destroyed on ReleaseService? */1147 /** @todo could this actually happen that the service is destroyed on ReleaseService? */ 1148 1148 HGCMService *pNextSvc = pSvc->m_pSvcNext; 1149 1149 while (pSvc->m_cHandleAcquires) -
trunk/src/VBox/Main/src-client/RemoteUSBBackend.cpp
r63256 r63563 134 134 static REMOTEUSBQURB *qurbAlloc(PREMOTEUSBDEVICE pDevice) 135 135 { 136 /* @todo reuse URBs. */136 /** @todo reuse URBs. */ 137 137 REMOTEUSBQURB *pQURB = (REMOTEUSBQURB *)RTMemAllocZ (sizeof (REMOTEUSBQURB)); 138 138 … … 563 563 { 564 564 u32DataLen = 8; /* 8 byte header. */ 565 // u32DataLen = u32Len; // @todo do messages need all information?565 // u32DataLen = u32Len; /// @todo do messages need all information? 566 566 } 567 567 } break; -
trunk/src/VBox/Main/src-client/UsbCardReader.cpp
r63239 r63563 374 374 pvUser)); 375 375 PUSBCARDREADER pThis = RT_FROM_MEMBER(pInterface, USBCARDREADER, ICardReaderDown); 376 /* @todo Device calls this when the driver already destroyed. */376 /** @todo Device calls this when the driver already destroyed. */ 377 377 if (pThis->hReqQCardReaderCmd == NIL_RTREQQUEUE) 378 378 { … … 751 751 Assert(cbData == sizeof(VRDESCARDNOTIFYDETACH)); 752 752 753 /* @todo Just free. There should be no pending requests, because VRDP cancels them. */753 /** @todo Just free. There should be no pending requests, because VRDP cancels them. */ 754 754 RTMemFree(m_pRemote); 755 755 m_pRemote = NULL; … … 819 819 i, pRsp->apszNames[i])); 820 820 821 /* @todo only the first reader is supported. */821 /** @todo only the first reader is supported. */ 822 822 if (i != 0) 823 823 { … … 873 873 i, pRsp->aReaderStates[i].u32EventState)); 874 874 875 /* @todo only the first reader is supported. */875 /** @todo only the first reader is supported. */ 876 876 if (i != 0) 877 877 { … … 1107 1107 pu8RecvBuffer = pRsp->pu8RecvBuffer; 1108 1108 cbRecvBuffer = pRsp->u32RecvLength; 1109 /* @todo pioRecvPci */1109 /** @todo pioRecvPci */ 1110 1110 } 1111 1111 } -
trunk/src/VBox/Main/src-client/UsbWebcamInterface.cpp
r63259 r63563 220 220 LogFlowFunc(("DETACH[%d,%d]\n", p->deviceHandle.u32ClientId, p->deviceHandle.u32DeviceId)); 221 221 222 /* @todo */222 /** @todo */ 223 223 if (mpRemote) 224 224 { -
trunk/src/VBox/Main/src-server/ApplianceImpl.cpp
r63184 r63563 902 902 char *tmpName = RTStrDup(aName.c_str()); 903 903 int i = 1; 904 /** @todo :Maybe too cost-intensive; try to find a lighter way */904 /** @todo Maybe too cost-intensive; try to find a lighter way */ 905 905 while (mVirtualBox->FindMachine(Bstr(tmpName).raw(), &machine) != VBOX_E_OBJECT_NOT_FOUND) 906 906 { … … 922 922 /* Check if the file exists or if a file with this path is registered 923 923 * already */ 924 /** @todo :Maybe too cost-intensive; try to find a lighter way */924 /** @todo Maybe too cost-intensive; try to find a lighter way */ 925 925 while ( RTPathExists(tmpName) 926 926 || mVirtualBox->OpenMedium(Bstr(tmpName).raw(), DeviceType_HardDisk, AccessMode_ReadWrite, -
trunk/src/VBox/Main/src-server/ApplianceImplExport.cpp
r63184 r63563 1006 1006 rc = pSourceDisk->COMGETTER(LogicalSize)(&cbCapacity); 1007 1007 if (FAILED(rc)) throw rc; 1008 // Todo r=poetzsch: wrong it is reported in bytes ...1008 /// @todo r=poetzsch: wrong it is reported in bytes ... 1009 1009 // capacity is reported in megabytes, so... 1010 1010 //cbCapacity *= _1M; … … 1019 1019 pelmFile->setAttribute("ovf:href", strTargetFileNameOnly); 1020 1020 pelmFile->setAttribute("ovf:id", strFileRef); 1021 // Todo:the actual size is not available at this point of time,1021 /// @todo the actual size is not available at this point of time, 1022 1022 // cause the disk will be compressed. The 1.0 standard says this is 1023 1023 // optional! 1.1 isn't fully clear if the "gzip" format is used. … … 2319 2319 { 2320 2320 writeLock.acquire(); 2321 // Todo:file deletion on error? If not, we can remove that whole try/catch block.2321 /// @todo file deletion on error? If not, we can remove that whole try/catch block. 2322 2322 throw rc3; 2323 2323 } -
trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp
r63171 r63563 114 114 HRESULT Appliance::interpret() 115 115 { 116 // @todo:116 /// @todo 117 117 // - don't use COM methods but the methods directly (faster, but needs appropriate 118 118 // locking of that objects itself (s. HardDisk)) … … 521 521 if (cIDEused < 4) 522 522 { 523 // @todo:figure out the IDE types523 /// @todo figure out the IDE types 524 524 /* Use PIIX4 as default */ 525 525 Utf8Str strType = "PIIX4"; … … 547 547 if (cSATAused < 1) 548 548 { 549 // @todo:figure out the SATA types549 /// @todo figure out the SATA types 550 550 /* We only support a plain AHCI controller, so use them always */ 551 551 pNewDesc->i_addEntry(VirtualSystemDescriptionType_HardDiskControllerSATA, … … 637 637 Utf8Str vdf = Utf8Str(bstrFormatName); 638 638 639 // @todo:639 /// @todo 640 640 // - figure out all possible vmdk formats we also support 641 641 // - figure out if there is a url specifier for vhd already … … 4071 4071 std::list<VirtualSystemDescriptionEntry*> vsdeAudioAdapter = 4072 4072 vsdescThis->i_findByType(VirtualSystemDescriptionType_SoundCard); 4073 /* @todo:we support one audio adapter only */4073 /** @todo we support one audio adapter only */ 4074 4074 if (!vsdeAudioAdapter.empty()) 4075 4075 stack.strAudioAdapter = vsdeAudioAdapter.front()->strVBoxCurrent; -
trunk/src/VBox/Main/src-server/HostImpl.cpp
r63423 r63563 703 703 if (hr != S_OK) 704 704 { 705 /* TODO:try to install the netflt from here */705 /** @todo try to install the netflt from here */ 706 706 } 707 707 # endif -
trunk/src/VBox/Main/src-server/MachineImpl.cpp
r63460 r63563 757 757 758 758 /* commit all changes made during loading the settings file */ 759 i_commit(); // @todo r=dj why do we need a commit during init?!? this is very expensive759 i_commit(); /// @todo r=dj why do we need a commit during init?!? this is very expensive 760 760 /// @todo r=klaus for some reason the settings loading logic backs up 761 761 // the settings, and therefore a commit is needed. Should probably be changed. … … 2606 2606 HRESULT Machine::setSnapshotFolder(const com::Utf8Str &aSnapshotFolder) 2607 2607 { 2608 /* @todo (r=dmik):2608 /** @todo (r=dmik): 2609 2609 * 1. Allow to change the name of the snapshot folder containing snapshots 2610 2610 * 2. Rename the folder on disk instead of just changing the property … … 3078 3078 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); 3079 3079 3080 /* @todo deal with running state change. */3080 /** @todo deal with running state change. */ 3081 3081 HRESULT rc = i_checkStateDependency(MutableOrSavedOrRunningStateDep); 3082 3082 if (FAILED(rc)) return rc; … … 3100 3100 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); 3101 3101 3102 /* @todo deal with running state change. */3102 /** @todo deal with running state change. */ 3103 3103 HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep); 3104 3104 if (FAILED(rc)) return rc; … … 3122 3122 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); 3123 3123 3124 /* @todo deal with running state change. */3124 /** @todo deal with running state change. */ 3125 3125 HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep); 3126 3126 if (FAILED(rc)) return rc; … … 3145 3145 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); 3146 3146 3147 /* @todo deal with running state change. */3147 /** @todo deal with running state change. */ 3148 3148 HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep); 3149 3149 if (FAILED(rc)) return rc; … … 3168 3168 AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS); 3169 3169 3170 /* @todo deal with running state change. */3170 /** @todo deal with running state change. */ 3171 3171 HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep); 3172 3172 if (FAILED(rc)) return rc; … … 10601 10601 10602 10602 mData->pMachineConfigFile->fAborted = (mData->mMachineState == MachineState_Aborted); 10603 // @todo live migration mData->pMachineConfigFile->fTeleported = (mData->mMachineState == MachineState_Teleported);10603 /// @todo live migration mData->pMachineConfigFile->fTeleported = (mData->mMachineState == MachineState_Teleported); 10604 10604 } 10605 10605 -
trunk/src/VBox/Main/src-server/MediumImpl.cpp
r63418 r63563 3950 3950 bool fRemove = false; 3951 3951 3952 // @todo r=klaus eliminate this code, replace it by using find.3952 /// @todo r=klaus eliminate this code, replace it by using find. 3953 3953 for (GuidList::iterator it = m->llRegistryIDs.begin(); 3954 3954 it != m->llRegistryIDs.end(); … … 4006 4006 bool Medium::i_isInRegistry(const Guid &id) 4007 4007 { 4008 // @todo r=klaus eliminate this code, replace it by using find.4008 /// @todo r=klaus eliminate this code, replace it by using find. 4009 4009 for (GuidList::const_iterator it = m->llRegistryIDs.begin(); 4010 4010 it != m->llRegistryIDs.end(); -
trunk/src/VBox/Main/src-server/NetworkAdapterImpl.cpp
r62363 r63563 1296 1296 mlock.release(); 1297 1297 1298 /* TODO:changeAdapter=???. */1298 /** @todo changeAdapter=???. */ 1299 1299 mParent->i_onNetworkAdapterChange(this, FALSE); 1300 1300 } -
trunk/src/VBox/Main/src-server/Performance.cpp
r63174 r63563 248 248 if (mGuest) 249 249 { 250 /* @todo:replace this with a direct call to mGuest in trunk! */250 /** @todo replace this with a direct call to mGuest in trunk! */ 251 251 AutoCaller autoCaller(mMachine); 252 252 if (FAILED(autoCaller.rc())) return autoCaller.rc(); -
trunk/src/VBox/Main/src-server/PerformanceImpl.cpp
r63176 r63563 499 499 { 500 500 ULONG *values, length, sequenceNumber; 501 /* @todo We may want to revise the query method to get rid of excessive alloc/memcpy calls. */501 /** @todo We may want to revise the query method to get rid of excessive alloc/memcpy calls. */ 502 502 (*it)->query(&values, &length, &sequenceNumber); 503 503 LogFlow(("PerformanceCollector::QueryMetricsData() querying metric %s returned %d values.\n", -
trunk/src/VBox/Main/src-server/SnapshotImpl.cpp
r61009 r63563 25 25 #include "ProgressImpl.h" 26 26 27 // @todo these three includes are required for about one or two lines, try27 /// @todo these three includes are required for about one or two lines, try 28 28 // to remove them and put that code in shared code in MachineImplcpp 29 29 #include "SharedFolderImpl.h" … … 1562 1562 try 1563 1563 { 1564 // @todo:at this point we have to be in the right state!!!!1564 /// @todo at this point we have to be in the right state!!!! 1565 1565 AssertStmt( mData->mMachineState == MachineState_Snapshotting 1566 1566 || mData->mMachineState == MachineState_OnlineSnapshotting … … 1710 1710 LogThisFunc(("Caught %Rhrc [mMachineState=%s]\n", rc, Global::stringifyMachineState(mData->mMachineState))); 1711 1711 1712 // @todo r=klaus check that the implicit diffs created above are cleaned up im the relevant error cases1712 /// @todo r=klaus check that the implicit diffs created above are cleaned up im the relevant error cases 1713 1713 1714 1714 /* preserve existing error info */ -
trunk/src/VBox/Main/src-server/VRDEServerImpl.cpp
r62982 r63563 742 742 mlock.release(); 743 743 744 mParent->i_onVRDEServerChange(/* aRestart */ TRUE); // @todo does it need a restart?744 mParent->i_onVRDEServerChange(/* aRestart */ TRUE); /// @todo does it need a restart? 745 745 } 746 746 … … 777 777 mlock.release(); 778 778 779 mParent->i_onVRDEServerChange(/* aRestart */ TRUE); // @todo needs a restart?779 mParent->i_onVRDEServerChange(/* aRestart */ TRUE); /// @todo needs a restart? 780 780 } 781 781 -
trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp
r63256 r63563 1300 1300 } 1301 1301 1302 /** @todo :account for version in the URL */1302 /** @todo account for version in the URL */ 1303 1303 aUrl = firmwareDesc[i].url; 1304 1304 *aResult = FALSE; -
trunk/src/VBox/Main/src-server/darwin/PerformanceDarwin.cpp
r62485 r63563 31 31 32 32 /* The following declarations are missing in 10.4.x SDK */ 33 /* @todo Replace them with libproc.h and sys/proc_info.h when 10.4 is no longer supported */33 /** @todo Replace them with libproc.h and sys/proc_info.h when 10.4 is no longer supported */ 34 34 extern "C" int proc_pidinfo(int pid, int flavor, uint64_t arg, void *buffer, int buffersize); 35 35 struct proc_taskinfo { -
trunk/src/VBox/Main/src-server/freebsd/PerformanceFreeBSD.cpp
r62485 r63563 48 48 size_t cbParameter = sizeof(CpuMHz); 49 49 50 /** @todo :Howto support more than one CPU? */50 /** @todo Howto support more than one CPU? */ 51 51 if (sysctlbyname("dev.cpu.0.freq", &CpuMHz, &cbParameter, NULL, 0)) 52 52 return VERR_NOT_SUPPORTED; -
trunk/src/VBox/Main/src-server/generic/USBProxyBackendUsbIp.cpp
r62485 r63563 50 50 #define USBIP_REQ_RET_DEVLIST UINT16_C(5) 51 51 52 /** @todo :Duplicate code in USBProxyDevice-usbip.cpp */52 /** @todo Duplicate code in USBProxyDevice-usbip.cpp */ 53 53 /** 54 54 * Exported device entry in the OP_RET_DEVLIST reply. … … 955 955 pNew->enmState = USBDEVICESTATE_USED_BY_HOST_CAPTURABLE; 956 956 pNew->u64SerialHash = 0; 957 /** @todo :The following is not correct but is required to to get USB testing working957 /** @todo The following is not correct but is required to to get USB testing working 958 958 * because only the port can be part of a filter (adding the required attributes for the bus 959 959 * breaks API and ABI compatibility). -
trunk/src/VBox/Main/src-server/linux/PerformanceLinux.cpp
r62485 r63563 287 287 signed long ilTmp; 288 288 ULONG u32user, u32kernel; 289 char buf[80]; /* @todo:this should be tied to max allowed proc name. */289 char buf[80]; /** @todo this should be tied to max allowed proc name. */ 290 290 291 291 RTStrAPrintf(&pszName, "/proc/%d/stat", process); -
trunk/src/VBox/Main/src-server/win/NetIf-win.cpp
r63311 r63563 350 350 { 351 351 endLoop = true; 352 rc = E_FAIL;// TODO:ComAssertMsgFailedBreak((352 rc = E_FAIL;/// @todo ComAssertMsgFailedBreak(( 353 353 //"Invalid message code %d (%08lX)\n", 354 354 //reply, reply), … … 404 404 { 405 405 endLoop = true; 406 rc = E_FAIL; // TODO:ComAssertMsgFailedBreak((406 rc = E_FAIL; /// @todo ComAssertMsgFailedBreak(( 407 407 //"Invalid message code %d (%08lX)\n", 408 408 //reply, reply), … … 458 458 { 459 459 endLoop = true; 460 rc = E_FAIL; // TODO:ComAssertMsgFailedBreak((460 rc = E_FAIL; /// @todo ComAssertMsgFailedBreak(( 461 461 //"Invalid message code %d (%08lX)\n", 462 462 //reply, reply), … … 516 516 { 517 517 endLoop = true; 518 rc = E_FAIL; // TODO:ComAssertMsgFailedBreak((518 rc = E_FAIL; /// @todo ComAssertMsgFailedBreak(( 519 519 //"Invalid message code %d (%08lX)\n", 520 520 //reply, reply), … … 574 574 { 575 575 endLoop = true; 576 rc = E_FAIL; // TODO:ComAssertMsgFailedBreak((576 rc = E_FAIL; /// @todo ComAssertMsgFailedBreak(( 577 577 //"Invalid message code %d (%08lX)\n", 578 578 //reply, reply), … … 628 628 { 629 629 endLoop = true; 630 rc = E_FAIL; // TODO:ComAssertMsgFailedBreak((630 rc = E_FAIL; /// @todo ComAssertMsgFailedBreak(( 631 631 //"Invalid message code %d (%08lX)\n", 632 632 //reply, reply), … … 639 639 } 640 640 default: 641 rc = E_FAIL; // TODO:ComAssertMsgFailedBreak((641 rc = E_FAIL; /// @todo ComAssertMsgFailedBreak(( 642 642 // "Invalid message code %d (%08lX)\n", 643 643 // d->msgCode, d->msgCode), … … 1556 1556 if (pBp->IsEnabled() != S_OK) 1557 1557 { 1558 /* @todo some id of disabled path could be useful. */1558 /** @todo some id of disabled path could be useful. */ 1559 1559 netIfLog(("netIfGetBoundAdapters: INetCfgBindingPath is disabled (0x%x)\n", hr)); 1560 1560 pBp->Release(); -
trunk/src/VBox/Main/webservice/vboxweb.cpp
r63258 r63563 1596 1596 { 1597 1597 com::Utf8Str ustr(bstr); 1598 return ustr.c_str(); // @todo r=dj since the length is known, we can probably use a better std::string allocator1598 return ustr.c_str(); /// @todo r=dj since the length is known, we can probably use a better std::string allocator 1599 1599 } 1600 1600 … … 1608 1608 { 1609 1609 com::Utf8Str ustr(uuid.toString()); 1610 return ustr.c_str(); // @todo r=dj since the length is known, we can probably use a better std::string allocator1610 return ustr.c_str(); /// @todo r=dj since the length is known, we can probably use a better std::string allocator 1611 1611 } 1612 1612 -
trunk/src/VBox/Main/xml/ovfreader.cpp
r60998 r63563 154 154 else if ( !strcmp(pcszElemName, "DeploymentOptionSection")) 155 155 { 156 // TODO156 /// @todo 157 157 } 158 158 else if ( !strcmp(pcszElemName, "Info")) … … 182 182 ) 183 183 { 184 // TODOResourceAllocationSection184 /// @todo ResourceAllocationSection 185 185 186 186 // recurse for this, since it has VirtualSystem elements as children
Note:
See TracChangeset
for help on using the changeset viewer.

