VirtualBox

Changeset 63563 in vbox for trunk


Ignore:
Timestamp:
Aug 16, 2016 2:04:28 PM (8 years ago)
Author:
vboxsync
Message:

scm: cleaning up todos

Location:
trunk/src/VBox/Main
Files:
30 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Main/src-all/DisplayUtils.cpp

    r62485 r63563  
    2828    LogFlowFunc(("u32Type = %d [%s]\n", u32Type, strStateFilePath.c_str()));
    2929
    30     /* @todo cache read data */
     30    /** @todo cache read data */
    3131    if (strStateFilePath.isEmpty())
    3232    {
     
    139139void freeSavedDisplayScreenshot(uint8_t *pu8Data)
    140140{
    141     /* @todo not necessary when caching is implemented. */
     141    /** @todo not necessary when caching is implemented. */
    142142    RTMemFree(pu8Data);
    143143}
     
    149149    LogFlowFunc(("u32ScreenId = %d [%s]\n", u32ScreenId, strStateFilePath.c_str()));
    150150
    151     /* @todo cache read data */
     151    /** @todo cache read data */
    152152    if (strStateFilePath.isEmpty())
    153153    {
  • trunk/src/VBox/Main/src-all/EventImpl.cpp

    r61774 r63563  
    210210    // must drop lock while waiting, because setProcessed() needs synchronization.
    211211    alock.release();
    212     /* @todo: maybe while loop for spurious wakeups? */
     212    /** @todo maybe while loop for spurious wakeups? */
    213213    int vrc = ::RTSemEventWait(m->mWaitEvent, aTimeout);
    214214    AssertMsg(RT_SUCCESS(vrc) || vrc == VERR_TIMEOUT || vrc == VERR_INTERRUPTED,
  • trunk/src/VBox/Main/src-client/ConsoleImpl2.cpp

    r63423 r63563  
    612612         * requires RAM preallocation.
    613613         */
    614         /** @todo: check if we can lift this requirement */
     614        /** @todo check if we can lift this requirement */
    615615        CFGMR3RemoveValue(pRoot, "RamPreAlloc");
    616616        InsertConfigInteger(pRoot, "RamPreAlloc", 1);
     
    15351535         */
    15361536        BOOL fLpcEnabled;
    1537         /** @todo: implement appropriate getter */
     1537        /** @todo implement appropriate getter */
    15381538        fLpcEnabled = fOsXGuest || (chipsetType == ChipsetType_ICH9);
    15391539        if (fLpcEnabled)
     
    36323632            {
    36333633                LONG64 winId = 0;
    3634                 /* @todo deal with multimonitor setup */
     3634                /** @todo deal with multimonitor setup */
    36353635                Assert(cMonitorCount == 1);
    36363636                hrc = pFramebuffer->COMGETTER(WinId)(&winId);
     
    38493849                mUSBStorageDevices.push_back(UsbMsd);
    38503850
    3851                 /** @todo: No LED after hotplugging. */
     3851                /** @todo No LED after hotplugging. */
    38523852                /* Attach the status driver */
    38533853                Assert(cLedUsb >= 8);
  • trunk/src/VBox/Main/src-client/ConsoleVRDPServer.cpp

    r63240 r63563  
    789789               )
    790790            {
    791                 /* @todo these features should be per client. */
     791                /** @todo these features should be per client. */
    792792                NOREF(pFeature->u32ClientId);
    793793
     
    18421842    Assert(p->pThis);
    18431843
    1844     /* @todo find out what to do if size changes to 0x0 from non zero */
     1844    /** @todo find out what to do if size changes to 0x0 from non zero */
    18451845    if (w == 0 || h == 0)
    18461846    {
     
    18921892    {
    18931893        /* Create a new bitmap handle. */
    1894         uint32_t u32ScreenId = 0; /* @todo clip to corresponding screens.
     1894        uint32_t u32ScreenId = 0; /** @todo clip to corresponding screens.
    18951895                                   * Clipping can be done here or in VRDP server.
    18961896                                   * If VRDP does clipping, then uScreenId parameter
     
    21712171        if (u32StreamId != 0)
    21722172        {
    2173             p->fCreated = true; // @todo not needed?
     2173            p->fCreated = true; /// @todo not needed?
    21742174        }
    21752175        else
     
    23312331    if (RT_SUCCESS(rc))
    23322332    {
    2333         /* @todo contexts should be in a list for accounting. */
     2333        /** @todo contexts should be in a list for accounting. */
    23342334        *ppvChannel = pHostChCtx;
    23352335    }
     
    25362536}
    25372537
    2538 /* @todo these defines must be in a header, which is used by guest component as well. */
     2538/** @todo these defines must be in a header, which is used by guest component as well. */
    25392539#define VBOX_TSMF_HCH_CREATE_ACCEPTED (VBOX_HOST_CHANNEL_EVENT_USER + 0)
    25402540#define VBOX_TSMF_HCH_CREATE_DECLINED (VBOX_HOST_CHANNEL_EVENT_USER + 1)
     
    28752875            else if (pHeader->u16EventId == VRDEINPUT_EVENTID_DISMISS_HOVERING_CONTACT)
    28762876            {
    2877                 /* @todo */
     2877                /** @todo */
    28782878            }
    28792879            else
     
    39393939    HRESULT VRDEServerInfo::get##_aName(_aType *a##_aName)                \
    39403940    {                                                                     \
    3941         /* todo: Not sure if a AutoReadLock would be sufficient. */       \
     3941        /** @todo Not sure if a AutoReadLock would be sufficient. */       \
    39423942        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                  \
    39433943                                                                          \
     
    39573957    HRESULT VRDEServerInfo::get##_aName(_aType *a##_aName)                \
    39583958    {                                                                     \
    3959         /* todo: Not sure if a AutoReadLock would be sufficient. */       \
     3959        /** @todo Not sure if a AutoReadLock would be sufficient. */       \
    39603960        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                  \
    39613961                                                                          \
     
    39763976    HRESULT VRDEServerInfo::get##_aName(_aType &a##_aName)                \
    39773977    {                                                                     \
    3978         /* todo: Not sure if a AutoReadLock would be sufficient. */       \
     3978        /** @todo Not sure if a AutoReadLock would be sufficient. */       \
    39793979        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                  \
    39803980                                                                          \
  • trunk/src/VBox/Main/src-client/DisplayImpl.cpp

    r63418 r63563  
    942942    if (!maFramebuffers[uScreenId].pFramebuffer.isNull())
    943943    {
    944         HRESULT hr = maFramebuffers[uScreenId].pFramebuffer->NotifyChange(uScreenId, 0, 0, w, h); /* @todo origin */
     944        HRESULT hr = maFramebuffers[uScreenId].pFramebuffer->NotifyChange(uScreenId, 0, 0, w, h); /** @todo origin */
    945945        LogFunc(("NotifyChange hr %08X\n", hr));
    946946        NOREF(hr);
     
    25862586        rc = setError(VBOX_E_IPRT_ERROR,
    25872587                      tr("Could not draw to the screen (%Rrc)"), rcVBox);
    2588 //@todo
     2588/// @todo
    25892589//    else
    25902590//    {
     
    39513951    pHdrUnconst->y -= (int16_t)pFBInfo->yOrigin;
    39523952
    3953     /* @todo new SendUpdate entry which can get a separate cmd header or coords. */
     3953    /** @todo new SendUpdate entry which can get a separate cmd header or coords. */
    39543954    pThis->mParent->i_consoleVRDPServer()->SendUpdate(uScreenId, pCmd, (uint32_t)cbCmd);
    39553955
     
    39663966    DISPLAYFBINFO *pFBInfo = &pThis->maFramebuffers[uScreenId];
    39673967
    3968     /* @todo handleFramebufferUpdate (uScreenId,
     3968    /** @todo handleFramebufferUpdate (uScreenId,
    39693969     *                                x - pThis->maFramebuffers[uScreenId].xOrigin,
    39703970     *                                y - pThis->maFramebuffers[uScreenId].yOrigin,
  • trunk/src/VBox/Main/src-client/DisplayImplLegacy.cpp

    r63244 r63563  
    163163    if (pFBInfo->fDefaultFormat)
    164164    {
    165         //@todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer
     165        /// @todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer
    166166        prgn->pPort->pfnUpdateDisplayRect(prgn->pPort, phdr->x, phdr->y, phdr->w, phdr->h);
    167167        prgn->pDisplay->i_handleDisplayUpdate(uScreenId, phdr->x, phdr->y, phdr->w, phdr->h);
     
    181181    if (!pFBInfo->fDefaultFormat && w != 0 && h != 0)
    182182    {
    183         //@todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer
     183        /// @todo pfnUpdateDisplayRect must take the vram offset parameter for the framebuffer
    184184        prgn->pPort->pfnUpdateDisplayRect(prgn->pPort, pDirtyRect->xLeft, pDirtyRect->yTop, w, h);
    185185        prgn->pDisplay->i_handleDisplayUpdate(uScreenId, pDirtyRect->xLeft, pDirtyRect->yTop, w, h);
     
    804804         pu8 += u32VRAMSize - VBOX_VIDEO_ADAPTER_INFORMATION_SIZE;
    805805
    806          // @todo
     806         /// @todo
    807807         uint8_t *pu8End = pu8 + VBOX_VIDEO_ADAPTER_INFORMATION_SIZE;
    808808
     
    864864                     case VBOX_VIDEO_QCI32_OFFSCREEN_HEAP_SIZE:
    865865                     {
    866                          /* @todo make configurable. */
     866                         /** @todo make configurable. */
    867867                         pConf32->u32Value = _1M;
    868868                     } break;
     
    908908    pu8 += pFBInfo->u32Offset + pFBInfo->u32MaxFramebufferSize;
    909909
    910     // @todo
     910    /// @todo
    911911    uint8_t *pu8End = pu8 + pFBInfo->u32InformationSize;
    912912
  • trunk/src/VBox/Main/src-client/DrvAudioVideoRec.cpp

    r63534 r63563  
    4343#define CA_STATUS_IN_UNINIT UINT32_C(3) /* The device is currently uninitializing */
    4444
    45 //@todo move t_sample as a PDM interface
     45/// @todo move t_sample as a PDM interface
    4646//typedef struct { int mute;  uint32_t r; uint32_t l; } volume_t;
    4747
     
    437437         * we are filling this buffer with the audio data available from VRDP. Here we are reading it
    438438         */
    439         /*todo do I need to introduce a thread to fill the buffer in fltRecordcallback. So that
     439        /** @todo do I need to introduce a thread to fill the buffer in fltRecordcallback. So that
    440440         * filling is in separate thread and the reading of that buffer is in separate thread
    441441         */
     
    573573    if (enmStreamCmd == PDMAUDIOSTREAMCMD_ENABLE)
    574574    {
    575         //@todo if (!pVRDEVoice->fIsInit)
     575        /// @todo if (!pVRDEVoice->fIsInit)
    576576        //    RTCircBufReset(pVRDEVoice->pRecordedVoiceBuf);
    577577        pVRDEVoice->fIsInit = 1;
     
    704704    //if (iSampleHz && iSampleHz != pVRDEVoice->pHostVoiceIn.Props.uFrequency)
    705705    {
    706         /* @todo if the above condition is false then pVRDEVoice->uFrequency will remain 0 */
     706        /** @todo if the above condition is false then pVRDEVoice->uFrequency will remain 0 */
    707707        /*mpDrv->pUpPort->pfnPrepareAudioConversion(mpDrv->pUpPort, iSampleHz,
    708708                                                  pVRDEVoice->pHostVoiceIn.Props.uFrequency,
     
    737737
    738738    /* count of rate adjusted samples */
    739     pVRDEVoice->uFrequency = 22100; /* @todo handle this. How pVRDEVoice will get proper value */
     739    pVRDEVoice->uFrequency = 22100; /** @todo handle this. How pVRDEVoice will get proper value */
    740740    cConvertedSamples = (cSamples * pVRDEVoice->pHostVoiceIn.Props.uHz) / pVRDEVoice->uFrequency;
    741741    vrdeReallocRateAdjSampleBuf(pVRDEVoice, cConvertedSamples);
  • trunk/src/VBox/Main/src-client/HGCM.cpp

    r62485 r63563  
    11451145
    11461146#ifdef VBOX_WITH_CRHGSMI
    1147         /* @todo: could this actually happen that the service is destroyed on ReleaseService? */
     1147        /** @todo could this actually happen that the service is destroyed on ReleaseService? */
    11481148        HGCMService *pNextSvc = pSvc->m_pSvcNext;
    11491149        while (pSvc->m_cHandleAcquires)
  • trunk/src/VBox/Main/src-client/RemoteUSBBackend.cpp

    r63256 r63563  
    134134static REMOTEUSBQURB *qurbAlloc(PREMOTEUSBDEVICE pDevice)
    135135{
    136     /* @todo reuse URBs. */
     136    /** @todo reuse URBs. */
    137137    REMOTEUSBQURB *pQURB = (REMOTEUSBQURB *)RTMemAllocZ (sizeof (REMOTEUSBQURB));
    138138
     
    563563            {
    564564                u32DataLen = 8; /* 8 byte header. */
    565                 // u32DataLen = u32Len; // @todo do messages need all information?
     565                // u32DataLen = u32Len; /// @todo do messages need all information?
    566566            }
    567567        } break;
  • trunk/src/VBox/Main/src-client/UsbCardReader.cpp

    r63239 r63563  
    374374                 pvUser));
    375375    PUSBCARDREADER pThis = RT_FROM_MEMBER(pInterface, USBCARDREADER, ICardReaderDown);
    376     /* @todo Device calls this when the driver already destroyed. */
     376    /** @todo Device calls this when the driver already destroyed. */
    377377    if (pThis->hReqQCardReaderCmd == NIL_RTREQQUEUE)
    378378    {
     
    751751            Assert(cbData == sizeof(VRDESCARDNOTIFYDETACH));
    752752
    753             /* @todo Just free. There should be no pending requests, because VRDP cancels them. */
     753            /** @todo Just free. There should be no pending requests, because VRDP cancels them. */
    754754            RTMemFree(m_pRemote);
    755755            m_pRemote = NULL;
     
    819819                                 i, pRsp->apszNames[i]));
    820820
    821                     /* @todo only the first reader is supported. */
     821                    /** @todo only the first reader is supported. */
    822822                    if (i != 0)
    823823                    {
     
    873873                                     i, pRsp->aReaderStates[i].u32EventState));
    874874
    875                         /* @todo only the first reader is supported. */
     875                        /** @todo only the first reader is supported. */
    876876                        if (i != 0)
    877877                        {
     
    11071107                    pu8RecvBuffer = pRsp->pu8RecvBuffer;
    11081108                    cbRecvBuffer = pRsp->u32RecvLength;
    1109                     /* @todo pioRecvPci */
     1109                    /** @todo pioRecvPci */
    11101110                }
    11111111            }
  • trunk/src/VBox/Main/src-client/UsbWebcamInterface.cpp

    r63259 r63563  
    220220            LogFlowFunc(("DETACH[%d,%d]\n", p->deviceHandle.u32ClientId, p->deviceHandle.u32DeviceId));
    221221
    222             /* @todo */
     222            /** @todo */
    223223            if (mpRemote)
    224224            {
  • trunk/src/VBox/Main/src-server/ApplianceImpl.cpp

    r63184 r63563  
    902902    char *tmpName = RTStrDup(aName.c_str());
    903903    int i = 1;
    904     /** @todo: Maybe too cost-intensive; try to find a lighter way */
     904    /** @todo Maybe too cost-intensive; try to find a lighter way */
    905905    while (mVirtualBox->FindMachine(Bstr(tmpName).raw(), &machine) != VBOX_E_OBJECT_NOT_FOUND)
    906906    {
     
    922922    /* Check if the file exists or if a file with this path is registered
    923923     * already */
    924     /** @todo: Maybe too cost-intensive; try to find a lighter way */
     924    /** @todo Maybe too cost-intensive; try to find a lighter way */
    925925    while (    RTPathExists(tmpName)
    926926            || mVirtualBox->OpenMedium(Bstr(tmpName).raw(), DeviceType_HardDisk, AccessMode_ReadWrite,
  • trunk/src/VBox/Main/src-server/ApplianceImplExport.cpp

    r63184 r63563  
    10061006        rc = pSourceDisk->COMGETTER(LogicalSize)(&cbCapacity);
    10071007        if (FAILED(rc)) throw rc;
    1008         // Todo r=poetzsch: wrong it is reported in bytes ...
     1008        /// @todo r=poetzsch: wrong it is reported in bytes ...
    10091009        // capacity is reported in megabytes, so...
    10101010        //cbCapacity *= _1M;
     
    10191019        pelmFile->setAttribute("ovf:href", strTargetFileNameOnly);
    10201020        pelmFile->setAttribute("ovf:id", strFileRef);
    1021         // Todo: the actual size is not available at this point of time,
     1021        /// @todo the actual size is not available at this point of time,
    10221022        // cause the disk will be compressed. The 1.0 standard says this is
    10231023        // optional! 1.1 isn't fully clear if the "gzip" format is used.
     
    23192319            {
    23202320                writeLock.acquire();
    2321                 // Todo: file deletion on error? If not, we can remove that whole try/catch block.
     2321                /// @todo file deletion on error? If not, we can remove that whole try/catch block.
    23222322                throw rc3;
    23232323            }
  • trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp

    r63171 r63563  
    114114HRESULT Appliance::interpret()
    115115{
    116     // @todo:
     116    /// @todo
    117117    //  - don't use COM methods but the methods directly (faster, but needs appropriate
    118118    // locking of that objects itself (s. HardDisk))
     
    521521                        if (cIDEused < 4)
    522522                        {
    523                             // @todo: figure out the IDE types
     523                            /// @todo figure out the IDE types
    524524                            /* Use PIIX4 as default */
    525525                            Utf8Str strType = "PIIX4";
     
    547547                        if (cSATAused < 1)
    548548                        {
    549                             // @todo: figure out the SATA types
     549                            /// @todo figure out the SATA types
    550550                            /* We only support a plain AHCI controller, so use them always */
    551551                            pNewDesc->i_addEntry(VirtualSystemDescriptionType_HardDiskControllerSATA,
     
    637637                    Utf8Str vdf = Utf8Str(bstrFormatName);
    638638
    639                     // @todo:
     639                    /// @todo
    640640                    //  - figure out all possible vmdk formats we also support
    641641                    //  - figure out if there is a url specifier for vhd already
     
    40714071        std::list<VirtualSystemDescriptionEntry*> vsdeAudioAdapter =
    40724072            vsdescThis->i_findByType(VirtualSystemDescriptionType_SoundCard);
    4073         /* @todo: we support one audio adapter only */
     4073        /** @todo we support one audio adapter only */
    40744074        if (!vsdeAudioAdapter.empty())
    40754075            stack.strAudioAdapter = vsdeAudioAdapter.front()->strVBoxCurrent;
  • trunk/src/VBox/Main/src-server/HostImpl.cpp

    r63423 r63563  
    703703        if (hr != S_OK)
    704704        {
    705             /* TODO: try to install the netflt from here */
     705            /** @todo try to install the netflt from here */
    706706        }
    707707#     endif
  • trunk/src/VBox/Main/src-server/MachineImpl.cpp

    r63460 r63563  
    757757
    758758        /* commit all changes made during loading the settings file */
    759         i_commit(); // @todo r=dj why do we need a commit during init?!? this is very expensive
     759        i_commit(); /// @todo r=dj why do we need a commit during init?!? this is very expensive
    760760        /// @todo r=klaus for some reason the settings loading logic backs up
    761761        // the settings, and therefore a commit is needed. Should probably be changed.
     
    26062606HRESULT Machine::setSnapshotFolder(const com::Utf8Str &aSnapshotFolder)
    26072607{
    2608     /* @todo (r=dmik):
     2608    /** @todo (r=dmik):
    26092609     *  1. Allow to change the name of the snapshot folder containing snapshots
    26102610     *  2. Rename the folder on disk instead of just changing the property
     
    30783078    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
    30793079
    3080     /* @todo deal with running state change. */
     3080    /** @todo deal with running state change. */
    30813081    HRESULT rc = i_checkStateDependency(MutableOrSavedOrRunningStateDep);
    30823082    if (FAILED(rc)) return rc;
     
    31003100    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
    31013101
    3102     /* @todo deal with running state change. */
     3102    /** @todo deal with running state change. */
    31033103    HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep);
    31043104    if (FAILED(rc)) return rc;
     
    31223122    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
    31233123
    3124     /* @todo deal with running state change. */
     3124    /** @todo deal with running state change. */
    31253125    HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep);
    31263126    if (FAILED(rc)) return rc;
     
    31453145    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
    31463146
    3147     /* @todo deal with running state change. */
     3147    /** @todo deal with running state change. */
    31483148    HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep);
    31493149    if (FAILED(rc)) return rc;
     
    31683168    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
    31693169
    3170     /* @todo deal with running state change. */
     3170    /** @todo deal with running state change. */
    31713171    HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep);
    31723172    if (FAILED(rc)) return rc;
     
    1060110601
    1060210602            mData->pMachineConfigFile->fAborted = (mData->mMachineState == MachineState_Aborted);
    10603 //@todo live migration             mData->pMachineConfigFile->fTeleported = (mData->mMachineState == MachineState_Teleported);
     10603/// @todo live migration             mData->pMachineConfigFile->fTeleported = (mData->mMachineState == MachineState_Teleported);
    1060410604        }
    1060510605
  • trunk/src/VBox/Main/src-server/MediumImpl.cpp

    r63418 r63563  
    39503950    bool fRemove = false;
    39513951
    3952     // @todo r=klaus eliminate this code, replace it by using find.
     3952    /// @todo r=klaus eliminate this code, replace it by using find.
    39533953    for (GuidList::iterator it = m->llRegistryIDs.begin();
    39543954         it != m->llRegistryIDs.end();
     
    40064006bool Medium::i_isInRegistry(const Guid &id)
    40074007{
    4008     // @todo r=klaus eliminate this code, replace it by using find.
     4008    /// @todo r=klaus eliminate this code, replace it by using find.
    40094009    for (GuidList::const_iterator it = m->llRegistryIDs.begin();
    40104010         it != m->llRegistryIDs.end();
  • trunk/src/VBox/Main/src-server/NetworkAdapterImpl.cpp

    r62363 r63563  
    12961296        mlock.release();
    12971297
    1298         /* TODO: changeAdapter=???. */
     1298        /** @todo changeAdapter=???. */
    12991299        mParent->i_onNetworkAdapterChange(this, FALSE);
    13001300    }
  • trunk/src/VBox/Main/src-server/Performance.cpp

    r63174 r63563  
    248248    if (mGuest)
    249249    {
    250         /* @todo: replace this with a direct call to mGuest in trunk! */
     250        /** @todo replace this with a direct call to mGuest in trunk! */
    251251        AutoCaller autoCaller(mMachine);
    252252        if (FAILED(autoCaller.rc())) return autoCaller.rc();
  • trunk/src/VBox/Main/src-server/PerformanceImpl.cpp

    r63176 r63563  
    499499    {
    500500        ULONG *values, length, sequenceNumber;
    501         /* @todo We may want to revise the query method to get rid of excessive alloc/memcpy calls. */
     501        /** @todo We may want to revise the query method to get rid of excessive alloc/memcpy calls. */
    502502        (*it)->query(&values, &length, &sequenceNumber);
    503503        LogFlow(("PerformanceCollector::QueryMetricsData() querying metric %s returned %d values.\n",
  • trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

    r61009 r63563  
    2525#include "ProgressImpl.h"
    2626
    27 // @todo these three includes are required for about one or two lines, try
     27/// @todo these three includes are required for about one or two lines, try
    2828// to remove them and put that code in shared code in MachineImplcpp
    2929#include "SharedFolderImpl.h"
     
    15621562    try
    15631563    {
    1564         // @todo: at this point we have to be in the right state!!!!
     1564        /// @todo at this point we have to be in the right state!!!!
    15651565        AssertStmt(   mData->mMachineState == MachineState_Snapshotting
    15661566                   || mData->mMachineState == MachineState_OnlineSnapshotting
     
    17101710        LogThisFunc(("Caught %Rhrc [mMachineState=%s]\n", rc, Global::stringifyMachineState(mData->mMachineState)));
    17111711
    1712         // @todo r=klaus check that the implicit diffs created above are cleaned up im the relevant error cases
     1712        /// @todo r=klaus check that the implicit diffs created above are cleaned up im the relevant error cases
    17131713
    17141714        /* preserve existing error info */
  • trunk/src/VBox/Main/src-server/VRDEServerImpl.cpp

    r62982 r63563  
    742742        mlock.release();
    743743
    744         mParent->i_onVRDEServerChange(/* aRestart */ TRUE); // @todo does it need a restart?
     744        mParent->i_onVRDEServerChange(/* aRestart */ TRUE); /// @todo does it need a restart?
    745745    }
    746746
     
    777777        mlock.release();
    778778
    779         mParent->i_onVRDEServerChange(/* aRestart */ TRUE); // @todo needs a restart?
     779        mParent->i_onVRDEServerChange(/* aRestart */ TRUE); /// @todo needs a restart?
    780780    }
    781781
  • trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp

    r63256 r63563  
    13001300        }
    13011301
    1302         /** @todo: account for version in the URL */
     1302        /** @todo account for version in the URL */
    13031303        aUrl = firmwareDesc[i].url;
    13041304        *aResult = FALSE;
  • trunk/src/VBox/Main/src-server/darwin/PerformanceDarwin.cpp

    r62485 r63563  
    3131
    3232/* The following declarations are missing in 10.4.x SDK */
    33 /* @todo Replace them with libproc.h and sys/proc_info.h when 10.4 is no longer supported */
     33/** @todo Replace them with libproc.h and sys/proc_info.h when 10.4 is no longer supported */
    3434extern "C" int proc_pidinfo(int pid, int flavor, uint64_t arg,  void *buffer, int buffersize);
    3535struct proc_taskinfo {
  • trunk/src/VBox/Main/src-server/freebsd/PerformanceFreeBSD.cpp

    r62485 r63563  
    4848    size_t cbParameter = sizeof(CpuMHz);
    4949
    50     /** @todo: Howto support more than one CPU? */
     50    /** @todo Howto support more than one CPU? */
    5151    if (sysctlbyname("dev.cpu.0.freq", &CpuMHz, &cbParameter, NULL, 0))
    5252        return VERR_NOT_SUPPORTED;
  • trunk/src/VBox/Main/src-server/generic/USBProxyBackendUsbIp.cpp

    r62485 r63563  
    5050#define USBIP_REQ_RET_DEVLIST UINT16_C(5)
    5151
    52 /** @todo: Duplicate code in USBProxyDevice-usbip.cpp */
     52/** @todo Duplicate code in USBProxyDevice-usbip.cpp */
    5353/**
    5454 * Exported device entry in the OP_RET_DEVLIST reply.
     
    955955        pNew->enmState           = USBDEVICESTATE_USED_BY_HOST_CAPTURABLE;
    956956        pNew->u64SerialHash      = 0;
    957         /** @todo: The following is not correct but is required to to get USB testing working
     957        /** @todo The following is not correct but is required to to get USB testing working
    958958         * because only the port can be part of a filter (adding the required attributes for the bus
    959959         * breaks API and ABI compatibility).
  • trunk/src/VBox/Main/src-server/linux/PerformanceLinux.cpp

    r62485 r63563  
    287287    signed long ilTmp;
    288288    ULONG u32user, u32kernel;
    289     char buf[80]; /* @todo: this should be tied to max allowed proc name. */
     289    char buf[80]; /** @todo this should be tied to max allowed proc name. */
    290290
    291291    RTStrAPrintf(&pszName, "/proc/%d/stat", process);
  • trunk/src/VBox/Main/src-server/win/NetIf-win.cpp

    r63311 r63563  
    350350                    {
    351351                        endLoop = true;
    352                         rc = E_FAIL;//TODO: ComAssertMsgFailedBreak((
     352                        rc = E_FAIL;/// @todo ComAssertMsgFailedBreak((
    353353                            //"Invalid message code %d (%08lX)\n",
    354354                            //reply, reply),
     
    404404                    {
    405405                        endLoop = true;
    406                         rc = E_FAIL; // TODO: ComAssertMsgFailedBreak((
     406                        rc = E_FAIL; /// @todo ComAssertMsgFailedBreak((
    407407                            //"Invalid message code %d (%08lX)\n",
    408408                            //reply, reply),
     
    458458                    {
    459459                        endLoop = true;
    460                         rc = E_FAIL; // TODO: ComAssertMsgFailedBreak((
     460                        rc = E_FAIL; /// @todo ComAssertMsgFailedBreak((
    461461                            //"Invalid message code %d (%08lX)\n",
    462462                            //reply, reply),
     
    516516                    {
    517517                        endLoop = true;
    518                         rc = E_FAIL; // TODO: ComAssertMsgFailedBreak((
     518                        rc = E_FAIL; /// @todo ComAssertMsgFailedBreak((
    519519                            //"Invalid message code %d (%08lX)\n",
    520520                            //reply, reply),
     
    574574                    {
    575575                        endLoop = true;
    576                         rc = E_FAIL; // TODO: ComAssertMsgFailedBreak((
     576                        rc = E_FAIL; /// @todo ComAssertMsgFailedBreak((
    577577                            //"Invalid message code %d (%08lX)\n",
    578578                            //reply, reply),
     
    628628                    {
    629629                        endLoop = true;
    630                         rc = E_FAIL; // TODO: ComAssertMsgFailedBreak((
     630                        rc = E_FAIL; /// @todo ComAssertMsgFailedBreak((
    631631                            //"Invalid message code %d (%08lX)\n",
    632632                            //reply, reply),
     
    639639        }
    640640        default:
    641             rc = E_FAIL; // TODO: ComAssertMsgFailedBreak((
     641            rc = E_FAIL; /// @todo ComAssertMsgFailedBreak((
    642642//                "Invalid message code %d (%08lX)\n",
    643643//                d->msgCode, d->msgCode),
     
    15561556                    if (pBp->IsEnabled() != S_OK)
    15571557                    {
    1558                         /* @todo some id of disabled path could be useful. */
     1558                        /** @todo some id of disabled path could be useful. */
    15591559                        netIfLog(("netIfGetBoundAdapters: INetCfgBindingPath is disabled (0x%x)\n", hr));
    15601560                        pBp->Release();
  • trunk/src/VBox/Main/webservice/vboxweb.cpp

    r63258 r63563  
    15961596{
    15971597    com::Utf8Str ustr(bstr);
    1598     return ustr.c_str();        // @todo r=dj since the length is known, we can probably use a better std::string allocator
     1598    return ustr.c_str();        /// @todo r=dj since the length is known, we can probably use a better std::string allocator
    15991599}
    16001600
     
    16081608{
    16091609    com::Utf8Str ustr(uuid.toString());
    1610     return ustr.c_str();        // @todo r=dj since the length is known, we can probably use a better std::string allocator
     1610    return ustr.c_str();        /// @todo r=dj since the length is known, we can probably use a better std::string allocator
    16111611}
    16121612
  • trunk/src/VBox/Main/xml/ovfreader.cpp

    r60998 r63563  
    154154        else if (    !strcmp(pcszElemName, "DeploymentOptionSection"))
    155155        {
    156             // TODO
     156            /// @todo
    157157        }
    158158        else if (    !strcmp(pcszElemName, "Info"))
     
    182182                )
    183183        {
    184             // TODO ResourceAllocationSection
     184            /// @todo ResourceAllocationSection
    185185
    186186            // recurse for this, since it has VirtualSystem elements as children
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette