VirtualBox

Changeset 63560 in vbox for trunk


Ignore:
Timestamp:
Aug 16, 2016 2:01:20 PM (8 years ago)
Author:
vboxsync
Message:

scm: cleaning up todos

Location:
trunk/src/VBox/VMM
Files:
27 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/VMM/VMMAll/EMAll.cpp

    r63465 r63560  
    11421142
    11431143        /* We only execute 32-bits protected mode code in raw mode, so no need to bother to check for 16-bits code here. */
    1144         /* @todo: we don't verify all the edge cases that generate #GP faults */
     1144        /** @todo we don't verify all the edge cases that generate #GP faults */
    11451145
    11461146        Assert(pRegFrame == CPUMGetGuestCtxCore(pVCpu));
  • trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

    r63465 r63560  
    156156    return VINF_SUCCESS;
    157157#else
    158     /* @todo in RC we could attempt to use the virtual address, although this can cause many faults (PAE Windows XP guest). */
     158    /** @todo in RC we could attempt to use the virtual address, although this can cause many faults (PAE Windows XP guest). */
    159159    NOREF(pvSrc);
    160160    return PGMPhysSimpleReadGCPhys(pVM, pvDst, GCPhysSrc & ~(RTGCPHYS)(cb - 1), cb);
     
    21662166    int rc = pgmPoolFlushPage(pPool, pPage);
    21672167    /* This flush was initiated by us and not the guest, so explicitly flush the TLB. */
    2168     /* todo: find out why this is necessary; pgmPoolFlushPage should trigger a flush if one is really needed. */
     2168    /** @todo find out why this is necessary; pgmPoolFlushPage should trigger a flush if one is really needed. */
    21692169    if (rc == VINF_SUCCESS)
    21702170        PGM_INVL_ALL_VCPU_TLBS(pVM);
  • trunk/src/VBox/VMM/VMMAll/TMAll.cpp

    r62478 r63560  
    19301930                    RTThreadSleep(1);
    19311931#else
    1932 /**@todo call host and yield cpu after a while. */
     1932/** @todo call host and yield cpu after a while. */
    19331933#endif
    19341934                break;
  • trunk/src/VBox/VMM/VMMR0/PGMR0.cpp

    r62478 r63560  
    277277
    278278    if (pGVM->rawpci.s.pfnContigMemInfo)
    279         /** @todo: what do we do on failure? */
     279        /** @todo what do we do on failure? */
    280280        pGVM->rawpci.s.pfnContigMemInfo(&pGVM->rawpci.s, HCPhys, GCPhys, PAGE_SIZE, PCIRAW_MEMINFO_MAP);
    281281
     
    301301
    302302    if (pGVM->rawpci.s.pfnContigMemInfo)
    303         /** @todo: what do we do on failure? */
     303        /** @todo what do we do on failure? */
    304304        pGVM->rawpci.s.pfnContigMemInfo(&pGVM->rawpci.s, 0, GCPhys, PAGE_SIZE, PCIRAW_MEMINFO_UNMAP);
    305305
  • trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

    r62478 r63560  
    17101710# ifdef DEBUG_sandervl
    17111711            /* Make sure that log flushes can jump back to ring-3; annoying to get an incomplete log (this is risky though as the code doesn't take this into account). */
    1712             /* Todo: this can have bad side effects for unexpected jumps back to r3. */
     1712            /** @todo this can have bad side effects for unexpected jumps back to r3. */
    17131713            rc = GMMR0CheckSharedModulesStart(pVM);
    17141714            if (rc == VINF_SUCCESS)
  • trunk/src/VBox/VMM/VMMR3/CPUMR3CpuId.cpp

    r62869 r63560  
    28712871        {
    28722872            pCurLeaf->uEcx = X86_CPUID_MWAIT_ECX_EXT | X86_CPUID_MWAIT_ECX_BREAKIRQIF0;
    2873             /** @todo: for now we just expose host's MWAIT C-states, although conceptually
     2873            /** @todo for now we just expose host's MWAIT C-states, although conceptually
    28742874               it shall be part of our power management virtualization model */
    28752875#if 0
  • trunk/src/VBox/VMM/VMMR3/CSAM.cpp

    r62647 r63560  
    559559    AssertRC(rc);
    560560
    561     /* @todo triggers assertion in MMHyperFree */
     561    /** @todo triggers assertion in MMHyperFree */
    562562#if 0
    563563    for(int i=0;i<CSAM_PAGEBMP_CHUNKS;i++)
     
    23052305        if (pPageRec->page.fMonitorActive)
    23062306        {
    2307             /* @todo -> this is expensive (cr3 reload)!!!
     2307            /** @todo -> this is expensive (cr3 reload)!!!
    23082308             * if this happens often, then reuse it instead!!!
    23092309             */
  • trunk/src/VBox/VMM/VMMR3/DBGF.cpp

    r62478 r63560  
    749749        uint32_t eip = CPUMGetGuestEIP(pVM);
    750750#else
    751         /* @todo SMP support!! */
     751        /** @todo SMP support!! */
    752752        PCPUMCTX pCtx = CPUMQueryGuestCtxPtr(VMMGetCpu(pVM));
    753753        RTGCPTR  eip = pCtx->rip + pCtx->cs.u64Base;
  • trunk/src/VBox/VMM/VMMR3/DBGFBp.cpp

    r62637 r63560  
    457457static int dbgfR3BpInt3Disarm(PUVM pUVM, PDBGFBP pBp)
    458458{
    459     /* @todo SMP support! */
     459    /** @todo SMP support! */
    460460    VMCPUID idCpu = 0;
    461461
  • trunk/src/VBox/VMM/VMMR3/DBGFR3Type.cpp

    r62637 r63560  
    761761        }
    762762        else
    763             MMR3HeapFree(pVal); /** @todo: Leak for embedded structs. */
     763            MMR3HeapFree(pVal); /** @todo Leak for embedded structs. */
    764764    }
    765765    else
  • trunk/src/VBox/VMM/VMMR3/EM.cpp

    r63465 r63560  
    17581758            PCPUMCTX pCtx = pVCpu->em.s.pCtx;
    17591759
    1760             /** @todo: check for 16 or 32 bits code! (D bit in the code selector) */
     1760            /** @todo check for 16 or 32 bits code! (D bit in the code selector) */
    17611761            Log(("Forced action VMCPU_FF_CSAM_SCAN_PAGE\n"));
    17621762
  • trunk/src/VBox/VMM/VMMR3/FTM.cpp

    r62478 r63560  
    775775                    if (RT_SUCCESS(rc))
    776776                    {
    777                         /** todo: verify VM config. */
     777                        /** @todo verify VM config. */
    778778                        break;
    779779                    }
     
    962962
    963963                pVM->ftm.s.fActivateStandby = true;
    964                 /** todo: prevent split-brain. */
     964                /** @todo prevent split-brain. */
    965965                break;
    966966            }
  • trunk/src/VBox/VMM/VMMR3/HM.cpp

    r62647 r63560  
    20482048    Assert(pVM->hm.s.cbGuestPatchMem == cbPatchMem);
    20492049
    2050     /* @todo Potential deadlock when other VCPUs are waiting on the IOM lock (we own it)!! */
     2050    /** @todo Potential deadlock when other VCPUs are waiting on the IOM lock (we own it)!! */
    20512051    int rc = VMMR3EmtRendezvous(pVM, VMMEMTRENDEZVOUS_FLAGS_TYPE_ONE_BY_ONE, hmR3RemovePatches,
    20522052                                (void *)(uintptr_t)VMMGetCpuId(pVM));
  • trunk/src/VBox/VMM/VMMR3/PATM.cpp

    r62651 r63560  
    857857                     * Disable patch; this is not a good solution
    858858                     */
    859                      /* @todo hopefully it was completely overwritten (if the read was successful)!!!! */
     859                     /** @todo hopefully it was completely overwritten (if the read was successful)!!!! */
    860860                    pPatch->patch.uState = PATCH_DISABLED;
    861861                }
     
    939939                     * Disable patch; this is not a good solution
    940940                     */
    941                      /* @todo hopefully it was completely overwritten (if the read was successful)!!!! */
     941                     /** @todo hopefully it was completely overwritten (if the read was successful)!!!! */
    942942                    pPatch->patch.uState = PATCH_DISABLED;
    943943                }
     
    16541654
    16551655    #if 0
    1656         ///@todo we can handle certain in/out and privileged instructions in the guest context
     1656        /// @todo we can handle certain in/out and privileged instructions in the guest context
    16571657        if (pCpu->pCurInstr->fOpType & DISOPTYPE_PRIVILEGED && pCpu->pCurInstr->uOpcode != OP_STI)
    16581658        {
     
    19921992
    19931993    case OP_STR:
    1994 #ifdef VBOX_WITH_SAFE_STR   /* @todo remove DISOPTYPE_PRIVILEGED_NOTRAP from disasm table and move OP_STR into #ifndef */
     1994#ifdef VBOX_WITH_SAFE_STR   /** @todo remove DISOPTYPE_PRIVILEGED_NOTRAP from disasm table and move OP_STR into #ifndef */
    19951995        /* Now safe because our shadow TR entry is identical to the guest's. */
    19961996        goto duplicate_instr;
  • trunk/src/VBox/VMM/VMMR3/PATMPatch.cpp

    r62652 r63560  
    118118    Assert(pRec);
    119119    pRec->Core.Key  = (AVLPVKEY)pRelocHC;
    120     pRec->pRelocPos = pRelocHC; /* @todo redundant. */
     120    pRec->pRelocPos = pRelocHC; /** @todo redundant. */
    121121    pRec->pSource   = pSource;
    122122    pRec->pDest     = pDest;
     
    138138
    139139    pRec->Core.Key  = (AVLPVKEY)pJumpHC;
    140     pRec->pJumpHC   = pJumpHC; /* @todo redundant. */
     140    pRec->pJumpHC   = pJumpHC; /** @todo redundant. */
    141141    pRec->offDispl  = offset;
    142142    pRec->pTargetGC = pTargetGC;
     
    12771277    pPB[1] = MAKE_MODRM(mod, reg, rm);
    12781278
    1279     /// @todo: make this an array in the context structure
     1279    /// @todo make this an array in the context structure
    12801280    switch (ctrlreg)
    12811281    {
     
    14651465    uint32_t i;
    14661466
    1467     /* @todo segment prefix (untested) */
     1467    /** @todo segment prefix (untested) */
    14681468    Assert(pCpu->fPrefix == DISPREFIX_NONE);
    14691469
  • trunk/src/VBox/VMM/VMMR3/PATMSSM.cpp

    r62639 r63560  
    6060    /* GC pointer of privileged instruction */
    6161    RCPTRTYPE(uint8_t *)  pPrivInstrGC;
    62     R3PTRTYPE(uint8_t *)  unusedHC;                             /* todo Can't remove due to structure size dependencies in saved states. */
     62    R3PTRTYPE(uint8_t *)  unusedHC;                             /** @todo Can't remove due to structure size dependencies in saved states. */
    6363    uint8_t               aPrivInstr[MAX_INSTR_SIZE];
    6464    uint32_t              cbPrivInstr;
     
    15131513                 * Disable patch; this is not a good solution
    15141514                 */
    1515                 /* @todo hopefully it was completely overwritten (if the read was successful)!!!! */
     1515                /** @todo hopefully it was completely overwritten (if the read was successful)!!!! */
    15161516                pPatch->uState = PATCH_DISABLED;
    15171517            }
  • trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFileNormal.cpp

    r62655 r63560  
    898898            pTask->offBounceBuffer = pTask->Off - offStart;
    899899
    900             /** @todo: I think we need something like a RTMemAllocAligned method here.
     900            /** @todo I think we need something like a RTMemAllocAligned method here.
    901901             * Current assumption is that the maximum alignment is 4096byte
    902902             * (GPT disk on Windows)
  • trunk/src/VBox/VMM/VMMR3/PDMDriver.cpp

    r62643 r63560  
    699699                    pNew->Internal.s.pVMRC          = pDrv->pReg->fFlags & PDM_DRVREG_FLAGS_RC ? pVM->pVMRC : NIL_RTRCPTR;
    700700                    //pNew->Internal.s.fDetaching     = false;
    701                     pNew->Internal.s.fVMSuspended   = true; /** @todo: should be 'false', if driver is attached at runtime. */
     701                    pNew->Internal.s.fVMSuspended   = true; /** @todo should be 'false', if driver is attached at runtime. */
    702702                    //pNew->Internal.s.fVMReset       = false;
    703703                    pNew->Internal.s.fHyperHeap     = fHyperHeap;
  • trunk/src/VBox/VMM/VMMR3/PDMThread.cpp

    r62478 r63560  
    2020*   Header Files                                                                                                                 *
    2121*********************************************************************************************************************************/
    22 ///@todo \#define LOG_GROUP LOG_GROUP_PDM_THREAD
     22/// @todo \#define LOG_GROUP LOG_GROUP_PDM_THREAD
    2323#include "PDMInternal.h"
    2424#include <VBox/vmm/pdm.h>
  • trunk/src/VBox/VMM/VMMR3/PGMDbg.cpp

    r62478 r63560  
    332332    AssertReturn(pVM, VERR_INVALID_PARAMETER);
    333333
    334     /* @todo SMP support! */
     334    /** @todo SMP support! */
    335335    PVMCPU pVCpu = &pVM->aCpus[0];
    336336
     
    388388    AssertReturn(pVM, VERR_INVALID_PARAMETER);
    389389
    390     /* @todo SMP support! */
     390    /** @todo SMP support! */
    391391    PVMCPU pVCpu = &pVM->aCpus[0];
    392392
  • trunk/src/VBox/VMM/VMMR3/PGMPhys.cpp

    r63465 r63560  
    43274327    }
    43284328
    4329     /* todo: we should split this up into an allocate and flush operation. sometimes you want to flush and not allocate more (which will trigger the vm account limit error) */
     4329    /** @todo we should split this up into an allocate and flush operation. sometimes you want to flush and not allocate more (which will trigger the vm account limit error) */
    43304330    if (    rc == VERR_GMM_HIT_VM_ACCOUNT_LIMIT
    43314331        &&  pVM->pgm.s.cHandyPages > 0)
  • trunk/src/VBox/VMM/VMMR3/PGMPool.cpp

    r62478 r63560  
    175175    LogRel(("PGM: PGMPool: cMaxPages=%u (u64MaxPages=%llu)\n", cMaxPages, u64MaxPages));
    176176
    177     /** todo:
     177    /** @todo
    178178     * We need to be much more careful with our allocation strategy here.
    179179     * For nested paging we don't need pool user info nor extents at all, but
     
    846846        bool            fFirstMsg = true;
    847847
    848         /* Todo: cover other paging modes too. */
     848        /** @todo cover other paging modes too. */
    849849        if (pPage->enmKind == PGMPOOLKIND_PAE_PT_FOR_PAE_PT)
    850850        {
  • trunk/src/VBox/VMM/VMMR3/VMM.cpp

    r62647 r63560  
    305305            }
    306306        }
    307         /** @todo: Need failure cleanup. */
     307        /** @todo Need failure cleanup. */
    308308
    309309        //more todo in here?
     
    14091409        } while (rc == VINF_EM_RAW_INTERRUPT_HYPER);
    14101410
    1411 #if 0 /* todo triggers too often */
     1411#if 0 /** @todo triggers too often */
    14121412        Assert(!VMCPU_FF_IS_SET(pVCpu, VMCPU_FF_TO_R3));
    14131413#endif
  • trunk/src/VBox/VMM/VMMR3/VMMTests.cpp

    r63429 r63560  
    378378
    379379        vmmR3DoTrapTest(pVM, 0xd, 0, VERR_TRPM_DONT_PANIC,  0xf0f0f0f0, "vmmGCTestTrap0d_FaultEIP", "ltr #GP");
    380         ///@todo find a better \#GP case, on intel ltr will \#PF (busy update?) and not \#GP.
     380        /// @todo find a better \#GP case, on intel ltr will \#PF (busy update?) and not \#GP.
    381381        //vmmR3DoTrapTest(pVM, 0xd, 1, VERR_TRPM_DONT_PANIC,  0xf0f0f0f0, "vmmGCTestTrap0d_FaultEIP", "ltr #GP WP");
    382382
  • trunk/src/VBox/VMM/VMMR3/VMReq.cpp

    r62647 r63560  
    654654                    if (RT_FAILURE(rc))
    655655                        return rc;
    656 #if 0 ///@todo @bugref{4725} - def RT_LOCK_STRICT
     656#if 0 /// @todo @bugref{4725} - def RT_LOCK_STRICT
    657657                    for (VMCPUID idCpu = 0; idCpu < pUVM->cCpus; idCpu++)
    658658                        RTSemEventAddSignaller(pReq->EventSem, pUVM->aCpus[idCpu].vm.s.ThreadEMT);
     
    701701        return rc;
    702702    }
    703 #if 0 ///@todo @bugref{4725} - def RT_LOCK_STRICT
     703#if 0 /// @todo @bugref{4725} - def RT_LOCK_STRICT
    704704    for (VMCPUID idCpu = 0; idCpu < pUVM->cCpus; idCpu++)
    705705        RTSemEventAddSignaller(pReq->EventSem, pUVM->aCpus[idCpu].vm.s.ThreadEMT);
  • trunk/src/VBox/VMM/VMMRC/VMMRC.cpp

    r62601 r63560  
    6363VMMRCDECL(int) VMMRCEntry(PVM pVM, unsigned uOperation, unsigned uArg, ...)
    6464{
    65     /* todo */
     65    /** @todo */
    6666    switch (uOperation)
    6767    {
  • trunk/src/VBox/VMM/testcase/tstPDMAsyncCompletionStress.cpp

    r62776 r63560  
    397397    if (pTestTask->fWrite)
    398398    {
    399         /* @todo Do something sensible here. */
     399        /** @todo Do something sensible here. */
    400400    }
    401401    else
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette