Changeset 60542 in vbox

Timestamp:

Apr 18, 2016 3:02:26 PM (8 years ago)

Author:

vboxsync

Message:

VMM/APIC: Much fun with alignment and sizes.

Location:

trunk

Files:

• include/VBox/vmm/vm.h (modified) (2 diffs)
• src/VBox/VMM/VMMAll/APICAll.cpp (modified) (4 diffs)
• src/VBox/VMM/VMMR3/APIC.cpp (modified) (6 diffs)
• src/VBox/VMM/include/APICInternal.h (modified) (2 diffs)
• src/VBox/VMM/testcase/Makefile.kmk (modified) (6 diffs)
• src/VBox/VMM/testcase/tstVMStruct.h (modified) (5 diffs)
• src/VBox/VMM/testcase/tstVMStructDTrace.cpp (modified) (2 diffs)
• src/VBox/VMM/testcase/tstVMStructRC.cpp (modified) (2 diffs)
• src/VBox/VMM/testcase/tstVMStructSize.cpp (modified) (2 diffs)

trunk/include/VBox/vmm/vm.h

@@ -237 +237 @@
         struct APICCPU      s;
 # endif
-        uint8_t             padding[512];      /* multiple of 64 */
+        uint8_t             padding[640];      /* multiple of 64 */
     } apic;
 #endif
@@ -243 +243 @@
     /** Align the following members on page boundary. */
 #ifdef VBOX_WITH_NEW_APIC
-    uint8_t                 abAlignment2[2880];
+    uint8_t                 abAlignment2[2752];
 #else
     uint8_t                 abAlignment2[3392];

trunk/src/VBox/VMM/VMMAll/APICAll.cpp

@@ -92 +92 @@
 
 /**
- * Checks if a vector is set in an APIC Pending Interrupt Bitmap (PIB).
+ * Checks if a vector is set in an APIC Pending-Interrupt Bitmap (PIB).
  *
  * @returns true if the specified vector is set, false otherwise.
@@ -128 +128 @@
 
 /**
- * Sets the vector in an APIC Pending Interrupt Bitmap (PIB).
+ * Sets the vector in an APIC Pending-Interrupt Bitmap (PIB).
  *
  * @param   pvPib           Opaque pointer to the PIB.
@@ -140 +140 @@
 
 /**
- * Clears the vector in an APIC Pending Interrupt Bitmap (PIB).
+ * Clears the vector in an APIC Pending-Interrupt Bitmap (PIB).
  *
  * @param   pvPib           Opaque pointer to the PIB.
@@ -2155 +2155 @@
     AssertReturn(u8Pin <= 1, VERR_INVALID_PARAMETER);
     AssertReturn(u8Level <= 1, VERR_INVALID_PARAMETER);
-
     LogFlow(("APIC%u: APICLocalInterrupt\n", pVCpu->idCpu));
 
-    PCXAPICPAGE  pXApicPage = VMCPU_TO_CXAPICPAGE(pVCpu);
-    VBOXSTRICTRC rcStrict   = VINF_SUCCESS;
+    VBOXSTRICTRC rcStrict = VINF_SUCCESS;
 
     /* If the APIC is enabled, the interrupt is subject to LVT programming. */
     if (apicIsEnabled(pVCpu))
     {
+        PCXAPICPAGE pXApicPage = VMCPU_TO_CXAPICPAGE(pVCpu);
+
         /* Pick the LVT entry corresponding to the interrupt pin. */
         static const uint16_t s_au16LvtOffsets[] =

trunk/src/VBox/VMM/VMMR3/APIC.cpp

@@ -207 +207 @@
     memset((void *)&pX2ApicPage->self_ipi, 0, sizeof(pX2ApicPage->self_ipi));
 
-    /* Clear the posted interrupt bitmaps. */
+    /* Clear the pending-interrupt bitmaps. */
     PAPICCPU pApicCpu = VMCPU_TO_APICCPU(pVCpu);
     memset((void *)&pApicCpu->ApicPibLevel, 0, sizeof(APICPIB));
@@ -251 +251 @@
     LogFlow(("APIC%u: APICR3Reset\n", pVCpu->idCpu));
 
-#ifdef RT_STRICT
+#ifdef VBOX_STRICT
     /* Verify that the initial APIC ID reported via CPUID matches our VMCPU ID assumption. */
-    CPUMCPUIDLEAF CpuLeaf;
-    int rc = CPUMR3CpuIdGetLeaf(pVCpu->CTX_SUFF(pVM), &CpuLeaf, 1, 0);
-    AssertRC(rc);
-    Assert(((CpuLeaf.uEbx >> 24) & 0xff) == pVCpu->idCpu);
+    uint32_t uEax, uEbx, uEcx, uEdx;
+    uEax = uEbx = uEcx = uEdx = UINT32_MAX;
+    CPUMGetGuestCpuId(pVCpu, 1, 0, &uEax, &uEbx, &uEcx, &uEdx);
+    Assert(((uEbx >> 24) & 0xff) == pVCpu->idCpu);
 #endif
 
+    /*
+     * The state following a power-up or reset is a superset of the INIT state.
+     * See Intel spec. 10.4.7.3 "Local APIC State After an INIT Reset ('Wait-for-SIPI' State)"
+     */
     apicR3InitIpi(pVCpu);
-
-    PXAPICPAGE pXApicPage = VMCPU_TO_XAPICPAGE(pVCpu);
 
     /*
@@ -268 +270 @@
      * The version determines the number of LVT entries and size of the APIC ID (8 bits for P4).
      */
+    PXAPICPAGE pXApicPage = VMCPU_TO_XAPICPAGE(pVCpu);
 #if XAPIC_HARDWARE_VERSION == XAPIC_HARDWARE_VERSION_P4
     pXApicPage->version.u.u8MaxLvtEntry = XAPIC_MAX_LVT_ENTRIES_P4 - 1;
@@ -276 +279 @@
 #endif
 
-    /** @todo It isn't very clear where the default base address is (re)initialized,
-     *        atm we do it here in Reset. */
+    /** @todo It isn't clear in the spec. where exactly the default base address
+     *        is (re)initialized, atm we do it here in Reset. */
     apicR3ResetBaseMsr(pVCpu);
 
@@ -985 +988 @@
             SupApicPage.Phys = NIL_RTHCPHYS;
 
+            Assert(pVCpu->idCpu == idCpu);
             Assert(pApicCpu->pvApicPageR3 == NIL_RTR0PTR);
             Assert(pApicCpu->pvApicPageR0 == NIL_RTR0PTR);
@@ -1154 +1158 @@
     pApic->pApicDevRC   = PDMINS_2_DATA_RCPTR(pDevIns);
 
-    rc = apicR3InitState(pVM);
-    AssertRCReturn(rc, rc);
+    apicR3InitState(pVM);
 
     /*

trunk/src/VBox/VMM/include/APICInternal.h

@@ -441 +441 @@
     /** @} */
 
-    /** @name The APIC pending interrupt bitmap (PIB).
+    /** @name The APIC pending-interrupt bitmap (PIB).
      * @{ */
     /** The host-context physical address of the PIB. */
@@ -519 +519 @@
     /** @} */
 
-    /** @name The pending interrupt bitmaps (PIB).
+    /** @name The pending-interrupt bitmaps (PIB).
      * @{ */
     /** The host-context physical address of the page. */

trunk/src/VBox/VMM/testcase/Makefile.kmk

@@ -152 +152 @@
   tstVMStructRC_DEFS    += VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
  endif
+ ifdef VBOX_WITH_NEW_APIC
+  tstVMStructRC_DEFS    += VBOX_WITH_NEW_APIC
+ endif
  tstVMStructRC_SOURCES   = tstVMStructRC.cpp
  tstVMStructRC_INCS      = \
@@ -177 +180 @@
  tstVMStructSize_DEFS  += VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
 endif
+ifdef VBOX_WITH_NEW_APIC
+ tstVMStructSize_DEFS  += VBOX_WITH_NEW_APIC
+endif
 
 tstAsmStructs_TEMPLATE  = VBOXR3AUTOTST
@@ -188 +194 @@
 ifdef VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
  tstAsmStructs_DEFS    += VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
+endif
+ifdef VBOX_WITH_NEW_APIC
+ tstAsmStructs_DEFS    += VBOX_WITH_NEW_APIC
 endif
 tstAsmStructs_INCS      = \
@@ -203 +212 @@
  ifdef VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
   tstAsmStructsRC_DEFS  += VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
+ endif
+ ifdef VBOX_WITH_NEW_APIC
+  tstAsmStructsRC_DEFS  += VBOX_WITH_NEW_APIC
  endif
  tstAsmStructsRC_INCS    = \
@@ -482 +494 @@
   tstVMStructDTrace_DEFS  += VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI
  endif
+ ifdef VBOX_WITH_NEW_APIC
+  tstVMStructDTrace_DEFS  += VBOX_WITH_NEW_APIC
+ endif
 
 
@@ -523 +538 @@
                         $(DEFS.$(KBUILD_TARGET).$(KBUILD_TARGET_ARCH)) \
                         $(if $(VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI),VBOX_WITH_VMMR0_DISABLE_LAPIC_NMI,) \
+                        $(if $(VBOX_WITH_NEW_APIC),VBOX_WITH_NEW_APIC,) \
                 ) \
                 -f $(if $(eq $(KBUILD_TARGET),darwin),macho,elf) \

trunk/src/VBox/VMM/testcase/tstVMStruct.h

@@ -8 +8 @@
 
 /*
- * Copyright (C) 2006-2015 Oracle Corporation
+ * Copyright (C) 2006-2016 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -1364 +1364 @@
 #endif
 
+#ifdef VBOX_WITH_NEW_APIC
+    GEN_CHECK_SIZE(APIC);
+    GEN_CHECK_OFF(APIC, pApicDevR0);
+    GEN_CHECK_OFF(APIC, pApicDevR3);
+    GEN_CHECK_OFF(APIC, pApicDevRC);
+    GEN_CHECK_OFF(APIC, pvApicPibR0);
+    GEN_CHECK_OFF(APIC, pvApicPibR3);
+    GEN_CHECK_OFF(APIC, pvApicPibRC);
+    GEN_CHECK_OFF(APIC, cbApicPib);
+    GEN_CHECK_OFF(APIC, enmOriginalMode);
+    GEN_CHECK_OFF(APICCPU, pvApicPageR0);
+    GEN_CHECK_OFF(APICCPU, pvApicPageR3);
+    GEN_CHECK_OFF(APICCPU, pvApicPageRC);
+    GEN_CHECK_OFF(APICCPU, pvApicPageRC);
+    GEN_CHECK_OFF(APICCPU, cbApicPage);
+    GEN_CHECK_OFF(APICCPU, pvApicPibR0);
+    GEN_CHECK_OFF(APICCPU, pvApicPibR3);
+    GEN_CHECK_OFF(APICCPU, pvApicPibRC);
+    GEN_CHECK_OFF(APICCPU, ApicPibLevel);
+    GEN_CHECK_OFF(APICCPU, pTimerR0);
+    GEN_CHECK_OFF(APICCPU, pTimerR3);
+    GEN_CHECK_OFF(APICCPU, pTimerRC);
+    GEN_CHECK_OFF(APICCPU, TimerCritSect);
+#endif
 
     GEN_CHECK_SIZE(VM);
@@ -1425 +1449 @@
     GEN_CHECK_OFF(VM, ftm);
     GEN_CHECK_OFF(VM, rem);
+    GEN_CHECK_OFF(VM, gim);
     GEN_CHECK_OFF(VM, vm);
     GEN_CHECK_OFF(VM, cfgm);
+#ifdef VBOX_WITH_NEW_APIC
+    GEN_CHECK_OFF(VM, apic);
+#endif
     GEN_CHECK_OFF(VM, aCpus);
 
@@ -1444 +1472 @@
     GEN_CHECK_OFF(VMCPU, uAdHoc);
     GEN_CHECK_OFF(VMCPU, aStatAdHoc);
-    GEN_CHECK_OFF(VMCPU, cpum);
     GEN_CHECK_OFF(VMCPU, hm);
     GEN_CHECK_OFF(VMCPU, em);
@@ -1454 +1481 @@
     GEN_CHECK_OFF(VMCPU, iom);
     GEN_CHECK_OFF(VMCPU, dbgf);
+    GEN_CHECK_OFF(VMCPU, gim);
+#ifdef VBOX_WITH_NEW_APIC
+    GEN_CHECK_OFF(VMCPU, apic);
+#endif
     GEN_CHECK_OFF(VMCPU, pgm);
+    GEN_CHECK_OFF(VMCPU, cpum);
 
 #ifndef VBOX_FOR_DTRACE_LIB

trunk/src/VBox/VMM/testcase/tstVMStructDTrace.cpp

@@ -7 +7 @@
 
 /*
- * Copyright (C) 2006-2015 Oracle Corporation
+ * Copyright (C) 2006-2016 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -43 +43 @@
 #include "REMInternal.h"
 #include "HMInternal.h"
+#ifdef VBOX_WITH_NEW_APIC
+# include "APICInternal.h"
+#endif
 #include "VMMInternal.h"
 #include "DBGFInternal.h"

trunk/src/VBox/VMM/testcase/tstVMStructRC.cpp

@@ -9 +9 @@
 
 /*
- * Copyright (C) 2006-2015 Oracle Corporation
+ * Copyright (C) 2006-2016 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -71 +71 @@
 #include "REMInternal.h"
 #include "HMInternal.h"
+#ifdef VBOX_WITH_NEW_APIC
+# include "APICInternal.h"
+#endif
 #include "PATMInternal.h"
 #include "VMMInternal.h"

trunk/src/VBox/VMM/testcase/tstVMStructSize.cpp

@@ -7 +7 @@
 
 /*
- * Copyright (C) 2006-2015 Oracle Corporation
+ * Copyright (C) 2006-2016 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -46 +46 @@
 #include "DBGFInternal.h"
 #include "GIMInternal.h"
-#include "APICInternal.h"
+#ifdef VBOX_WITH_NEW_APIC
+# include "APICInternal.h"
+#endif
 #include "STAMInternal.h"
 #include "VMInternal.h"