Changeset 60476 in vbox

Timestamp:

Apr 13, 2016 2:42:43 PM (8 years ago)

Author:

vboxsync

Message:

VMM/APIC: Fix inverted condition while determining lowest-priority delivery mode.

File:

• trunk/src/VBox/VMM/VMMAll/APICAll.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/APICAll.cpp

@@ -618 +618 @@
                 && apicIsEnabled(&pVM->aCpus[idCpu]))
                 APICPostInterrupt(&pVM->aCpus[idCpu], uVector, enmTriggerMode);
+            else
+                Log4(("APIC: apicSendIntr: No CPU found for lowest-priority delivery mode!\n"));
             break;
         }
@@ -813 +815 @@
                 uint8_t const u8Tpr      = pXApicPage->tpr.u8Tpr;         /* PAV */
 
-                /* If there is a tie for lowest priority, the local APIC with the highest ID is chosen.
-                   See AMD spec. 16.6.2 "Lowest Priority Messages and Arbitration". */
-                if (u8LowestTpr <= u8Tpr)
+                /*
+                 * If there is a tie for lowest priority, the local APIC with the highest ID is chosen.
+                 * Hence the use of "<=" in the check below.
+                 * See AMD spec. 16.6.2 "Lowest Priority Messages and Arbitration".
+                 */
+                if (u8Tpr <= u8LowestTpr)
                 {
                     u8LowestTpr    = u8Tpr;