Changeset 59814 in vbox

Timestamp:

Feb 25, 2016 11:20:12 AM (9 years ago)

Author:

vboxsync

Message:

FE/Qt: Qt5 migration (part 98): Workaround for full-screen/seamless modes, Qt5 somehow forgets to init windows as mapped if they initially shown as frameless, that freezes any painting at all.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime

Files:

• fullscreen/UIMachineWindowFullscreen.cpp (modified) (2 diffs)
• fullscreen/UIMachineWindowFullscreen.h (modified) (1 diff)
• seamless/UIMachineWindowSeamless.cpp (modified) (1 diff)
• seamless/UIMachineWindowSeamless.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/fullscreen/UIMachineWindowFullscreen.cpp

@@ -232 +232 @@
         UICocoaApplication::instance()->registerToNotificationOfWindow("NSWindowDidFailToEnterFullScreenNotification", this,
                                                                        UIMachineWindow::handleNativeNotification);
-    }
+}
 #endif /* Q_WS_MAC */
 }
@@ -483 +483 @@
 #endif /* Q_WS_WIN || Q_WS_X11 */
 
+#ifdef Q_WS_WIN
+# if QT_VERSION >= 0x050000
+void UIMachineWindowFullscreen::showEvent(QShowEvent *pEvent)
+{
+    /* Expose workaround again,
+     * Qt devs will never fix that it seems.
+     * This time they forget to set 'Mapped'
+     * attribute for initially frame-less window. */
+    setAttribute(Qt::WA_Mapped);
+
+    /* Call to base-class: */
+    UIMachineWindow::showEvent(pEvent);
+}
+# endif /* QT_VERSION >= 0x050000 */
+#endif /* Q_WS_WIN */
+

trunk/src/VBox/Frontends/VirtualBox/src/runtime/fullscreen/UIMachineWindowFullscreen.h

@@ -102 +102 @@
 #endif /* Q_WS_WIN || Q_WS_X11 */
 
+#ifdef Q_WS_WIN
+# if QT_VERSION >= 0x050000
+    /** Win: Handles show @a pEvent. */
+    void showEvent(QShowEvent *pEvent);
+# endif /* QT_VERSION >= 0x050000 */
+#endif /* Q_WS_WIN */
+
 #if defined(Q_WS_WIN) || defined(Q_WS_X11)
     /** Holds the mini-toolbar instance. */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/seamless/UIMachineWindowSeamless.cpp

@@ -267 +267 @@
 #endif /* Q_WS_WIN || Q_WS_X11 */
 
-#if defined(VBOX_WITH_TRANSLUCENT_SEAMLESS) && defined(Q_WS_WIN)
-void UIMachineWindowSeamless::showEvent(QShowEvent *pShowEvent)
-{
-    /* Call to base class: */
-    UIMachineWindow::showEvent(pShowEvent);
-
-    /* Following workaround allows to fix the next Qt BUG:
-     * https://bugreports.qt-project.org/browse/QTBUG-17548
-     * https://bugreports.qt-project.org/browse/QTBUG-30974
-     * Widgets with Qt::WA_TranslucentBackground attribute
-     * stops repainting after minimizing/restoring, we have to call for single update. */
-    QApplication::postEvent(this, new QEvent(QEvent::UpdateRequest), Qt::LowEventPriority);
-}
-#endif /* VBOX_WITH_TRANSLUCENT_SEAMLESS && Q_WS_WIN */
+#ifdef Q_WS_WIN
+# if QT_VERSION >= 0x050000
+void UIMachineWindowSeamless::showEvent(QShowEvent *pEvent)
+{
+    /* Expose workaround again,
+     * Qt devs will never fix that it seems.
+     * This time they forget to set 'Mapped'
+     * attribute for initially frame-less window. */
+    setAttribute(Qt::WA_Mapped);
+
+    /* Call to base-class: */
+    UIMachineWindow::showEvent(pEvent);
+}
+# endif /* QT_VERSION >= 0x050000 */
+#endif /* Q_WS_WIN */
 
 #ifdef VBOX_WITH_MASKED_SEAMLESS

trunk/src/VBox/Frontends/VirtualBox/src/runtime/seamless/UIMachineWindowSeamless.h

@@ -74 +74 @@
 #endif /* Q_WS_WIN || Q_WS_X11 */
 
-#if defined(VBOX_WITH_TRANSLUCENT_SEAMLESS) && defined(Q_WS_WIN)
-    /** Windows: Translucency stuff workaround. */
+#ifdef Q_WS_WIN
+# if QT_VERSION >= 0x050000
+    /** Win: Handles show @a pEvent. */
     void showEvent(QShowEvent *pEvent);
-#endif /* VBOX_WITH_TRANSLUCENT_SEAMLESS && Q_WS_WIN */
+# endif /* QT_VERSION >= 0x050000 */
+#endif /* Q_WS_WIN */
 
 #ifdef VBOX_WITH_MASKED_SEAMLESS