Changeset 59307 in vbox

Timestamp:

Jan 11, 2016 11:37:12 AM (9 years ago)

Author:

vboxsync

Message:

bugref:8183: Mouse Integration sometimes not working after restore from saved state: fix a mishandling of the guest cursor shape protocol in the graphics device. When the guest sends a cursor shape event with the visible flag set but no shape data, the value of the alpha flag should be ignored. We were indeed ignoring it, but still saving its (usually incorrect) value to the device context, overwriting the old value, and from there to the saved state.

File:

• trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

@@ -767 +767 @@
     pCtx->mouseShapeInfo.fSet = true;
     pCtx->mouseShapeInfo.fVisible = fVisible;
-    pCtx->mouseShapeInfo.fAlpha = fAlpha;
     if (fShape)
     {
@@ -775 +774 @@
         pCtx->mouseShapeInfo.u32Width = parms.u32Width;
         pCtx->mouseShapeInfo.u32Height = parms.u32Height;
+        pCtx->mouseShapeInfo.fAlpha = fAlpha;
 
         /* Reallocate memory buffer if necessary. */