Changeset 58605 in vbox

Timestamp:

Nov 6, 2015 1:25:50 PM (9 years ago)

Author:

vboxsync

Message:

IEM: Fixed OpenBSD 5.8, incorred treatment of reserved/ignored CR3 bits.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h

@@ -17 +17 @@
 
 
+#define IEM_IMPLEMENTS_CALLGATE
 /** @name Misc Helpers
  * @{
@@ -4907 +4908 @@
          * CR3 is relatively simple, although AMD and Intel have different
          * accounts of how setting reserved bits are handled.  We take intel's
-         * word for the lower bits and AMD's for the high bits (63:52).
+         * word for the lower bits and AMD's for the high bits (63:52).  The
+         * lower reserved bits are ignored and left alone; OpenBSD 5.8 relies
+         * on this.
          */
         /** @todo Testcase: Setting reserved bits in CR3, especially before
@@ -4923 +4926 @@
             if (   (pCtx->cr4 & X86_CR4_PAE)
                 && (pCtx->msrEFER & MSR_K6_EFER_LME))
-                fValid = UINT64_C(0x000ffffffffff014);
-            else if (pCtx->cr4 & X86_CR4_PAE)
-                fValid = UINT64_C(0xfffffff4);
+                fValid = UINT64_C(0x000fffffffffffff);
             else
-                fValid = UINT64_C(0xfffff014);
+                fValid = UINT64_C(0xffffffff);
             if (uNewCrX & ~fValid)
             {
-                Log(("Automatically clearing reserved bits in CR3 load: NewCR3=%#llx ClearedBits=%#llx\n",
+                Log(("Automatically clearing reserved MBZ bits in CR3 load: NewCR3=%#llx ClearedBits=%#llx\n",
                      uNewCrX, uNewCrX & ~fValid));
                 uNewCrX &= fValid;